Your message dated Thu, 31 Oct 2013 15:37:34 +0000
with message-id <[email protected]>
and subject line Bug#695294: fixed in moria 5.6.debian.1-1
has caused the Debian Bug report #695294,
regarding Moria 1 char overflow in hours reading code
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
695294: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=695294
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: moria
Version: 5.6-2
On the ubuntu builds of Moria with fortify, Moria is crashing on startup:
https://bugs.launchpad.net/ubuntu/+source/moria/+bug/925005
This looks to me like the hours reader has forgetten about the \n
on the line that they've read in and end up copying one too many
chars into the buffer; I have a fix that seems to get it to work,
however I don't know the game so it needs checking to see it's
not broken the hours stuff:
--- moria-5.6/source/files.c 2008-10-14 00:44:36.000000000 +0100
+++ moria-5.6.dag/source/files.c 2012-12-06 17:48:38.072272999 +0000
@@ -125,6 +125,12 @@
while (fgets(in_line, 80, file1) != CNIL)
if (strlen(in_line) > 3)
{
+ /* These lines should be as in tables.c - i.e.
+ 3 letter day, :, 24 chars, one per hour
+ the fgets will have read a \n which I'm
+ about to NULL */
+ in_line[3+1+24]='\0';
+
if (!strncmp(in_line, "SUN:", 4))
(void) strcpy(days[0], in_line);
else if (!strncmp(in_line, "MON:", 4))
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ gro.gilbert @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
--- End Message ---
--- Begin Message ---
Source: moria
Source-Version: 5.6.debian.1-1
We believe that the bug you reported is fixed in the latest version of
moria, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Phil Brooke <[email protected]> (supplier of updated moria package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Thu, 31 Oct 2013 14:33:18 +0000
Source: moria
Binary: moria
Architecture: source i386
Version: 5.6.debian.1-1
Distribution: unstable
Urgency: low
Maintainer: Phil Brooke <[email protected]>
Changed-By: Phil Brooke <[email protected]>
Description:
moria - Rogue-like game with an infinite dungeon
Closes: 695294 724943
Changes:
moria (5.6.debian.1-1) unstable; urgency=low
.
* Repackaged source tarball to remove non-free files. As a result,
totally removed the Atari ST, Amiga and Mac source directories
(closes: #724943).
* Use strncpy not strcpy to read hours file (closes: #695294). Also added
-D_FORTIFY_SOURCE=2 to Makefile to check this solution.
* Bump standards-version to 3.9.4.
* Tidy up debian/docs to remove a duplicate file in .../docs/moria
and rename some debian files to moria.
* Add dpkg-buildflags CFLAGS / LDFLAGS to source/Makefile. Then fix
some (s)printf format strings.
Checksums-Sha1:
41fa323eed3ba913091a8024f1fb417ebd51777c 1034 moria_5.6.debian.1-1.dsc
12426d03ae09de6c224f159f0938d85afe7de9cc 570411 moria_5.6.debian.1.orig.tar.gz
7dde278cc80f81d4c827ca71ce670232591a34cc 31024 moria_5.6.debian.1-1.diff.gz
812b12b89f6bc9b54ab855ebe55457cd28f6fa95 217398 moria_5.6.debian.1-1_i386.deb
Checksums-Sha256:
0e04a93d5f8cf4a1c830130a78ec16ecc12a4960e9026d0fcf3a144ecfc7aae9 1034
moria_5.6.debian.1-1.dsc
07e2c4e6e91413ec9c351bd0979c141d4938a263e6251aad25a3796cdd353cb0 570411
moria_5.6.debian.1.orig.tar.gz
5f624361330903d1b7c13df22d0f4222e86c5df22eca62e622b9462fdef396c9 31024
moria_5.6.debian.1-1.diff.gz
eb0d359c8a8d88d2f6235d837d85143f3fd07045e9efca8378b9bafc18c780df 217398
moria_5.6.debian.1-1_i386.deb
Files:
6551806bf2b7950620b0b63a75be68a1 1034 games optional moria_5.6.debian.1-1.dsc
67d4396cd4cccac2bf6abff3dc090b6c 570411 games optional
moria_5.6.debian.1.orig.tar.gz
7c603eecefe487b134eecf95ae6b407a 31024 games optional
moria_5.6.debian.1-1.diff.gz
50d3a609902f482e80f90a25348fe977 217398 games optional
moria_5.6.debian.1-1_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iEYEARECAAYFAlJya9wACgkQHb8HEVCXO5E+4ACfTcHjX80JDJVRjPTGptEYUQsH
+kcAnigGCpl4oUBYpQo6Ol7m0gmBZZey
=v3tU
-----END PGP SIGNATURE-----
--- End Message ---
