Your message dated Fri, 1 Nov 2013 08:35:01 +0000
with message-id <20131101083501.GB2624@tesla>
and subject line Re: [Python-apps-team] Bug#728272: python3-memprof: missing 
python3-pkg-resources dependency
has caused the Debian Bug report #728272,
regarding python3-memprof: missing python3-pkg-resources dependency
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
728272: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=728272
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: python3-memprof
Version: 0.3.2-1
Tags: patch
User: [email protected]
Usertags: origin-ubuntu ubuntu-patch trusty

Hello,

python3-memprof imports "pkg_resources" without depending on
python3-pkg-resources. In Debian this gets pulled in through a
transitive dependency with matplotlib, but as memprof uses it itself
it should directly depend on it instead of relying on these.

E. g. in Ubuntu we still have an older matplotlib and thus
pkg_resources doesn't get installed with it, which is exposed by the
failing autopkgtest (Many thanks for adding one! It's exactly the kind
of thing which they are meant to detect):

  
https://jenkins.qa.ubuntu.com/view/Trusty/view/AutoPkgTest/job/trusty-adt-python-memprof/2/ARCH=i386,label=adt/

Thanks for considering,

Martin

-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
diff -Nru python-memprof-0.3.2/debian/changelog 
python-memprof-0.3.2/debian/changelog
--- python-memprof-0.3.2/debian/changelog       2013-10-20 23:29:06.000000000 
+0200
+++ python-memprof-0.3.2/debian/changelog       2013-10-30 06:53:58.000000000 
+0100
@@ -1,3 +1,9 @@
+python-memprof (0.3.2-1ubuntu1) trusty; urgency=low
+
+  * Add missing python3-pkg-resources dependency (spotted by autopkgtest).
+
+ -- Martin Pitt <[email protected]>  Wed, 30 Oct 2013 06:53:34 +0100
+
 python-memprof (0.3.2-1) unstable; urgency=low
 
   * New upstream release
diff -Nru python-memprof-0.3.2/debian/control 
python-memprof-0.3.2/debian/control
--- python-memprof-0.3.2/debian/control 2013-10-18 12:19:57.000000000 +0200
+++ python-memprof-0.3.2/debian/control 2013-10-30 06:54:02.000000000 +0100
@@ -40,6 +41,7 @@
 Depends: ${misc:Depends},
  ${python3:Depends},
  ${shlibs:Depends},
+ python3-pkg-resources
 Recommends: python-memprof
 Description: memory profiler for Python (Python 3)
  python-memprof logs the memory used by variables during the execution

Attachment: signature.asc
Description: Digital signature


--- End Message ---
--- Begin Message ---
Version: 0.3.3-2

On Thu, Oct 31, 2013 at 07:03:31PM +0000, Javi Merino wrote:
> On Wed, Oct 30, 2013 at 06:59:04AM +0100, Martin Pitt wrote:
> > Hello,
> 
> Hi Martin,
>  
> > python3-memprof imports "pkg_resources" without depending on
> > python3-pkg-resources. In Debian this gets pulled in through a
> > transitive dependency with matplotlib, but as memprof uses it itself
> > it should directly depend on it instead of relying on these.
> 
> You are right, I added the dependency for python-memprof and forgot
> about python3-memprof.

I applied your patch but forgot to add the "Closes: #728272" to your
changelog entry.  FTR, this has been fixed in python-memprof 0.3.3-2.

Cheers,
Javi

Attachment: signature.asc
Description: Digital signature


--- End Message ---

Reply via email to