Your message dated Tue, 5 Nov 2013 17:26:48 +0100
with message-id <[email protected]>
and subject line Not a bug
has caused the Debian Bug report #690616,
regarding nbd-client: bashism in /bin/sh script
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
690616: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=690616
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: nbd-client
Version: 1:3.2-1.1
Severity: important
User: [email protected]
Usertags: goal-dash

Hello maintainer,

While performing an archive wide checkbashisms (from the 'devscripts' 
package) check I've found your package containing a /bin/sh script making 
use of a bashism.

checkbashisms' output:
>possible bashism in ./usr/share/initramfs-tools/scripts/local-top/nbd line 
82 ([^] should be [!]):
>        *[^0-9]*)

Not using bash (or a Debian Policy conformant shell interpreter which 
doesn't provide such an extra feature) as /bin/sh is likely to lead to 
errors or unexpected behaviours.

You can find hints about how to fix bashisms at:
https://wiki.ubuntu.com/DashAsBinSh

Thank you,
Raphael Geissert

--- End Message ---
--- Begin Message ---
Hi,

Scripts under /usr/share/initramfs-tools/scripts are (conditionally) put
inside an initramfs, where they are not run by the system /bin/sh, but
by busybox sh instead.

Script started on di 05 nov 2013 17:21:58 CET
wouter@carillon:~$ cat test690616.sh
testit() {
        echo testing for $1, which should$2 be caught ...
        case $1 in
                *[^0-9]*)
                        echo "caught"
                        ;;
                *[!0-9]*)
                        echo "backup"
                        ;;
                *)
                        echo not caught...
                        ;;
        esac
}

testit 11 " not"
testit 1a1

wouter@carillon:~$ bash test690616.sh
testing for 11, which should not be caught ...
not caught...
testing for 1a1, which should be caught ...
caught
wouter@carillon:~$ busybox sh test690616.sh
testing for 11, which should not be caught ...
not caught...
testing for 1a1, which should be caught ...
caught
wouter@carillon:~$ exit

Script done on di 05 nov 2013 17:22:20 CET

Closing, since I think the ^ notation is clearer, and it isn't an issue
because the shell with which it will always be run supports that
notation.

-- 
This end should point toward the ground if you want to go to space.

If it starts pointing toward space you are having a bad problem and you
will not go to space today.

  -- http://xkcd.com/1133/

--- End Message ---

Reply via email to