Your message dated Sat, 21 Dec 2013 11:58:29 +0000
with message-id 
<CAPQ4b8=-cyyk58vwhmtwegr1ebeggm33qs1qdy6ynwzvfpd...@mail.gmail.com>
and subject line Re: Bug#725143: Bug#728521: ogre-1.9 / gcc-4.8
has caused the Debian Bug report #725143,
regarding unbuildable on some archs
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
725143: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=725143
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: ogre-1.9
Tags: patch

Using __sync_fetch_and_add_8 on architectures without native support requires the libatomic library (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56300), which is part of GCC 4.8+.

The attached patch links against this library and forces compilation with gcc/g++ 4.8. It also disables --as-needed on ia64 to work around bug #718047.

This should fix everything except armhf (crashing make, which is a bug there not here), but has not been tested.
$ diff -up rules_orig rules
--- rules_orig	2013-10-01 20:30:06.846713326 +0100
+++ rules	2013-10-01 20:52:56.234672865 +0100
@@ -15,8 +15,13 @@ export DEB_BUILD_MAINT_OPTIONS   := hard
 dpkg_buildflags = DEB_BUILD_MAINT_OPTIONS=$(DEB_BUILD_MAINT_OPTIONS) dpkg-buildflags
 export DEB_CFLAGS_MAINT_APPEND   := -pipe -Wall $(shell $(dpkg_buildflags) --get CPPFLAGS)
 export DEB_CXXFLAGS_MAINT_APPEND := -pipe -Wall $(shell $(dpkg_buildflags) --get CPPFLAGS)
-export DEB_LDFLAGS_MAINT_APPEND  := -Wl,-z,defs -Wl,--as-needed
-
+# -latomic for __sync_fetch_and_add_8
+# disable -Wl,--as-needed on ia64 due to bug #718047
+ifeq($(DEB_HOST_ARCH),ia64)
+export DEB_LDFLAGS_MAINT_APPEND  := -Wl,-z,defs -latomic
+else
+export DEB_LDFLAGS_MAINT_APPEND  := -Wl,-z,defs -Wl,--as-needed -latomic
+endif
 
 DEB_HOST_MULTIARCH ?= $(shell dpkg-architecture -qDEB_HOST_MULTIARCH)
 
@@ -47,7 +52,8 @@ override_dh_auto_configure:
 		-DOGRE_INSTALL_DOCS:BOOL=TRUE \
 		-DOGRE_BUILD_SAMPLES:BOOL=FALSE \
 		-DOGRE_INSTALL_SAMPLES:BOOL=FALSE \
-		-DOGRE_INSTALL_SAMPLES_SOURCE:BOOL=FALSE
+		-DOGRE_INSTALL_SAMPLES_SOURCE:BOOL=FALSE \
+		-DCMAKE_C_COMPILER=gcc-4.8 -DCMAKE_CXX_COMPILER=g++-4.8
 
 override_dh_install:
         # Copy files from template for this particular version
$ diff -up control_orig control
--- control_orig	2013-10-01 21:00:50.306658858 +0100
+++ control	2013-10-01 21:02:02.410656727 +0100
@@ -28,7 +28,8 @@ Build-Depends: debhelper (>= 9~),
                libxaw7-dev,
                libxt-dev,
                libois-dev [linux-any],
-               chrpath
+               chrpath,
+               g++-4.8
 
 Package: libogre-1.9-dev
 Section: libdevel

--- End Message ---
--- Begin Message ---
Control: fixed -1 ogre-1.9/1.9.0+dfsg1-1

2013/12/20 Rebecca N. Palmer <[email protected]>:
>> It's been built successfully in s390x and most other arches (at least
>> the ones where it was present before with src:ogre-1.9)
>
> The only one we still need is armhf, where this has never been a problem.

It compiled fine now for all except for sparc and powerpc, even in
some ports like powerpc64 (oddly enough the newcomer ppc64 seems to
have GCC 4.8 as default, but not for powerpc).

The rest of architectures should compile successfully as soon as the
default GCC version is upgraded, which I hope that it's very soon.  So
I am going to close this now.


Cheers and thanks.
-- 
Manuel A. Fernandez Montecelo <[email protected]>

--- End Message ---

Reply via email to