Bug#707165: marked as done (dh-make-perl: Failed tests from t/dists.t file: incorrect timestamp regexp, for EDT time zone.)

Wed, 22 Jan 2014 10:46:05 -0800 

Your message dated Wed, 22 Jan 2014 19:40:20 +0100
with message-id <[email protected]>
and subject line Re: Bug#707165: dh-make-perl: Failed tests from t/dists.t 
file: incorrect timestamp regexp, for EDT time zone.
has caused the Debian Bug report #707165,
regarding dh-make-perl: Failed tests from t/dists.t file: incorrect timestamp 
regexp, for EDT time zone.
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
707165: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=707165
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message --- 
Package: dh-make-perl
Version: 0.76-1
Severity: minor
If time zone is EDT, failed tests from t/dists.t file: Generated tree matches template. Problem with incorrect timestamp regexp. 

$ date +%z
-0400

Steps to reproduce:
1) git clone git://anonscm.debian.org/pkg-perl/packages/dh-make-perl.git
2) cd dh-make-perl
3) prove -l t/dists.t

Expected result: tests passed.

Actual result:

t/dists.t .. 1/16
#   Failed test 'Generated tree matches template (initial)'
#   at t/dists.t line 83.
# got: '--- /tmp/dh-make-perl/t/dists/Strange-0.1/debian/changelog Tue May 7 14:11:50 2013 # +++ /tmp/dh-make-perl/t/dists/Strange-0.1/wanted-debian/changelog Tue May 7 14:05:56 2013 
# @@ -2,4 +2,4 @@
#
#    * Initial Release.
#
# - -- Joe Maintainer <[email protected]>  Tue, 7 May 2013 14:11:50 -0400
# + -- Joe Maintainer <[email protected]>  Sat, 29 Nov 2008 23:17:07 +0200
#
# '
#     expected: ''
t/dists.t .. 3/16
#   Failed test 'Generated tree matches template (refresh)'
#   at t/dists.t line 83.
# got: '--- /tmp/dh-make-perl/t/dists/Strange-0.1/debian/changelog Tue May 7 14:11:50 2013 # +++ /tmp/dh-make-perl/t/dists/Strange-0.1/wanted-debian--refresh/changelog Tue May 7 14:05:56 2013 
# @@ -2,4 +2,4 @@
#
#    * Initial Release.
#
# - -- Joe Maintainer <[email protected]>  Tue, 7 May 2013 14:11:50 -0400
# + -- Joe Maintainer <[email protected]>  Sat, 29 Nov 2008 23:17:07 +0200
#
# '
#     expected: ''
t/dists.t .. 5/16
# Failed test 'Generated tree matches template (refresh --source-format 3.0 (quilt))' 
#   at t/dists.t line 83.
# got: '--- /tmp/dh-make-perl/t/dists/Strange-0.1/debian/changelog Tue May 7 14:11:50 2013 # +++ /tmp/dh-make-perl/t/dists/Strange-0.1/wanted-debian--refresh--source-format=3.0_quilt/changelog Tue May 7 14:05:56 2013 
# @@ -2,4 +2,4 @@
#
#    * Initial Release.
#
# - -- Joe Maintainer <[email protected]>  Tue, 7 May 2013 14:11:50 -0400
# + -- Joe Maintainer <[email protected]>  Sat, 29 Nov 2008 23:17:07 +0200
# '
#     expected: ''
t/dists.t .. 7/16
#   Failed test 'Generated tree matches template (email)'
#   at t/dists.t line 83.
# got: '--- /tmp/dh-make-perl/t/dists/Strange-0.1/debian/changelog Tue May 7 14:11:53 2013 # +++ /tmp/dh-make-perl/t/dists/Strange-0.1/wanted-debian--refresh-email/changelogTue May 7 14:05:56 2013 
# @@ -8,4 +8,4 @@
#
#    * Initial Release.
#
# - -- Joe Maintainer <[email protected]>  Tue, 7 May 2013 14:11:50 -0400
# + -- Joe Maintainer <[email protected]>  Sat, 29 Nov 2008 23:17:07 +0200
# '
#     expected: ''
t/dists.t .. 9/16
#   Failed test 'Generated tree matches template (initial)'
#   at t/dists.t line 83.
# got: '--- /tmp/dh-make-perl/t/dists/Strange-2.1/debian/changelog Tue May 7 14:12:01 2013 # +++ /tmp/dh-make-perl/t/dists/Strange-2.1/wanted-debian/changelog Tue May 7 14:05:56 2013 
# @@ -2,4 +2,4 @@
#
#    * Initial Release.
#
# - -- Joe Maintainer <[email protected]>  Tue, 7 May 2013 14:12:01 -0400
# + -- Joe Maintainer <[email protected]>  Sun, 30 Nov 2008 12:20:18 +0200
#
# '
#     expected: ''
t/dists.t .. 11/16
#   Failed test 'Generated tree matches template (refresh)'
#   at t/dists.t line 83.
# got: '--- /tmp/dh-make-perl/t/dists/Strange-2.1/debian/changelog Tue May 7 14:12:01 2013 # +++ /tmp/dh-make-perl/t/dists/Strange-2.1/wanted-debian--refresh/changelog Tue May 7 14:05:56 2013 
# @@ -2,4 +2,4 @@
#
#    * Initial Release.
#
# - -- Joe Maintainer <[email protected]>  Tue, 7 May 2013 14:12:01 -0400
# + -- Joe Maintainer <[email protected]>  Sun, 30 Nov 2008 12:20:18 +0200
#
# '
#     expected: ''
t/dists.t .. 13/16
# Failed test 'Generated tree matches template (refresh --source-format 3.0 (quilt))' 
#   at t/dists.t line 83.
# got: '--- /tmp/dh-make-perl/t/dists/Strange-2.1/debian/changelog Tue May 7 14:12:01 2013 # +++ /tmp/dh-make-perl/t/dists/Strange-2.1/wanted-debian--refresh--source-format=3.0_quilt/changelog Tue May 7 14:05:56 2013 
# @@ -2,4 +2,4 @@
#
#    * Initial Release.
#
# - -- Joe Maintainer <[email protected]>  Tue, 7 May 2013 14:12:01 -0400
# + -- Joe Maintainer <[email protected]>  Sun, 30 Nov 2008 12:20:18 +0200
# '
#     expected: ''
t/dists.t .. 15/16
#   Failed test 'Generated tree matches template (email)'
#   at t/dists.t line 83.
# got: '--- /tmp/dh-make-perl/t/dists/Strange-2.1/debian/changelog Tue May 7 14:12:04 2013 # +++ /tmp/dh-make-perl/t/dists/Strange-2.1/wanted-debian--refresh-email/changelogTue May 7 14:05:56 2013 
# @@ -8,4 +8,4 @@
#
#    * Initial Release.
#
# - -- Joe Maintainer <[email protected]>  Tue, 7 May 2013 14:12:01 -0400
# + -- Joe Maintainer <[email protected]>  Sat, 29 Nov 2008 23:17:07 +0200
# '
#     expected: ''
# Looks like you failed 8 tests of 16.
t/dists.t .. Dubious, test returned 8 (wstat 2048, 0x800)
Failed 8/16 subtests

Test Summary Report
-------------------
t/dists.t (Wstat: 2048 Tests: 16 Failed: 8)
  Failed tests:  2, 4, 6, 8, 10, 12, 14, 16
  Non-zero exit status: 8
Files=1, Tests=16, 22 wallclock secs ( 0.05 usr 0.04 sys + 12.05 cusr 2.96 csys = 15.10 CPU) 
Result: FAIL


-- System Information:
Debian Release: 7.0
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-4-amd64 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages dh-make-perl depends on:
ii  debhelper                         9.20120909
ii  dpkg-dev                          1.16.10
ii  fakeroot                          1.18.4-2
ii  libapt-pkg-perl                   0.1.27
ii  libarray-unique-perl              0.08-1
ii  libclass-accessor-perl            0.34-1
ii  libdpkg-perl                      1.16.10
ii  libemail-address-perl             1.898-1
ii  libemail-date-format-perl         1.002-1
ii  libfile-which-perl                1.09-1
ii  liblist-moreutils-perl            0.33-1+b1
ii  libmodule-depends-perl            0.16-1
ii  libparse-debcontrol-perl          2.005-3
ii  libparse-debianchangelog-perl     1.2.0-1
ii  libsoftware-license-perl          0.103005-1
ii  libtie-ixhash-perl                1.23-1
ii  libwww-mechanize-perl             1.71-1
ii  libyaml-perl                      0.84-1
ii  make                              3.81-8.2
ii  perl                              5.14.2-21
ii  perl-modules [libcpan-meta-perl]  5.14.2-21

Versions of packages dh-make-perl recommends:
ii  apt-file      2.5.1
ii  git           1:1.7.10.4-2
ii  pristine-tar  1.26

dh-make-perl suggests no packages.

-- no debconf information

commit 4606b98145e1adfd2124f86204aada408d5d1c20
Author: Oleg Gashev <[email protected]>
Date:   Tue May 7 16:04:30 2013 -0400

    Fixed timestamp regexp to t/dists.t file.
    
    If time zone is EDT, failed tests from t/dists.t file: Generated tree matches
    template. Problem with incorrect timestamp regexp.

diff --git a/t/dists.t b/t/dists.t
index f13e477..6bc4443 100755
--- a/t/dists.t
+++ b/t/dists.t
@@ -69,9 +69,9 @@ sub compare_tree {
                         # likewise, it is normal that the timestamp in the changelog differs
                         return 0
                             if $a
-                                =~ /^ -- Joe Maintainer <joemaint\@test\.local>  \w+, \d+ \w+ \d+ \d+:\d+:\d+ \+\d+$/
+                                =~ /^ -- Joe Maintainer <joemaint\@test\.local>  \w+, \d+ \w+ \d+ \d+:\d+:\d+ (\+|-)\d+$/
                                 and $b
-                                =~ /^ -- Joe Maintainer <joemaint\@test\.local>  \w+, \d+ \w+ \d+ \d+:\d+:\d+ \+\d+$/;
+                                =~ /^ -- Joe Maintainer <joemaint\@test\.local>  \w+, \d+ \w+ \d+ \d+:\d+:\d+ (\+|-)\d+$/;
 
                         return $a ne $b;
                     }

--- End Message ---
--- Begin Message --- 
Version: 0.77-1

Oleg Gashev wrote:
> If time zone is EDT, failed tests from t/dists.t file: Generated
> tree matches template. Problem with incorrect timestamp regexp.

gregor herrmann wrote:
> Thanks, patch applied in git.

The patch was included in 0.77-1, but the "Closes:" tag has been
forgotten in the changelog entry. Hence closing retroactively.

                Regards, Axel
-- 
 ,''`.  |  Axel Beckert <[email protected]>, http://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE
  `-    |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5

--- End Message ---

Reply via email to