Your message dated Wed, 22 Jan 2014 20:00:37 +0100 with message-id <[email protected]> and subject line Re: Bug#670188: dh-make-perl: incorrect creation of package version has caused the Debian Bug report #670188, regarding dh-make-perl: incorrect creation of package version to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 670188: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=670188 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: dh-make-perl Version: 0.75-1 Severity: normal Hi, I tried to debianize the PDL-Stats Perl module. dh-make-perl correctly gets PDL-Stats 0.6.0 from cpan. But then, it try to use version 0.6. (note the missing 0) that fails because upstream/0.6. is not a valid tag for git... Using --version does not fix anything. Looking at the code, it seems that --version is used only when the version cannot be autodetected (another bug?) But, looking into /usr/share/perl5/DhMakePerl/Command/Packaging.pm, I found at line 304: $ver =~ s/\.0+/./g; # 2.003.004 -> 2.3.4 I changed it to: $ver =~ s/\.0+(.)/.$1/g; # 2.003.004 -> 2.3.4 but 0.6.0 -> 0.6.0 so that the last 0 is kept in my case. But I not sure this is the real fix (2.000.000 will be changed into 2..0) Perhaps something (not tested) as: $ver =~ s/\.0+([0-9]|\$)/.$1/g; In any case, if this is too difficult to fix all version number, then --version should be used when provided. Regards, Vincent -- System Information: Debian Release: wheezy/sid APT prefers unstable APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 3.3.0-trunk-amd64 (SMP w/8 CPU cores) Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages dh-make-perl depends on: ii debhelper 9.20120419 ii dpkg-dev 1.16.3+0~1333384407.7~1.gbp45fe25 ii fakeroot 1.18.2-1 ii libapt-pkg-perl 0.1.26+b1 ii libarray-unique-perl 0.08-1 ii libclass-accessor-perl 0.34-1 ii libdpkg-perl 1.16.3+0~1333384407.7~1.gbp45fe25 ii libemail-address-perl 1.895-1 ii libemail-date-format-perl 1.002-1 ii libfile-which-perl 1.09-1 ii liblist-moreutils-perl 0.33-1+b1 ii libmodule-corelist-perl 2.65-1 ii libmodule-depends-perl 0.15-2 ii libparse-debcontrol-perl 2.005-3 ii libparse-debianchangelog-perl 1.2.0-1 ii libsoftware-license-perl 0.103004-2 ii libtie-ixhash-perl 1.21-2 ii libwww-mechanize-perl 1.71-1 ii libyaml-perl 0.80-1 ii make 3.81-8.2 ii perl 5.14.2-9 ii perl-modules [libmodule-corelist-perl] 5.14.2-9 Versions of packages dh-make-perl recommends: ii apt-file 2.5.0 ii git 1:1.7.10-1 ii pristine-tar 1.24 dh-make-perl suggests no packages. -- no debconf information
--- End Message ---
--- Begin Message ---Version: 0.76-1 Hi, Vincent Danjean wrote: > I tried to debianize the PDL-Stats Perl module. dh-make-perl correctly gets > PDL-Stats 0.6.0 from cpan. But then, it try to use version 0.6. (note the > missing 0) that fails because upstream/0.6. is not a valid tag for git... > Using --version does not fix anything. Looking at the code, it seems that > --version is used only when the version cannot be autodetected (another bug?) > > But, looking into /usr/share/perl5/DhMakePerl/Command/Packaging.pm, > I found at line 304: > $ver =~ s/\.0+/./g; # 2.003.004 -> 2.3.4 > I changed it to: > $ver =~ s/\.0+(.)/.$1/g; # 2.003.004 -> 2.3.4 but 0.6.0 -> 0.6.0 > so that the last 0 is kept in my case. > But I not sure this is the real fix (2.000.000 will be changed into 2..0) > Perhaps something (not tested) as: > $ver =~ s/\.0+([0-9]|\$)/.$1/g; > > In any case, if this is too difficult to fix all version number, then > --version should be used when provided. [email protected] wrote: > tag 670188 + pending > thanks > > Some bugs in the dh-make-perl package are closed in revision > a62b8ba2e3794af3c5e264a1403def9210d368d7 in branch 'master' by Damyan > Ivanov > > The full diff can be seen at > http://anonscm.debian.org/gitweb/?p=pkg-perl/packages/dh-make-perl.git;a=commitdiff;h=a62b8ba > > Commit message: > > when sanitizing version, avoid changing "2.0" to "2." > > Closes: #670188: dh-make-perl: incorrect creation of package version for > PDL-Stats 0.6.0. Thanks to Vincent Danjean. This has been fixed in the 0.76-1 upload, but the according item in the changelog entry seems to have been forgotten. Hence closing retroactively. Regards, Axel -- ,''`. | Axel Beckert <[email protected]>, http://people.debian.org/~abe/ : :' : | Debian Developer, ftp.ch.debian.org Admin `. `' | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE `- | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5
--- End Message ---
