Your message dated Thu, 23 Jan 2014 03:18:52 +0000
with message-id <[email protected]>
and subject line Bug#734875: fixed in arduino-mk 1.2.0-1
has caused the Debian Bug report #734875,
regarding arduino-mk: incorrect ARDMK_DIR results in error "ARDUINO_DIR is not 
defined"
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
734875: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=734875
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: arduino-mk
Version: 1.1.0-1
Severity: important

Dear Maintainer,

in previous arduino-mk releases I was able to user very small Makefiles
like the one below:

--------------------------------------------------------
BOARD_TAG = uno
MONITOR_PORT = /dev/ttyACM0

include /usr/share/arduino/Arduino.mk
--------------------------------------------------------

with 1.1.0 this does not work anymore and on each make invocation I get
this error:

/usr/share/arduino/Arduino.mk:279: *** "ARDUINO_DIR is not defined".  Stop.

I tracked down the cause by using "make -p", it looks like ARDUINO_DIR
can be populated by calling $(call dir_if_exists,/usr/share/arduino),
but dir_if_exists (defined in Common.mk) is not available; this is
because Common.mk is not included, it should be included from somewhere
under $(ARDMK_DIR), but $(ARDMK_DIR) is equal to /usr/share and not
/usr/share/arduino like I would expect.

So two solutions are possible:
 
  1. Fix the computation of ARDMK_DIR like this:

--- Arduino.mk.orig     2014-01-10 15:55:09.591688000 +0100
+++ Arduino.mk  2014-01-10 15:55:15.991688000 +0100
@@ -232,7 +232,7 @@ endif
 
 ifndef ARDMK_DIR
     # presume it's a level above the path to our own file
-    ARDMK_DIR := $(realpath $(dir $(realpath $(lastword $(MAKEFILE_LIST))))/..)
+    ARDMK_DIR := $(realpath $(dir $(realpath $(lastword $(MAKEFILE_LIST)))))
 else
     # show_config_variable macro is defined in Common.mk file and is not 
available yet. 
     # Let's define a variable to know that user specified ARDMK_DIR


  2. install the files under /usr/share/arduino/arduino-mk, this way the
     ARDMK_DIR calculation is still correct and the files do not need to
     be patched.

Maybe you want to ask upstream about the best approach? I like 2 better.

A workaround to make the package useful again is to define ARDMK_DIR by
hand in the Makefile before the include line:
  ARDMK_DIR = /usr/share/arduino/


BTW there is something fishy about ARDMK_PATH too, the doc says:

 => ARDMK_DIR - Where the *.mk files are stored
 => ARDMK_PATH - Where the ard-reset-arduino script is stored

but then suggests this for linux:
  ARDMK_DIR     = /usr

because ARDMK_PATH is ARDMK_DIR/bin, but this contradicts the statement
that ARDMK_DIR is where the *.mk files are.

But this is more an upstream problem.

Thanks,
   Antonio


-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (900, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.13.0-rc6-ao2 (SMP w/1 CPU core)
Locale: LANG=it_IT.utf8, LC_CTYPE=it_IT.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages arduino-mk depends on:
ii  arduino-core               1:1.0.5+dfsg2-1
ii  libconfig-yaml-perl        1.42-2
ii  libdevice-serialport-perl  1.04-2+b4
ii  perl                       5.18.1-5

Versions of packages arduino-mk recommends:
ii  perl-doc  5.18.1-5

arduino-mk suggests no packages.

-- no debconf information
-- 
Antonio Ospite
http://ao2.it

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?

--- End Message ---
--- Begin Message ---
Source: arduino-mk
Source-Version: 1.2.0-1

We believe that the bug you reported is fixed in the latest version of
arduino-mk, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Simon John <[email protected]> (supplier of updated arduino-mk package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Tue, 14 Jan 2014 15:15:00 +0000
Source: arduino-mk
Binary: arduino-mk
Architecture: source all
Version: 1.2.0-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Science Maintainers 
<[email protected]>
Changed-By: Simon John <[email protected]>
Description: 
 arduino-mk - Program your Arduino from the command line
Closes: 734875
Changes: 
 arduino-mk (1.2.0-1) unstable; urgency=medium
 .
   * New upstream release
     - Fixes ARDUINO_DIR not defined error (Closes: #734875)
Checksums-Sha1: 
 3905db12131ce16b8e99e027988d3d011d91257f 1428 arduino-mk_1.2.0-1.dsc
 7b0e1f635310a1f6e5f25940054da314a7c26c2a 38800 arduino-mk_1.2.0.orig.tar.gz
 b9b1f6dfb505e0e79c593fc4bb8af46e19197584 2780 arduino-mk_1.2.0-1.debian.tar.xz
 592d9b38c6dd712f24e8edce66f15cdd821b48bd 23484 arduino-mk_1.2.0-1_all.deb
Checksums-Sha256: 
 a3178eadfddda3fbc9e5c09384a44ea117c49ff0a365151ada8b14d54f476412 1428 
arduino-mk_1.2.0-1.dsc
 0d8ae55d393bfac9907e90418175efb1d9eda6f972a84335afe6cd2b15edfa8e 38800 
arduino-mk_1.2.0.orig.tar.gz
 cb6551ebf655a1bdcd302e0997804c111744856be22a0838614963bdd8090813 2780 
arduino-mk_1.2.0-1.debian.tar.xz
 f885dc4d3542fbf4c6bb1e4341aa85e43939d22b30f9e052c93e836745eab171 23484 
arduino-mk_1.2.0-1_all.deb
Files: 
 02f9974288bb0508708bda9db6b4027f 1428 electronics extra arduino-mk_1.2.0-1.dsc
 70fe344179b6796a59079a6b5b4d3088 38800 electronics extra 
arduino-mk_1.2.0.orig.tar.gz
 f0b874cf2456631a1f4a560606755571 2780 electronics extra 
arduino-mk_1.2.0-1.debian.tar.xz
 ae6e01319ef7b1e3a263d2aa2df31d97 23484 electronics extra 
arduino-mk_1.2.0-1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)

iEYEARECAAYFAlLgdKEACgkQuqVp0MvxKmomtgCdGM/K847ntGOswZ2PAsm09NYb
DrwAnAzkxBvW3Z7i1PF7+M5QiebzjOlp
=9WH1
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to