Your message dated Sun, 16 Feb 2014 22:48:57 +0000
with message-id <[email protected]>
and subject line Bug#723194: fixed in checkstyle 5.7-1
has caused the Debian Bug report #723194,
regarding checkstyle: Some custom configs do not work: Unable to instantiate
DoubleCheckedLocking
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
723194: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=723194
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: checkstyle
Version: 5.6-2
Severity: normal
Tags: patch upstream
Dear Maintainer,
when using checkstyle with some custom configs it fails:
$ checkstyle -c /usr/share/checkstyle/sun_checks.xml File.java
log4j:WARN No appenders could be found for logger
(org.apache.commons.beanutils.converters.BooleanConverter).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more
info.
Unable to create Checker: cannot initialize module TreeWalker - Unable to
instantiate DoubleCheckedLocking
com.puppycrawl.tools.checkstyle.api.CheckstyleException: cannot initialize
module TreeWalker - Unable to instantiate DoubleCheckedLocking
at com.puppycrawl.tools.checkstyle.Checker.setupChild(Checker.java:178)
at
com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure(AutomaticBean.java:184)
at com.puppycrawl.tools.checkstyle.Main.createChecker(Main.java:143)
at com.puppycrawl.tools.checkstyle.Main.main(Main.java:120)
Caused by: com.puppycrawl.tools.checkstyle.api.CheckstyleException: Unable to
instantiate DoubleCheckedLocking
at
com.puppycrawl.tools.checkstyle.PackageObjectFactory.createModule(PackageObjectFactory.java:155)
at
com.puppycrawl.tools.checkstyle.TreeWalker.setupChild(TreeWalker.java:161)
at
com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure(AutomaticBean.java:184)
at com.puppycrawl.tools.checkstyle.Checker.setupChild(Checker.java:157)
... 3 more
Caused by: com.puppycrawl.tools.checkstyle.api.CheckstyleException: Unable to
instantiate DoubleCheckedLockingCheck
at
com.puppycrawl.tools.checkstyle.PackageObjectFactory.doMakeObject(PackageObjectFactory.java:98)
at
com.puppycrawl.tools.checkstyle.PackageObjectFactory.createModule(PackageObjectFactory.java:152)
... 6 more
This is because the custom config file contains a reference to the
DoubleCheckedLocking module, but this feature has been removed in 5.6:
http://checkstyle.sourceforge.net/releasenotes.html
This is the upstream report, to which I already forwarded the patch:
https://sourceforge.net/p/checkstyle/bugs/705/
Regards,
Antonio Ospite
http://ao2.it
-- System Information:
Debian Release: jessie/sid
APT prefers unstable
APT policy: (900, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.11.0-ao2 (SMP w/1 CPU core)
Locale: LANG=it_IT.utf8, LC_CTYPE=it_IT.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages checkstyle depends on:
ii antlr 2.7.7+dfsg-5
ii default-jre-headless [java7-runtime-headless] 1:1.7-49
ii java-wrappers 0.1.26
ii libcommons-beanutils-java 1.8.3-4
ii libcommons-cli-java 1.2-3
ii libcommons-logging-java 1.1.3-1
ii libguava-java 15.0-1
ii openjdk-7-jre-headless [java7-runtime-headless] 7u25-2.3.12-4
checkstyle recommends no packages.
Versions of packages checkstyle suggests:
ii ant-optional 1.9.2-1
ii junit4 4.11-2
-- no debconf information
# HG changeset patch
# User Antonio Ospite <[email protected]>
# Date 1379407878 -7200
# Tue Sep 17 10:51:18 2013 +0200
# Node ID 7d291436f3ab835b059363afa117cc58cd5ff52f
# Parent e4b66ee974eac4b1e31ad6010b350d8f2c2d511f
Remove references to DoubleCheckedLocking, the module has been removed in 5.6
diff -r e4b66ee974ea -r 7d291436f3ab contrib/examples/checks/all-checkstyle-checks.xml
--- a/contrib/examples/checks/all-checkstyle-checks.xml Fri Aug 30 16:32:31 2013 +1000
+++ b/contrib/examples/checks/all-checkstyle-checks.xml Tue Sep 17 10:51:18 2013 +0200
@@ -333,10 +333,6 @@
<!-- See http://checkstyle.sf.net/config_coding.html !-->
<module name="DefaultComesLast"/>
- <!-- The "double-checked locking" idiom (DCL) tries to avoid the runtime cost of synchronization. !-->
- <!-- See http://checkstyle.sf.net/config_coding.html !-->
- <module name="DoubleCheckedLocking"/>
-
<!-- Detects empty statements (standalone ;). !-->
<!-- See http://checkstyle.sf.net/config_coding.html !-->
<module name="EmptyStatement"/>
diff -r e4b66ee974ea -r 7d291436f3ab contrib/examples/conf/template_config.xml
--- a/contrib/examples/conf/template_config.xml Fri Aug 30 16:32:31 2013 +1000
+++ b/contrib/examples/conf/template_config.xml Tue Sep 17 10:51:18 2013 +0200
@@ -390,12 +390,6 @@
</module>
<!-- See http://checkstyle.sf.net/config_coding.html -->
- <!-- The "double-checked locking" idiom (DCL) tries to avoid the runtime
- cost of synchronization. -->
- <module name="DoubleCheckedLocking">
- </module>
-
- <!-- See http://checkstyle.sf.net/config_coding.html -->
<!-- Detects empty statements (standalone ;). -->
<module name="EmptyStatement">
</module>
diff -r e4b66ee974ea -r 7d291436f3ab sun_checks.xml
--- a/sun_checks.xml Fri Aug 30 16:32:31 2013 +1000
+++ b/sun_checks.xml Tue Sep 17 10:51:18 2013 +0200
@@ -145,7 +145,6 @@
<!-- Checks for common coding problems -->
<!-- See http://checkstyle.sf.net/config_coding.html -->
<module name="AvoidInlineConditionals"/>
- <module name="DoubleCheckedLocking"/> <!-- MY FAVOURITE -->
<module name="EmptyStatement"/>
<module name="EqualsHashCode"/>
<module name="HiddenField"/>
--- End Message ---
--- Begin Message ---
Source: checkstyle
Source-Version: 5.7-1
We believe that the bug you reported is fixed in the latest version of
checkstyle, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Emmanuel Bourg <[email protected]> (supplier of updated checkstyle package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Sun, 16 Feb 2014 18:50:32 +0100
Source: checkstyle
Binary: checkstyle checkstyle-doc
Architecture: source all
Version: 5.7-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Java Maintainers
<[email protected]>
Changed-By: Emmanuel Bourg <[email protected]>
Description:
checkstyle - checks Java source against a coding standard
checkstyle-doc - Documentation for Checkstyle
Closes: 723194
Changes:
checkstyle (5.7-1) unstable; urgency=medium
.
* New upstream release (Closes: #723194)
* Refreshed the patches
* Switch to debhelper level 9
* Standards-Version updated to 3.9.5 (no changes)
Checksums-Sha1:
7313452ca3c53a6e8b75f99acc51c8b8da41838f 2362 checkstyle_5.7-1.dsc
ec7f011f3662b2e9a5864d5363eccf544c609b96 749316 checkstyle_5.7.orig.tar.gz
f619edc5793f5935e91a4530664112ef6a96d362 7984 checkstyle_5.7-1.debian.tar.xz
49eb20c6a33af24f6c63f96da67454915f2ffacb 589346 checkstyle_5.7-1_all.deb
0566db2af50fc9dcd829f7a838f9d5db3ad0992e 392468 checkstyle-doc_5.7-1_all.deb
Checksums-Sha256:
b84b5ac6176bae537b1ed86b57cc86438d442e0931ab44b8836c6170b338adf5 2362
checkstyle_5.7-1.dsc
0823eee66ac7f69b653d72df5d56459f58a7f29baa8b540ecf00e8cc54a578c2 749316
checkstyle_5.7.orig.tar.gz
aa324f554991fef7d823485f84cc0081730f66aec633459a782874dc9f20e23b 7984
checkstyle_5.7-1.debian.tar.xz
ba51798199e1e6382776f4e350cc89e421e0c321bbaa20e3ed9fe430b3c1f853 589346
checkstyle_5.7-1_all.deb
c02ecb0e1a5708ab527b161eb98c06e754f47b630f384cef754a66df3f9d1f12 392468
checkstyle-doc_5.7-1_all.deb
Files:
461195aade94b9178fd0709b83070d05 2362 java optional checkstyle_5.7-1.dsc
076314bd9bf08812b1f0ff0af913dee9 749316 java optional
checkstyle_5.7.orig.tar.gz
f1437353b64c207da464e3b2249a7299 7984 java optional
checkstyle_5.7-1.debian.tar.xz
48cc56141fecffffb9c688a696688520 589346 java optional checkstyle_5.7-1_all.deb
0729f1db435c42ad538edb9a02c41e58 392468 doc optional
checkstyle-doc_5.7-1_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBAgAGBQJTATw7AAoJEPUTxBnkudCssvEP/2ZH7yxu5QEsUuMJpGqbCBJx
bXQi9jsaDtOplBtrRRWF4wh5NtWIo2xG0x2DoKH/JASVLhkTLTFkJRzY9DRDs/vt
GIJCjMhh4LlB/vLz/E++BOO9Sux1abjeZ0Y5eqTiONUIB9Y7ctxg19Qv8IQvUkhQ
rTC6eaYjtOJlA1/wASrrzuRmSX3Uqqbl3Vn/+UUMkP6hTrvegrZd5+FNqccd2fBj
rWoce3Vg2x0rKERWP73Mk5XY9C9eHmf9M/kMngGYHbBm5XihBSoBDQOMHaQkyMLF
XesS9MaIR1KTH2JJH5dpEFMyzdn7673E9pti22lVOLs27REPtHtYGz/KHv7ASfBG
UCvUpb0Mfi6jROaGuMdlaYVbGGMAN5Ew09TzRfSDXZc7KzpAGioJq60+fr02i/Nq
/jxU5c1OYlDSS7YkswaZ6hD6XoJCwn/7ZdcJQ47P8VlMHF3ZhCt6QbY1073FOFoH
q7WcpsT3bD1U2yQkEK7omG/E4IuGFFpzMWHg+CevweQCmfy2INyT+NrFY1OhPdqR
bFw2O3Fgfc45ew2SduDKk2BZwZ5TlELii8OSoTtXjZYZCH0uFgVxDX0TUqTHvA8e
2nd6wFlirmuz6XZVaYmcEmStRu4WDzxZn0kooX7vXCYzs+ymKHy0oAG1p8N1NkP/
kJX2pACVsjWGx/7Tju/K
=HHvv
-----END PGP SIGNATURE-----
--- End Message ---
