Your message dated Sat, 22 Feb 2014 05:33:26 +0000
with message-id <[email protected]>
and subject line Bug#696286: fixed in ini4j 0.5.2-SNAPSHOT-3
has caused the Debian Bug report #696286,
regarding unnecessary dependencies in package, strange files in jar
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
696286: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=696286
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: ini4j
Version: 0.5.2-SNAPSHOT-2
Severity: minor
Tags: patch

The package ini4j has unnecessary dependencies: libjetty-java and
libservlet2.5-java. It recommends jetty and thereby installs a complete
servlet engine for an Ini-Parser.  These libraries are not used by the
package, in fact it compiles and runs just fine without them.

Also, the jar includes some strange files: 

site/apt/design.apt
site/apt/overview.apt
site/resources/.htaccess
site/resources/css/site.css
site/resources/favicon.ico
site/resources/img/bugs.png
site/resources/img/community.png
site/resources/img/docs.png
site/resources/img/download.png
site/resources/img/feature.png
site/resources/img/fedora.png
site/resources/img/forum.png
site/resources/img/ini4j-banner.png
site/resources/img/ini4j.png
site/resources/img/sample.png
site/resources/img/tutorial.png
site/resources/img/ubuntu.png
site/resources/img/writer.png
site/resources/robots.txt
test/java/org/ini4j/demo/help.txt
test/java/org/ini4j/demo/ini-data.txt
test/java/org/ini4j/demo/ini-tip.txt
test/java/org/ini4j/demo/options-data.txt
test/java/org/ini4j/demo/options-tip.txt
test/java/org/ini4j/demo/reg-data.txt
test/java/org/ini4j/demo/reg-tip.txt
test/java/org/ini4j/sample/dwarfs.opt
test/java/org/ini4j/sample/dwarfs.reg
test/java/org/ini4j/sample/package-info.class
test/java/org/ini4j/tutorial/package-info.class
test/resources/org/ini4j/mozilla.reg
test/resources/org/ini4j/spi/include.txt
test/resources/org/ini4j/spi/nested.txt
test/resources/org/ini4j/spi/part1.txt
test/resources/org/ini4j/spi/part2.txt

These seem to be part of the website, but these should not be in the jar
containing the java-classes.

The attached patch modifies the package so these issues are addressed.
All unit tests included in the package passing before modification still
pass afterwards.

I've left the build-dependencies for testing the package alone although
they are not needed since no tests are run during build.

-- 
+++ I am sorry. It is hard to convey five-dimensional ideas in a language
    evolved to scream defiance at the monkeys in the next tree +++
[Terry Pratchett - The Science of the Discworld 3]
diff -r -u ini4j-original//debian/build.xml ini4j-0.5.2-SNAPSHOT//debian/build.xml
--- ini4j-original//debian/build.xml	2012-12-18 20:45:41.000000000 +0100
+++ ini4j-0.5.2-SNAPSHOT//debian/build.xml	2012-12-18 23:08:35.000000000 +0100
@@ -10,7 +10,7 @@
   <property name="build.app.name" value="ini4j-${artifactVersion}"/>
   <!-- directory locations -->
   <property name="build.dst" value="${basedir}/build"/>
-  <property name="build.src" value="${basedir}/src/"/>
+  <property name="build.src" value="${basedir}/src/main/java/"/>
   <property name="build.dist" value="${basedir}/dist"/>
 
   <property name="build.dst.classes" value="${build.dst}/classes"/>
@@ -37,10 +37,8 @@
     <path id="build.classpath">
         <pathelement location="${build.dst.classes}"/>
         <pathelement path="${java.class.path}"/>                
-        <pathelement location="${build.servlet.jar}"/>
-        <pathelement location="${build.jetty.jar}"/>
     </path>
-
+	
     <mkdir dir="${build.dst}"/>
     <mkdir dir="${build.dist}"/>
     <mkdir dir="${build.dst.doc}"/>
@@ -51,7 +49,6 @@
     <mkdir dir="${build.dst.classes}"/>
 
     <javac
-        classpathref="build.classpath"
         debug="${build.compile.debug}"
         deprecation="${build.compile.deprecation}"
         optimize="${build.compile.optimize}"
diff -r -u ini4j-original//debian/control ini4j-0.5.2-SNAPSHOT//debian/control
--- ini4j-original//debian/control	2012-12-18 20:45:41.000000000 +0100
+++ ini4j-0.5.2-SNAPSHOT//debian/control	2012-12-18 21:06:30.000000000 +0100
@@ -5,7 +5,7 @@
 Uploaders: Marek Slama <[email protected]>,
  Andres Mejia <[email protected]>
 Build-Depends: debhelper (>= 7.0.50~), javahelper, ant, ant-optional,
- default-jdk, libjetty-java, libservlet2.5-java, junit4, bsh, libeasymock-java
+ default-jdk, junit4, bsh, libeasymock-java
 Standards-Version: 3.9.3
 Homepage: http://www.ini4j.org/
 Vcs-Browser: http://git.debian.org/?p=pkg-java/ini4j.git
Nur in ini4j-0.5.2-SNAPSHOT//debian: patches.
diff -r -u ini4j-original//debian/rules ini4j-0.5.2-SNAPSHOT//debian/rules
--- ini4j-original//debian/rules	2012-12-18 20:45:41.000000000 +0100
+++ ini4j-0.5.2-SNAPSHOT//debian/rules	2012-12-18 22:48:14.000000000 +0100
@@ -2,19 +2,11 @@
 
 DEB_ANT_BUILDFILE = ./debian/build.xml
 DEB_ANT_BUILD_TARGET = build javadoc
-DEB_ANT_ARGS = -Dbuild.sysclasspath=first \
-	-Dbuild.servlet.jar=/usr/share/java/servlet-api-2.5.jar
+DEB_ANT_ARGS = -Dbuild.sysclasspath=first 
 VERSION = $(shell dpkg-parsechangelog | grep ^Version: | cut -f2 -d' ' \
 	| sed -r 's/^(.*)-.*$$/\1/')
 
-JARS = /usr/share/java/jetty.jar
-JARS := $(JARS):/usr/share/java/servlet-api-2.5.jar
-JARS := $(JARS):/usr/share/java/servlet-api.jar
-JARS := $(JARS):/usr/share/java/junit4.jar
-JARS := $(JARS):/usr/share/java/bsh.jar
-JARS := $(JARS):/usr/share/java/easymock.jar
 
-export CLASSPATH=$(JARS)
 export JAVA_HOME=/usr/lib/jvm/default-java
 
 %:

Attachment: signature.asc
Description: Digital signature


--- End Message ---
--- Begin Message ---
Source: ini4j
Source-Version: 0.5.2-SNAPSHOT-3

We believe that the bug you reported is fixed in the latest version of
ini4j, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Emmanuel Bourg <[email protected]> (supplier of updated ini4j package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 21 Feb 2014 14:36:58 +0100
Source: ini4j
Binary: libini4j-java libini4j-java-doc
Architecture: source all
Version: 0.5.2-SNAPSHOT-3
Distribution: unstable
Urgency: medium
Maintainer: Debian Java Maintainers 
<[email protected]>
Changed-By: Emmanuel Bourg <[email protected]>
Description: 
 libini4j-java - Java API for handling Windows ini file format (library)
 libini4j-java-doc - Java API for handling Windows ini file format 
(documentation)
Closes: 656368 696286
Changes: 
 ini4j (0.5.2-SNAPSHOT-3) unstable; urgency=medium
 .
   * Team upload.
   * Build with maven-debian-helper (Closes: #656368)
   * Removed the unused dependencies (Closes: #696286)
   * Use canonical URLs for the Vcs-* fields
   * Standards-Version updated to 3.9.5 (no changes)
   * Switch to debhelper level 9
   * debian/copyright: Converted to the Copyright Format 1.0
Checksums-Sha1: 
 d3bd340ef3563c2443b94e331922414463faf9d3 2087 ini4j_0.5.2-SNAPSHOT-3.dsc
 9458918ed91ce32514fb2f5220d5bcf4ea0c34b9 4152 
ini4j_0.5.2-SNAPSHOT-3.debian.tar.xz
 37218885399de2f887002b502d19da6abf1da339 94456 
libini4j-java_0.5.2-SNAPSHOT-3_all.deb
 fb99c3d0498a37f3c5fe72b4d4b4b5e394766460 362728 
libini4j-java-doc_0.5.2-SNAPSHOT-3_all.deb
Checksums-Sha256: 
 21b2a048db3fec5ee17db3bc18ba26d7cb1f54fbc5e72e138fdd9daef3439772 2087 
ini4j_0.5.2-SNAPSHOT-3.dsc
 5de8840ee8416c3804e6f5dc7dbaff9bd00a14ac6688966b6285eab65ffaee67 4152 
ini4j_0.5.2-SNAPSHOT-3.debian.tar.xz
 03d13851e069965058496b6df51c0d229a6477036aea1cb9ff88cc1d782e0993 94456 
libini4j-java_0.5.2-SNAPSHOT-3_all.deb
 e1229ee57336df396cb0fe6159966be09e243af0e70f7d4ed51486ef28c44300 362728 
libini4j-java-doc_0.5.2-SNAPSHOT-3_all.deb
Files: 
 72845e105c17e6106d4444e9917f8047 2087 java optional ini4j_0.5.2-SNAPSHOT-3.dsc
 8130bcf980b4ea6ad4bc6e94508f1d4c 4152 java optional 
ini4j_0.5.2-SNAPSHOT-3.debian.tar.xz
 17db3a21489b5cfd21ef3cf5ff195c38 94456 java optional 
libini4j-java_0.5.2-SNAPSHOT-3_all.deb
 94fb86e76b18688487a88f33e127302e 362728 doc optional 
libini4j-java-doc_0.5.2-SNAPSHOT-3_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJTCDRGAAoJECHSBYmXSz6Wk7gP/A4VqQljb7SCYp2sGuHjlgZS
BYyPPOx8WJozB5GL6VxJ8wls4G89T8mdykTyq78Dx3wPdIX9Ju4MXleVrphyAcqa
UukLgnMAHfzjrL7pI6NvjGcaXt7XnSWCOjqkrORUbo81BfcLiIq/qakbdTdVFGzU
AJPZDOciBcOoAB7B/uW7RGh3VKjnUv0lGNCr4bYBVUk13L9j+eQtaIRpWW/3Hy/L
5wm2w5Lkqwh7pZqyjD27piU156UeexCvKL7Irk1jSFanZOlDuO4fxGfXhqHgZmbb
OQH3PqDlQosK7D5qsMnUk0rdD83WmkzapmYYPV4YbVs5nO5NYHS73sWGhjAKLbGX
zDlJBJ3IPHyBH78OsVQO5QjMpvv7I4rATh24EP+Y5FVLyA5Qk27X681RZ8xmUD53
2weHr14bwcqxNPu2U7Q7Xp+FGd+HjuRzlYaM2oLW3LjQys81+Q7q66sjZrQI79xG
ZbFZ1ZkZBrnxKskyNcsC936QCZqH/RaO6pT1b4F2tFAP1bkijA6rDTOw1lJUyaIr
bNoq52dlJx+XeYz7YWlM70BXS1XQqsA9ng575ft0wo5bqGECEK8US9itD+qeOpXT
SDtWENXuiNuPvHm1/jAamScMc1KhThP69oNi7H6J0Okl/cYuBp2ZETW1H57M9ekO
1PQ2M+Cjc1dzEVDtKDDi
=7t7s
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to