Your message dated Tue, 04 Mar 2014 15:41:15 +0000
with message-id <[email protected]>
and subject line Bug#674709: fixed in unsort 1.2.0-1
has caused the Debian Bug report #674709,
regarding unsort: FTBFS on hurd-i386: IOV_MAX not defined
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
674709: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=674709
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: unsort
Version: 1.1.2-1
Severity: important
Tags: patch
User: [email protected]
Usertags: hurd
X-Debbugs-CC: [email protected]
Currently unsort fails to build on hurd-i386 because the symbol
IOV_MAX (the maximum number of items that can be passed to
writev/readv) is not defined. The POSIX standard doesn't guarantee
that IOV_MAX will be defined, rather it states that it should be
omitted if the limit can't be determined at compile time or no fixed
limit exists.[1]
The attached patch uses sysconf(_SC_IOV_MAX) to query the appropriate
limit at runtime rather than relying on IOV_MAX.
[1]
<http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/limits.h.html#tag_13_23_03_01>
diff --git a/iovec.c b/iovec.c
index 8ad94bf..7273c18 100644
--- a/iovec.c
+++ b/iovec.c
@@ -21,6 +21,7 @@
*****************************************************************************/
+#include <errno.h>
#include <stdbool.h>
#include <stdint.h>
#include <inttypes.h>
@@ -41,14 +42,20 @@ struct iovec_const {
size_t iov_len;
};
-static uint32_t writev_max = IOV_MAX;
-
void writev_all(int fd, struct iovec *iov, uint32_t count) {
ssize_t r, len;
+ uint32_t writev_max;
+ long sc_iovmax;
if(!count)
return;
+ errno = 0;
+ if ((sc_iovmax = sysconf(_SC_IOV_MAX)) == -1)
+ writev_max = errno ? _XOPEN_IOV_MAX : count;
+ else
+ writev_max = (uint32_t) sc_iovmax;
+
while(count) {
r = writev(fd, iov, (int)(count > writev_max ? writev_max : count));
if(r == -1)
--- End Message ---
--- Begin Message ---
Source: unsort
Source-Version: 1.2.0-1
We believe that the bug you reported is fixed in the latest version of
unsort, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Guus Sliepen <[email protected]> (supplier of updated unsort package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Tue, 04 Mar 2014 15:05:45 +0100
Source: unsort
Binary: unsort
Architecture: source amd64
Version: 1.2.0-1
Distribution: unstable
Urgency: medium
Maintainer: Guus Sliepen <[email protected]>
Changed-By: Guus Sliepen <[email protected]>
Description:
unsort - reorders lines in a file in semirandom ways
Closes: 674709
Changes:
unsort (1.2.0-1) unstable; urgency=medium
.
* New upstream release.
- Fixes FTBFS on Hurd. Closes: #674709
* Converted source package to 3.0 (quilt) format.
* Added debian/watch file.
Checksums-Sha1:
28c7fd1ef749709baabb3e69d067950a2c207ef1 1104 unsort_1.2.0-1.dsc
be2562a8d85cb0ca2f0ced94a728e13ec0c48f49 82780 unsort_1.2.0.orig.tar.xz
12500cb88083ee1c4bdc8f3f3fea105a5945e11d 1964 unsort_1.2.0-1.debian.tar.xz
f9c77ecfe60c87f86e85e084fa82568675969a1b 18056 unsort_1.2.0-1_amd64.deb
Checksums-Sha256:
cbecc203f0bd5b9c2a4935e6b7c4ac06007e3f2c042801932fd777ef06f339fd 1104
unsort_1.2.0-1.dsc
24cd3f98189005f4326ebc27287a784546244c7447483e2bb2380688c31584f4 82780
unsort_1.2.0.orig.tar.xz
a20f9c4a8426efee1a300e6d60820c8e6ed5d33eb4739cdee711dc525d43f9b5 1964
unsort_1.2.0-1.debian.tar.xz
8519b5889d9511c7fcb9c8270426ed7fc529a3c3c3ec90235d7d68878ae09f38 18056
unsort_1.2.0-1_amd64.deb
Files:
0b44347f831bf1c459080a2aee8cda69 1104 text extra unsort_1.2.0-1.dsc
14f922c4bd751d4e7c09ae83f6e15cd7 82780 text extra unsort_1.2.0.orig.tar.xz
0df51a9b296cca422c3e060d794cecfe 1964 text extra unsort_1.2.0-1.debian.tar.xz
9bb43907aa49117bd67007ab8806f835 18056 text extra unsort_1.2.0-1_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iEYEARECAAYFAlMV3fUACgkQAxLow12M2nsSogCgg3OF1Fudc6Td55adZbmGbR2P
Q6IAn21iHzUNnZZjcb1jkW24iU2Whj8K
=3bK0
-----END PGP SIGNATURE-----
--- End Message ---
