Your message dated Fri, 21 Mar 2014 18:22:57 +0400
with message-id <[email protected]>
and subject line Re: Bug#739530: systemd support for monit
has caused the Debian Bug report #739530,
regarding systemd support for monit
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
739530: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=739530
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: monit
Version: 1:5.6-2
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: systemd-units
X-Debbugs-CC: [email protected]
Hi,
the attached patch adds support for systemd in monit. It uses the
service file provided by upstream.
The dh_installinit line was dropped in this patch, because it is not
needed anymore and only triggers a warning at installation time.
Best regards
Christian
diff -Nru monit-5.6/debian/control monit-5.6/debian/control
--- monit-5.6/debian/control 2014-02-19 01:45:08.000000000 +0100
+++ monit-5.6/debian/control 2014-02-19 19:02:40.000000000 +0100
@@ -2,7 +2,7 @@
Section: admin
Priority: optional
Maintainer: Sergey B Kirpichev <[email protected]>
-Build-Depends: debhelper (>= 9), libssl-dev, libpam-dev, libkvm-dev [kfreebsd-any], autotools-dev
+Build-Depends: debhelper (>= 9), libssl-dev, libpam-dev, libkvm-dev [kfreebsd-any], autotools-dev, dh-systemd
# this strange things was installed only on ia64 buildd:
Build-Conflicts: automake, autoconf
Standards-Version: 3.9.5
diff -Nru monit-5.6/debian/monit.install monit-5.6/debian/monit.install
--- monit-5.6/debian/monit.install 2014-02-19 01:45:08.000000000 +0100
+++ monit-5.6/debian/monit.install 2014-02-19 19:02:40.000000000 +0100
@@ -1,3 +1,4 @@
monitrc etc/monit/
debian/monitrc.d/* etc/monit/monitrc.d/
debian/templates/* etc/monit/templates/
+contrib/monit.service /lib/systemd/system
diff -Nru monit-5.6/debian/rules monit-5.6/debian/rules
--- monit-5.6/debian/rules 2014-02-19 01:45:08.000000000 +0100
+++ monit-5.6/debian/rules 2014-02-19 19:03:15.000000000 +0100
@@ -1,15 +1,12 @@
#!/usr/bin/make -f
%:
- dh $@ --with autotools_dev
+ dh $@ --with autotools_dev,systemd
override_dh_auto_configure:
dh_auto_configure -- \
--sysconfdir=/etc/monit
-override_dh_installinit:
- dh_installinit -- "start 99 2 3 4 5 . stop 01 0 1 6 ."
-
override_dh_fixperms:
dh_fixperms
chmod 600 debian/monit/etc/monit/monitrc
--- End Message ---
--- Begin Message ---
No activity for month. Close.
On Fri, Feb 21, 2014 at 08:09:12PM +0400, Sergey B Kirpichev wrote:
> On Fri, Feb 21, 2014 at 04:49:03PM +0100, Christian Dröge wrote:
> > The patch was created with the current recommendations[0] of the systemd
> > maintainer on how to add systemd support to packages (they looked at the
> > patch before I filed this bug report). I cannot guarantee, that it will
> > not break stuff on hurd/kfreebsd, but I do not think that it will.
>
> I see, it wasn't tested.
>
> > There is currently a difference for /etc/default/monit, because it does
> > not use the variables there. With systemd it is not recommended to
> > disable a service there (START variable), because systemd has its own
> > mechanism ("systemctl enable monit"/"systemctl disable monit"). I could
> > add support for the MONIT_OPTS variable.
>
> You should. And for START as well. I don't care about what systemd
> "recommends", but I do care about upgrade problems. If someone want
> to switch to systemd, while START!=yes - systemd shouldn't start
> the service.
>
> > Currently the trend seems to be to drop the default file
>
> Did I miss something?
>
> > What do you think?
>
> I think, we shouldn't break things for no reason.
>
> And the last question, are you actually use monit?
>
>
--- End Message ---
