Your message dated Mon, 12 May 2014 23:20:30 +0000
with message-id <[email protected]>
and subject line Bug#745104: fixed in x264 2:0.142.2389+git956c8d8-5
has caused the Debian Bug report #745104,
regarding x264 should check the compiler version directly rather than assuming
based on architecture.
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
745104: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=745104
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: x264
Version: 2:0.142.2389+git956c8d8-4
Tags: patch
Version 2:0.142.2389+git956c8d8-2 of the x264 package introduced the use
of the compiler flag -fno-aggressive-loop-optimizations to
fix/workaround a problem (leading to a segfault) when the code was
built with gcc 4.8.
However -fno-aggressive-loop-optimizations doesn't exist in 4.6 or 4.7
this lead to build failures on sparc and sh4. It will also lead to build
failures for anyone who tries to backport the unstable x264 packages to
stable.
The sparc build failure was fixed in 2:0.142.2389+git956c8d8-4 by
special casing the sparc architecture to not pass the flag but I belive
this was a bad soloution for two reasons.
1: it doesn't fix the build failure for sh4, backporters or anyone else
who might run into it
2: afaict the issue worked arround by -fno-aggressive-loop-optimizations
is not architecture specific, so if/when sparc switches it's default
compiler to 4.8 you will want -fno-aggressive-loop-optimizations on sparc.
It makes far more sense IMO to just check the compiler version and act
accordingly. Patch to do that is attatched.
diff -Nru x264-0.142.2389+git956c8d8/debian/changelog
x264-0.142.2389+git956c8d8/debian/changelog
--- x264-0.142.2389+git956c8d8/debian/changelog 2014-04-05 21:46:49.000000000
+0000
+++ x264-0.142.2389+git956c8d8/debian/changelog 2014-04-17 23:58:45.000000000
+0000
@@ -1,3 +1,11 @@
+x264 (2:0.142.2389+git956c8d8-4.1) UNRELEASED; urgency=medium
+
+ * Check gcc version directly to determine whether or not
+ -fno-aggressive-loop-optimizations should be set rather than assuming based
+ on architecture.
+
+ -- Peter Michael Green <[email protected]> Thu, 17 Apr 2014 23:49:00 +0000
+
x264 (2:0.142.2389+git956c8d8-4) unstable; urgency=low
* Do not set -fno-aggressive-loop-optimizations on sparc, which was
diff -Nru x264-0.142.2389+git956c8d8/debian/confflags
x264-0.142.2389+git956c8d8/debian/confflags
--- x264-0.142.2389+git956c8d8/debian/confflags 2014-04-05 21:45:43.000000000
+0000
+++ x264-0.142.2389+git956c8d8/debian/confflags 2014-04-18 00:07:12.000000000
+0000
@@ -111,9 +111,11 @@
endif
endif
-# See Bug#743713, the debian sparc port is currently stuck with gcc 4.6
-# -fno-aggressive-loop-optimizations was introduced only in gcc 4.8
-ifneq (sparc,$(DEB_HOST_GNU_CPU))
+# See Bug#743713, the debian sparc and sh4 ports are currently stuck with.
+# gcc 4.6 -fno-aggressive-loop-optimizations was introduced only in gcc 4.8
+# this conditional will also help any backporters.
+HAVEGCC4.8 :=$(shell dpkg --compare-versions `gcc --version | grep ^gcc | sed
's/^.* //g'` ge 4.8 && echo yes || echo no)
+ifeq (yes,$(HAVEGCC4.8))
common_confflags += --extra-cflags=-fno-aggressive-loop-optimizations
endif
--- End Message ---
--- Begin Message ---
Source: x264
Source-Version: 2:0.142.2389+git956c8d8-5
We believe that the bug you reported is fixed in the latest version of
x264, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Reinhard Tartler <[email protected]> (supplier of updated x264 package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Mon, 12 May 2014 18:52:02 -0400
Source: x264
Binary: x264 libx264-142 libx264-dev
Architecture: source amd64
Version: 2:0.142.2389+git956c8d8-5
Distribution: unstable
Urgency: medium
Maintainer: Reinhard Tartler <[email protected]>
Changed-By: Reinhard Tartler <[email protected]>
Description:
libx264-142 - x264 video coding library
libx264-dev - development files for libx264
x264 - video encoder for the H.264/MPEG-4 AVC standard
Closes: 745104
Changes:
x264 (2:0.142.2389+git956c8d8-5) unstable; urgency=medium
.
[ Peter Michael Green ]
* Check gcc version directly to determine whether or not
-fno-aggressive-loop-optimizations should be set rather than assuming based
on architecture. Closes: #745104
.
[ Reinhard Tartler ]
* Recompile against libav10
* Link dynamically against libgpac
Checksums-Sha1:
0510ecb7cebbb790f16a896e64766341b21ed823 2180 x264_0.142.2389+git956c8d8-5.dsc
0abb77cf403f1755c10154417386a4fb3b2bce94 21240
x264_0.142.2389+git956c8d8-5.debian.tar.xz
0965adaebbe272be8a836e5ce5d5d0e61acfbabc 81904
x264_0.142.2389+git956c8d8-5_amd64.deb
94279323b1802f3faef24ce3433fe2c6e6c7879b 580882
libx264-142_0.142.2389+git956c8d8-5_amd64.deb
b8a7dd6bb24ad2bc17cc882d64e9945a4b67d39b 439676
libx264-dev_0.142.2389+git956c8d8-5_amd64.deb
Checksums-Sha256:
692cd9052eb2dbf125a588c9ff7c6f1ad1fd73b4f7b94975852a87a2f5c9e84f 2180
x264_0.142.2389+git956c8d8-5.dsc
718a2dfc599a9aa75fda88ad70292379e0856a9a76cab3ab174bc73b845da961 21240
x264_0.142.2389+git956c8d8-5.debian.tar.xz
f2540c3720756909e724c6a1d3c284e7f8c9287bd446d877ace8b3d5f83b030f 81904
x264_0.142.2389+git956c8d8-5_amd64.deb
a674745e648fdffb8031223232cdfd1ce41c1247ba799eb89ce71ef215d1b8d6 580882
libx264-142_0.142.2389+git956c8d8-5_amd64.deb
e4a3bb62a996485fade359e3d46dfcd948185976077be6d5804c7ecd911b4f68 439676
libx264-dev_0.142.2389+git956c8d8-5_amd64.deb
Files:
c016d9250b2e21dda7153ed956692170 81904 graphics optional
x264_0.142.2389+git956c8d8-5_amd64.deb
7bf45a88f1f5b602f86ac40dcac159b0 580882 libs optional
libx264-142_0.142.2389+git956c8d8-5_amd64.deb
b4ae1fae3242530ddf12f41e1d7437c0 439676 libdevel optional
libx264-dev_0.142.2389+git956c8d8-5_amd64.deb
c239b2170efca31533e3349feb960729 2180 libs optional
x264_0.142.2389+git956c8d8-5.dsc
17026ab28cd731b2c9d03bcb853207b6 21240 libs optional
x264_0.142.2389+git956c8d8-5.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQGcBAEBCAAGBQJTcVQKAAoJEIuAbIZKeKRF2i0L/R/cT9xAiqjTd1RPQ6QvFgcy
TnqTmrpgmVZfSe7roAzdiVa9UFVdhx0v+kVESEqKPCatlpmX1UqIJzfibwFyJzTX
p25ZFQeMCzjgFDEqdyGKRjFvNW4+XE6PFgSk8aoUQob2Bz0hTubu0e2F5+CYSeYM
LvmPHkXHTjHuIy908nEC5/54IkJHG80Ge8iTv3Y5N0VtHkMod7eH+ppcb8UTgA5z
QrR3OuJwdbS37KaZL0GGnrvtbxEwTVrt8j/jFh6EZPW9Hp7PdVA2j2S1SK0bwzoH
Vb9bf5BYfXRKRoQMGjSJzSTVgkVNjtUqErNKo1q4pOd2bGA70QpLxaEZQAEQHDyH
iHRulbh6cmm3GuBasQXG0K84oRRFUAEZhbngHq7xTrtBqZeFrGzRd/yUCka5Jfj9
PivPM8DZghcI8YfyyhOvCdJ6etfMkmTAwOJela3ILTE3OFK1x+cyeOfeFRehfhIA
7MS6n4+LWOX1f/3MI8ZVU/qA4Xd9egw18HqNiKLHTQ==
=eLd6
-----END PGP SIGNATURE-----
--- End Message ---
