Your message dated Sun, 18 May 2014 09:40:55 +0000
with message-id <[email protected]>
and subject line Bug#678713: fixed in pmount 0.9.23-3
has caused the Debian Bug report #678713,
regarding pmount: pumount tab completion doesn't support mounted paths
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
678713: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=678713
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: pmount
Version: 0.9.23-2
Severity: normal
Tags: patch

After a device is pmounted, pumount supports unmounting both by device
path, and my mounted path, i.e.
pumount /dev/sdb1
or
pumount /media/disk

But tab completion only supports the former option. It would be nice if
tab completion supported the latter as well.

This modification to debian/completion/pmount makes completion by the latter 
path work as well for me:

87c87
<       devices="$( grep $mdir /proc/mounts | sed -e 's,.*/$mdir/,,;s,\ 
.*,,;s,\(.*\),\1\n/dev/\1,;s,/dev//dev,/dev,' )"
---
>       devices="$( grep $mdir /proc/mounts | sed -e 's,.*/$mdir/,,;s,\ 
> .*,,;s,\(.*\),\1\n/dev/\1,;s,/dev//dev,/dev,';grep $mdir /proc/mounts | sed 
> -e 's,.*\($mdir/[^ ]*\).*,\1,' )"

-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 3.1.0-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages pmount depends on:
ii  libblkid1  2.20.1-5
ii  libc6      2.13-33

pmount recommends no packages.

Versions of packages pmount suggests:
pn  cryptsetup  <none>

-- Configuration Files:
/etc/bash_completion.d/pmount changed:
have pmount &&
_pmount() {
   local cur prev options devices fslist
   options=' -r --read-only -w --read-write -s --sync -A --noatime -e --exec \
   -t filesystem --type filesystem -c charset --charset charset -u umask \
   --umask umask --dmask dmask --fmask fmask -p file --passphrase file \
   -h --help -d --debug -V --version'
   fslist=' ascii cp1250 cp1251 cp1255 cp437 cp737 cp775 cp850 cp852 cp855 
cp857 cp860 cp861 cp862 cp863 cp864 cp865 cp866 cp869 cp874 cp932 cp936 cp949 
cp950 euc-jp iso8859-1 iso8859-13 iso8859-14 iso8859-15 iso8859-2 iso8859-3 
iso8859-4 iso8859-5 iso8859-6 iso8859-7 iso8859-9 koi8-r koi8-ru koi8-u utf8'
   COMPREPLY=()
   cur=${COMP_WORDS[COMP_CWORD]}
   prev=${COMP_WORDS[COMP_CWORD-1]}
   case "$prev" in
      -@(t|-type))
      COMPREPLY=( $( grep "^[[:space:]]$cur" /proc/filesystems ) )
      return 0
      ;;
      -@(c|-charset))
      COMPREPLY=( $( compgen -W "$fslist" -- $cur ) )
      return 0
      ;;
      -@(u|d|-umask|-dmask))
      COMPREPLY=( ${cur}0 ${cur}1 ${cur}2 ${cur}3 ${cur}4 ${cur}5 ${cur}6 
${cur}7 )
      return 0
      ;;
      -@(p|-passphrase))
      _filedir
      return 0
      ;;
   esac
        if [[ "$cur" == -* ]]; then
                COMPREPLY=( $( compgen -W "$options" -- $cur ) )
        else
    devices="$( command ls $(grep -v '^[[:space:]]*#' /etc/pmount.allow ) 
$(grep 1 /sys/block/*/removable | sed -e 
's,/sys/block/,/dev/,;s,/removable:1,*,') 2>/dev/null | sort -u | sed -e 
's,\(^/dev/\)\(.*\),\1\2 \2,' )"
                COMPREPLY=( $( compgen -W "$devices" -- $cur ) )
        fi
        return 0
}
have pumount &&
_pumount() {
   local cur prev options devices mdir
   mdir="$(readlink -f /media)"
   options=' -l --luks-force -h --help -d --debug --version'
   COMPREPLY=()
   cur=${COMP_WORDS[COMP_CWORD]}
   prev=${COMP_WORDS[COMP_CWORD-1]}
   if [[ "$cur" == -* ]]; then
      COMPREPLY=( $( compgen -W "$options" -- $cur ) )
   else
      devices="$( grep $mdir /proc/mounts | sed -e 's,.*/$mdir/,,;s,\ 
.*,,;s,\(.*\),\1\n/dev/\1,;s,/dev//dev,/dev,';grep $mdir /proc/mounts | sed -e 
's,.*\($mdir/[^ ]*\).*,\1,' )"
      COMPREPLY=( $( compgen -W "$devices" -- $cur ) )
   fi
   return 0
}
[ "$have" ] && complete -F _pmount $filenames pmount
[ "$have" ] && complete -F _pumount $filenames pumount


-- no debconf information



--- End Message ---
--- Begin Message ---
Source: pmount
Source-Version: 0.9.23-3

We believe that the bug you reported is fixed in the latest version of
pmount, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Vincent Fourmond <[email protected]> (supplier of updated pmount package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sun, 18 May 2014 10:03:13 +0200
Source: pmount
Binary: pmount
Architecture: source amd64
Version: 0.9.23-3
Distribution: unstable
Urgency: low
Maintainer: Vincent Fourmond <[email protected]>
Changed-By: Vincent Fourmond <[email protected]>
Description: 
 pmount     - mount removable devices as normal user
Closes: 664501 678713 727943 744493
Changes: 
 pmount (0.9.23-3) unstable; urgency=low
 .
   * Use dh-autoreconf at build time (closes: #727943, #744493)
   * Conforms to standards 3.9.5
   * Use dh compatibility level of 9 to enable hardened builds (closes:
     #664501)
   * Add bash completion for mounted paths in pumount (closes: #678713) .
     Thanks to Aaron Small <[email protected]> for the patch.
Checksums-Sha1: 
 a165a6de3cb723477bf3c0d9322564e7ad4833dd 1189 pmount_0.9.23-3.dsc
 a4fe3b4104e0271cf7295dd7bf04563564c2f338 10364 pmount_0.9.23-3.debian.tar.xz
 d48616049e318f7f1b6f9569d03c98c7fcb7cbae 84164 pmount_0.9.23-3_amd64.deb
Checksums-Sha256: 
 ff1e5045ed5eb5d11c6d728870469e7dfaf1ce72fb15ce931bb82771c8be3186 1189 
pmount_0.9.23-3.dsc
 8ed8ffbada32aa208cdc16e863f6224fdc6e2742877de19d688fe7ef304abfbf 10364 
pmount_0.9.23-3.debian.tar.xz
 32616960f74c3364222566b9782a188defb94c16ff9a4f268c167d42e2ef6e9e 84164 
pmount_0.9.23-3_amd64.deb
Files: 
 454fd9311c599e8fcab7f5bfada9f7a1 84164 utils optional pmount_0.9.23-3_amd64.deb
 b4bece0cb4dead9a8440dd85ce8216d7 1189 utils optional pmount_0.9.23-3.dsc
 c3ba6024f4ff3f37265797a426efa2cf 10364 utils optional 
pmount_0.9.23-3.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEUEARECAAYFAlN4bSAACgkQx/UhwSKygsqQGACVF0rVDK6nhLMXO6yMEmt5VHtx
vgCeJasR8pUIB3TGBP+gxiXONs5ACcM=
=4r9B
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to