Your message dated Tue, 27 May 2014 01:12:50 +0100
with message-id <[email protected]>
and subject line Re: Bug#749200: kstart: tests: Inconsistent use of config.h
causing conflicting types
has caused the Debian Bug report #749200,
regarding kstart: tests: Inconsistent use of config.h causing conflicting types
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
749200: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=749200
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: kstart
Version: 4.1-3
Severity: minor
Usertags: goto-cc
During a rebuild of all packages in a clean sid chroot (and cowbuilder+pbuilder)
the build failed with the following error. Please note that we use our research
compiler tool-chain (using tools from the cbmc package), which permits extended
reporting on type inconsistencies at link time.
[...]
gcc -g -O2 -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wformat
-Werror=format-security -fPIE -pie -Wl,-z,relro -Wl,-z,now -o
tests/kafs/haspag-t tests/kafs/tests_kafs_haspag_t-haspag-t.o kafs/libkafs.a
tests/tap/libtap.a portable/libportable.a
error: conflicting function declarations "fstat"
old definition in module kafs file /usr/include/x86_64-linux-gnu/sys/stat.h
line 467
signed int (signed int __fd, struct stat *__statbuf)
new definition in module basic file /usr/include/x86_64-linux-gnu/sys/stat.h
line 467
signed int (signed int __fd, struct stat *__statbuf)
reason for conflict at __statbuf in types listed below (struct/struct):
composite type component counts differ (15/18)
struct stat {
unsigned long int st_dev;
unsigned long int st_ino;
unsigned long int st_nlink;
unsigned int st_mode;
unsigned int st_uid;
unsigned int st_gid;
signed int __pad0;
unsigned long int st_rdev;
signed long int st_size;
signed long int st_blksize;
signed long int st_blocks;
struct timespec st_atim;
struct timespec st_mtim;
struct timespec st_ctim;
signed long int [3l] __unused;
}
struct stat {
unsigned long int st_dev;
unsigned long int st_ino;
unsigned long int st_nlink;
unsigned int st_mode;
unsigned int st_uid;
unsigned int st_gid;
signed int __pad0;
unsigned long int st_rdev;
signed long int st_size;
signed long int st_blksize;
signed long int st_blocks;
signed long int st_atime;
unsigned long int st_atimensec;
signed long int st_mtime;
unsigned long int st_mtimensec;
signed long int st_ctime;
unsigned long int st_ctimensec;
signed long int [3l] __unused;
}
Makefile:891: recipe for target 'tests/kafs/haspag-t' failed
make[2]: *** [tests/kafs/haspag-t] Error 64
make[2]: Leaving directory
'/srv/jenkins-slave/workspace/sid-goto-cc-kstart/kstart-4.1'
Makefile:1529: recipe for target 'check-am' failed
make[1]: *** [check-am] Error 2
This type conflict is caused by the use of _XOPEN_SOURCE rather than using
#include <config.h>, which would define _GNU_SOURCE, in tests/tap/basic.c:
http://sources.debian.net/src/kstart/4.1-3/tests/tap/basic.c?hl=39#L39
Compare to tests/kafs/basic.c:
http://sources.debian.net/src/kstart/4.1-3/tests/kafs/basic.c
Using #include <config.h> consistently as first include will ensure this kind of
inconsistency.
Best,
Michael
pgpmR_laC_1Xi.pgp
Description: PGP signature
--- End Message ---
--- Begin Message ---
Closing this bug report as ...
> Michael Tautschnig <[email protected]> writes:
>
> > The reason the tool was lead to believe that stat was being used is due
> > to an incomplete treatment of extern inline. This will be fixed and I
> > will close the bug report as soon as I have confirmed the fix on my end.
>
> Ah, excellent, thanks!
>
[...]
... the tool is now fixed and fully build kstart now without any (false) error
reports.
Thanks a lot for the detailed feedback as this really helped spot the error in
the tool.
Best,
Michael
pgpirsUeGe_FB.pgp
Description: PGP signature
--- End Message ---
