Your message dated Sun, 01 Jun 2014 09:37:22 +0000
with message-id <[email protected]>
and subject line Bug#749913: fixed in ipmitool 1.8.14-2
has caused the Debian Bug report #749913,
regarding ipmitool: Conflicting declarations of function write_fru_area to 
cause undefined behaviour
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
749913: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=749913
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: ipmitool
Version: 1.8.14-1
Usertags: goto-cc

During a rebuild of all Debian packages in a clean sid chroot (using cowbuilder
and pbuilder) the build failed with the following error. Please note that we
use our research compiler tool-chain (using tools from the cbmc package), which
permits extended reporting on type inconsistencies at link time.

[...]
/bin/bash ../libtool --silent --tag=CC   --mode=link gcc  -Wall -g -O2 
-fno-strict-aliasing -Wreturn-type -I /lib/modules/3.2.0-4-amd64/build/include  
-Wl,-z,relro -o ipmitool ipmitool.o ipmishell.o ../lib/libipmitool.la 
plugins/libintf.la -lreadline -lncurses -ltinfo -lreadline -lncurses -ltinfo  
-lcrypto

error: conflicting function declarations "write_fru_area"
old definition in module ipmi_fru file ipmi_fru.c line 424
signed int (struct ipmi_intf *intf, struct fru_info *fru, unsigned char id, 
unsigned short int soffset, unsigned short int doffset, unsigned short int 
length, unsigned char *pFrubuf)
new definition in module ipmi_kontronoem file ipmi_kontronoem.c line 55
signed int (struct ipmi_intf *, struct fru_info *, unsigned char, unsigned int, 
unsigned int, unsigned int, unsigned char *)
Makefile:422: recipe for target 'ipmitool' failed
make[4]: *** [ipmitool] Error 64
make[4]: Leaving directory 
'/srv/jenkins-slave/workspace/sid-goto-cc-ipmitool/ipmitool-1.8.14/src'
Makefile:469: recipe for target 'all-recursive' failed
make[3]: *** [all-recursive] Error 1

Observe the differences on the fourth, fifth, sixth parameter (soffset, doffset,
length): for any platform with sizeof(short)<sizeof(int), this will result in
undefined behaviour in at least one of two ways: the value is truncated in some
way; yet even if the value fits into the smaller type, big endian systems with
pick the wrong bytes.

All it takes is amending the declaration here:

http://sources.debian.net/src/ipmitool/1.8.14-1/lib/ipmi_kontronoem.c?hl=55#L55

Best,
Michael

Attachment: pgpKLtGP8xsLD.pgp
Description: PGP signature


--- End Message ---
--- Begin Message ---
Source: ipmitool
Source-Version: 1.8.14-2

We believe that the bug you reported is fixed in the latest version of
ipmitool, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jörg Frings-Fürst <[email protected]> (supplier of updated ipmitool 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 27 May 2014 14:53:55 +0200
Source: ipmitool
Binary: ipmitool
Architecture: source amd64
Version: 1.8.14-2
Distribution: unstable
Urgency: medium
Maintainer: Jörg Frings-Fürst <[email protected]>
Changed-By: Jörg Frings-Fürst <[email protected]>
Description: 
 ipmitool   - utility for IPMI control with kernel driver or LAN interface
Closes: 749913 750003
Changes: 
 ipmitool (1.8.14-2) unstable; urgency=medium
 .
   * patch 115-lib_declarations.patch
      - lib/kontronoem.c
        correct declaration of write_fru_area ( Closes: #749913 )
   * remove hardening-wrapper from build-Depends
   * add ipmi* kernel-modules to startup-script
      ( LP: #908112 )
   * add debian/systemd/ipmitool.conf to load
      ipmi* kernel-modules under systemd
   * add debian/source/option
      compression xy / level 9
 .
   [ Gerald Turner <[email protected]> ]
   * changes on systemd startup scripts ( Closes: #750003 )
Checksums-Sha1: 
 336d260e659e3ef4f18dbef8c9e70a0ef74d6bd3 1944 ipmitool_1.8.14-2.dsc
 102efdd1f6fa5e7b602178be8e69b93468e75595 14060 ipmitool_1.8.14-2.debian.tar.xz
 37b8aa6de4e65180385e4d76f0cd52fb15eadb8b 354390 ipmitool_1.8.14-2_amd64.deb
Checksums-Sha256: 
 61b4c51308deba67d9d2bbafc7feb0f5f0c2764463fb7b369859de8fa6f7cf73 1944 
ipmitool_1.8.14-2.dsc
 be038241a77e9bf39e6b04494ba964682341e8de9b775bc98649387056fdf9b0 14060 
ipmitool_1.8.14-2.debian.tar.xz
 6854f2fea99b0de4b92a456d8cf1ee3258aa9af5f2ce11d3c684afa8230880ca 354390 
ipmitool_1.8.14-2_amd64.deb
Files: 
 d432ec42c724f9fa975c2d034bc51332 354390 utils optional 
ipmitool_1.8.14-2_amd64.deb
 56cba0a989de00e27018bab734353127 1944 utils optional ipmitool_1.8.14-2.dsc
 7d18c4c1743ac4c7b8e78f896e58be18 14060 utils optional 
ipmitool_1.8.14-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJTius8AAoJEI7tzBuqHzL/me4P/AuCM2Pihe0gAD7ZjrMXyNcx
AXLUr9B8ZtF0akb3fmqTJ/A9gBv3IiItN7WOiUHcBj+EQy4uEPgwGxU2olz6RH+G
Vc4SYDOwS4cAtL82vnaB3E2Q0772Mm8KMSP8LE8r8bFvnMTd4KOoWnW6ibCB7dN+
uLWqo73WKsjhrc7vnupkp1VDmXAM7OorJj+Pz96bK6qIoWPle8KiYMXyOoCIvPuD
9p3teX8MYueNiq0rZcQ/TePGYVXcUik+/1LM9ClRKQm81iZNqGGHBPCwJYDxWzG8
+LnE9SMZKsKn/jbGRCw8bExaPQxTkhlrAu/5dRzm7pZTSx8hGRCYOrV0ODqxpsTW
1nApygNQGZa2G4+Lv2IhbqQJQX2w5KA+XY3PBGknhQk2WujOeq9pJEdX/TCxhvts
GQK1AxodM8DviEUk5+yPa6YGbqJHtn1hZ5JwkrTursnDsNa1Gf7YZO7W8S/RUkwg
KcmaUnbaz3JuuNVkXINVfiy/ZfA4MN8JNQn/yPT6qPapJgdTX0pxhzSmHyvU5snc
7zEEtrelBSf+hMYqV7VFszWao0PiRQOwkjf7zNHc5KxS9lMOtmRf4mamcVSmO/f2
Z4Wsb8hOGK9ELbLFRcSiLBTAR8/6zTiph8rVf57OZJpdxT5hns3VH+CykqYi0of4
ASAPx5ezg0F8ntT4Yjmd
=MTsQ
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to