Your message dated Thu, 05 Jun 2014 04:18:37 +0000
with message-id <[email protected]>
and subject line Bug#750013: fixed in colord 1.2.1-1
has caused the Debian Bug report #750013,
regarding colord: FTBS on s390x: wrong cast from uint64_t * to uint32_t *
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
750013: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=750013
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: colord
Version: 1.2.0-3
Severity: serious
Tags: upstream patch
Justification: fails to build from source (but built successfully in the past)
colord fails to buid from source on s390x due to changs introduced in the
recent version. From the build log:
| Making all in data
| make[3]: Entering directory '/«PKGBUILDDIR»/data'
| Making all in cmf
| make[4]: Entering directory '/«PKGBUILDDIR»/data/cmf'
| \
| ../../client/cd-it8 create-cmf CIE1931-2deg-XYZ.cmf \
| ./CIE1931-2deg-XYZ.csv 1.0
|
| (lt-cd-it8:28566): GLib-ERROR **:
/build/glib2.0-QixhbO/glib2.0-2.40.0/./glib/gmem.c:103: failed to allocate
14804752269312 bytes
| make[4]: *** [CIE1931-2deg-XYZ.cmf] Trace/breakpoint trap
| Makefile:602: recipe for target 'CIE1931-2deg-XYZ.cmf' failed
| make[4]: Leaving directory '/«PKGBUILDDIR»/data/cmf'
| make[3]: *** [all-recursive] Error 1
The full build log is available at:
https://buildd.debian.org/status/fetch.php?pkg=colord&arch=s390x&ver=1.2.0-3&stamp=1401508205
The problem is due to a wrong cast in lib/colord/cd-it8.c:
| GDateTime *datetime = NULL;
| gsize size_tmp = 0;
| guint i;
...
| ret = cmsIT8SaveToMem (it8_lcms, NULL, (cmsUInt32Number *) &size_tmp);
| g_assert (ret);
| data_tmp = g_malloc (size_tmp);
| ret = cmsIT8SaveToMem (it8_lcms, data_tmp, (cmsUInt32Number *)
&size_tmp);
size_tmp is equivalent to an uint64_t, while cmsUInt32Number is
equivalent to uint32_t. Such a cast is not allowed, and does not work
on 64-bit big endian machines.
The patch bellow fixes the issue:
--- a/lib/colord/cd-it8.c
+++ b/lib/colord/cd-it8.c
@@ -1424,7 +1424,7 @@ cd_it8_save_to_data (CdIt8 *it8,
gchar *data_tmp = NULL;
gchar *date_str = NULL;
GDateTime *datetime = NULL;
- gsize size_tmp = 0;
+ cmsUInt32Number size_tmp = 0;
guint i;
g_return_val_if_fail (CD_IS_IT8 (it8), FALSE);
@@ -1494,10 +1494,10 @@ cd_it8_save_to_data (CdIt8 *it8,
}
/* write the file */
- ret = cmsIT8SaveToMem (it8_lcms, NULL, (cmsUInt32Number *) &size_tmp);
+ ret = cmsIT8SaveToMem (it8_lcms, NULL, &size_tmp);
g_assert (ret);
data_tmp = g_malloc (size_tmp);
- ret = cmsIT8SaveToMem (it8_lcms, data_tmp, (cmsUInt32Number *)
&size_tmp);
+ ret = cmsIT8SaveToMem (it8_lcms, data_tmp, &size_tmp);
g_assert (ret);
/* save for caller */
-- System Information:
Debian Release: jessie/sid
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: s390x
Kernel: Linux 3.2.0-4-s390x (SMP w/2 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
--- End Message ---
--- Begin Message ---
Source: colord
Source-Version: 1.2.1-1
We believe that the bug you reported is fixed in the latest version of
colord, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Christopher James Halse Rogers <[email protected]> (supplier of updated colord
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Thu, 05 Jun 2014 13:49:39 +1000
Source: colord
Binary: libcolord-dev libcolord2 colord colord-data gir1.2-colord-1.0
libcolorhug-dev libcolorhug2 gir1.2-colorhug-1.0
Architecture: source amd64 all
Version: 1.2.1-1
Distribution: unstable
Urgency: medium
Maintainer: Christopher James Halse Rogers <[email protected]>
Changed-By: Christopher James Halse Rogers <[email protected]>
Description:
colord - system service to manage device colour profiles -- system daemon
colord-data - system service to manage device colour profiles -- data files
gir1.2-colord-1.0 - GObject introspection data for the colord library
gir1.2-colorhug-1.0 - GObject introspection data for the colorhug library
libcolord-dev - system service to manage device colour profiles -- development
fi
libcolord2 - system service to manage device colour profiles -- runtime
libcolorhug-dev - library to access the ColorHug colourimeter -- development
files
libcolorhug2 - library to access the ColorHug colourimeter -- runtime
Closes: 750013
Changes:
colord (1.2.1-1) unstable; urgency=medium
.
* New upstream stable release. Fixes unsafe pointer cast, so
cd-create-profile no longer tries to allocate terabytes of
memory on 64bit big-endiane machines. (Closes: 750013)
* Move (very slow) print-profile generation to build-indep rule.
Checksums-Sha1:
9e02dc032cf3859c2573002a1dbf4a6a4032b2ce 2801 colord_1.2.1-1.dsc
4547f3a4d65fea36053f303f7313f60eae14b7d9 1164544 colord_1.2.1.orig.tar.xz
60a8ae6e6e4d8abc6ff5901bc5977903fcf2d762 14552 colord_1.2.1-1.debian.tar.xz
c84b6dffe8e397a9c43e87a9ded1b81e8d85c2a9 183860 libcolord-dev_1.2.1-1_amd64.deb
1e163024b1241ee2f12dd7d43bc6cb6598a231a4 226226 libcolord2_1.2.1-1_amd64.deb
861dedf0cc980b0828cc03becd86fc451f07f254 295744 colord_1.2.1-1_amd64.deb
767bab373d581c7fdc44a02efdb251196509f80b 1213264 colord-data_1.2.1-1_all.deb
7e65efdb1ae915bd48511c3a72b9b0f23796cfc4 150630
gir1.2-colord-1.0_1.2.1-1_amd64.deb
6e389f2a43e0290a5877179767da7968ba7d1651 148934
libcolorhug-dev_1.2.1-1_amd64.deb
16ac72274b51caf02f8d58333c1205f8f53646f3 153366 libcolorhug2_1.2.1-1_amd64.deb
6a728e94fe7e68b03dd34fcda7e2adda15fad827 138944
gir1.2-colorhug-1.0_1.2.1-1_amd64.deb
Checksums-Sha256:
b8023276e5f78cfdb2d7547829deff2482c376639d879871845c6ddba7e376bc 2801
colord_1.2.1-1.dsc
2db8c7002f7c859dce71a988de7c39f8370a6ab99a62b1037488208b43829bea 1164544
colord_1.2.1.orig.tar.xz
0a2a0d3f689d1383834ebb6773b9ca829446c3aa2ae223e4aeabd8449d5d9233 14552
colord_1.2.1-1.debian.tar.xz
240f47381150371ee02cac263c14a393c10de57e800eaec10b368606acb7b28c 183860
libcolord-dev_1.2.1-1_amd64.deb
c9c57065a4066948075eb7ec38c613e6fa191eed86e216023e05405cbb117ee8 226226
libcolord2_1.2.1-1_amd64.deb
09e97c25094fb1d3434cc34911293d83406f426ddcf59cc3ea1b842f8b21aa94 295744
colord_1.2.1-1_amd64.deb
42fc9d6a18217aa087c08146da84d019adf9fd6bab408783ccb208843c866428 1213264
colord-data_1.2.1-1_all.deb
731874abf504a8f90ba0d3484de2bfb32d5a859ddd042bf8f16a1254ee87f4a1 150630
gir1.2-colord-1.0_1.2.1-1_amd64.deb
e0321991dc98e79e7ecd3b0cd93c84c5e20018afb05d82be785e4376cfbf9f75 148934
libcolorhug-dev_1.2.1-1_amd64.deb
2a234a255f842d2c45e9fc7c91c636774ece440cdf0b13d9f216f33db2b80727 153366
libcolorhug2_1.2.1-1_amd64.deb
c4aa34612a4f645069f96adfd96ac8f72872b89662606d51937cd980bdbceeaf 138944
gir1.2-colorhug-1.0_1.2.1-1_amd64.deb
Files:
31d04bd15cad57496af7d9e2240ecf33 183860 libdevel optional
libcolord-dev_1.2.1-1_amd64.deb
0cd6b03aec5aaafef0760ce6627f8bc8 226226 libs optional
libcolord2_1.2.1-1_amd64.deb
29a8abe7cfb023619a6c025bef302803 295744 graphics optional
colord_1.2.1-1_amd64.deb
56b1ffc12dbfc62cf9dc59ae3574cd49 1213264 graphics optional
colord-data_1.2.1-1_all.deb
b500109afc7fd546e246cf44b2a90858 150630 introspection optional
gir1.2-colord-1.0_1.2.1-1_amd64.deb
181b2590ffd5eb2e68ce871f6f1ee223 148934 libdevel optional
libcolorhug-dev_1.2.1-1_amd64.deb
970e1699a1d4e84357940f93f2efb652 153366 libs optional
libcolorhug2_1.2.1-1_amd64.deb
6f1395e2a1adfa1336bc8ef3c826d9c6 138944 introspection optional
gir1.2-colorhug-1.0_1.2.1-1_amd64.deb
cc1ee8e43e1449997444d8b9818d76b3 2801 graphics optional colord_1.2.1-1.dsc
452e02b3a7cc3ae5b4fc9bef304a6902 1164544 graphics optional
colord_1.2.1.orig.tar.xz
d203b548bea9c351b1be9c2640800be0 14552 graphics optional
colord_1.2.1-1.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCAAGBQJTj+08AAoJENFO8V2v4RNHTyoQAIteYDIKLrXPn5DkHB7LH7IB
hiDO9iYwfa4riMSerSAMxzP4UvycVTY0BhoPQX3bE00sbaBu5tdWLqb5jVyY3B9M
xGGM0MXit0/LMaX4dpa8lx3SXrJQH0o8J1gwCntlsRbr6jDybTLlST92XCnjIjHw
/J9W5RsNUbAqvIrarAQ2ukMXFd9dQHCFkRGMlysfX+V5wDJwX7xljAsdogTInkyj
gRPMArolvQVw5nC4foTL8FOa8Rxd2wKEy11eFEY4bQqMJbneLUnV7Cf6OPE5xe5R
icQXohD4z2l+f5TPY/7zOUrKirKkZJKBtgeCNoPjftLb+fbE+sXJvAS8LgXMkrSo
YYHB5Uj4TKeC3u2kPPvTEj2Cidvofj+d3j4iKskvIuFwGU8ugEfm0towFlCb9QqS
LYCEKpVrpqibVZXbKEcnNl8WWRVuBphD1zbHnDtAFF0BqfAAw3kfjncrV9nLoNEY
8Fu/3jwkSLqAAG7ai21ztUaLReNdSLPbRXggth4DkOPuPv1UVLzhMn9jx2FyVo4T
UFhjqNhNDSfJfjeFvEMej2irmO6FjSQMU+c609eS6rrr4z05FWIwr7iSzMsn64oP
osWoDNosfG5Xy86QAk5UIfZBqEInUAlJvUHFr1Z8nKGfCjybLUIvIGG3QsLZQcWv
ujrz956TbHCo8zrq5H5r
=DeNH
-----END PGP SIGNATURE-----
--- End Message ---
