Your message dated Sun, 08 Jun 2014 05:18:52 +0000
with message-id <[email protected]>
and subject line Bug#747173: fixed in makedumpfile 1.5.6-2
has caused the Debian Bug report #747173,
regarding Make dmesg dump configurable
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
747173: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=747173
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: kdump-tools
Version: 1.5.5-2
Given that the dumping of the dmesg buffer can be problematic when kernels
change, it would be nice to be able to turn it off. Please consider the
attached patch for inclusion.
...Juerg
From 36281407d2f99ed8deb29a4f4c3d94506c1ccec5 Mon Sep 17 00:00:00 2001
From: Juerg Haefliger <[email protected]>
Date: Tue, 6 May 2014 07:44:45 +0000
Subject: [PATCH] Make the dumping of dmesg configurable
Dumping the dmesg buffer has shown to be problematic when kernels change
and it is not that useful of a feature in a production environment. This
patch introduces a new config variable that can turn the dmesg dump off.
The default behaviour unchanged, i.e., the dmesg buffer is dumped.
---
debian/kdump-config | 36 ++++++++++++++++++++----------------
debian/kdump-tools.5 | 3 +++
debian/kdump-tools.default | 4 ++++
3 files changed, 27 insertions(+), 16 deletions(-)
diff --git a/debian/kdump-config b/debian/kdump-config
index 2e6cad9..b196214 100755
--- a/debian/kdump-config
+++ b/debian/kdump-config
@@ -44,6 +44,7 @@ ARCH=`uname -m`
# Set up defaults
KDUMP_SYSCTL=${KDUMP_SYSCTL:="kernel.panic_on_oops=1"}
KDUMP_COREDIR=${KDUMP_COREDIR:=/var/crash}
+KDUMP_DUMP_DMESG=${KDUMP_DUMP_DMESG:=1}
MAKEDUMP_ARGS=${MAKEDUMP_ARGS:="-c -d 31"}
KDUMP_CMDLINE_APPEND=${KDUMP_CMDLINE_APPEND:="irqpoll maxcpus=1 nousb"}
[ -d $KDUMP_COREDIR ] || mkdir -p $KDUMP_COREDIR ;
@@ -337,23 +338,26 @@ function kdump_save_core()
logger -t $NAME "failed to save vmcore in $KDUMP_STAMPDIR"
fi
- log_action_msg "running makedumpfile --dump-dmesg $vmcore_file $KDUMP_DMESGFILE"
- makedumpfile --dump-dmesg $vmcore_file $KDUMP_DMESGFILE
- ERROR=$?
- if [ $ERROR -ne 0 ] ; then
- log_failure_msg "$NAME: makedumpfile --dump-dmesg failed. dmesg content will be unavailable"
- logger -t $NAME "makedumpfile --dump-dmesg failed. dmesg content will be unavailable"
- fi
+ # dump the dmesg buffer
+ if [ $KDUMP_DUMP_DMESG -eq 1 ] ; then
+ log_action_msg "running makedumpfile --dump-dmesg $vmcore_file $KDUMP_DMESGFILE"
+ makedumpfile --dump-dmesg $vmcore_file $KDUMP_DMESGFILE
+ ERROR=$?
+ if [ $ERROR -ne 0 ] ; then
+ log_failure_msg "$NAME: makedumpfile --dump-dmesg failed. dmesg content will be unavailable"
+ logger -t $NAME "makedumpfile --dump-dmesg failed. dmesg content will be unavailable"
+ fi
- # did we succeed?
- if [ $ERROR == 0 ]; then
- log_success_msg "$NAME: saved dmesg content in $KDUMP_STAMPDIR"
- logger -t $NAME "saved dmesg content in $KDUMP_STAMPDIR"
- return 0;
- else
- log_failure_msg "$NAME: failed to save dmesg content in $KDUMP_STAMPDIR"
- logger -t $NAME "failed to save dmesg content in $KDUMP_STAMPDIR"
- return 1;
+ # did we succeed?
+ if [ $ERROR == 0 ]; then
+ log_success_msg "$NAME: saved dmesg content in $KDUMP_STAMPDIR"
+ logger -t $NAME "saved dmesg content in $KDUMP_STAMPDIR"
+ return 0;
+ else
+ log_failure_msg "$NAME: failed to save dmesg content in $KDUMP_STAMPDIR"
+ logger -t $NAME "failed to save dmesg content in $KDUMP_STAMPDIR"
+ return 1;
+ fi
fi
}
diff --git a/debian/kdump-tools.5 b/debian/kdump-tools.5
index 0d18361..c4d932c 100644
--- a/debian/kdump-tools.5
+++ b/debian/kdump-tools.5
@@ -83,6 +83,9 @@ will be used.
.B KDUMP_FAIL_CMD
This variable specifies a command to run if the vmcore save fails.
If not set, no special action is taken.
+.TP
+.B KDUMP_DUMP_DMESG
+This variable controls if the dmesg buffer is dumped. If not set or set to 1, the dmesg buffer is dumped. If set to 0, the dmesg buffer is not dumped.
.\"
.\"
.\"
diff --git a/debian/kdump-tools.default b/debian/kdump-tools.default
index 8d02da0..b93613a 100644
--- a/debian/kdump-tools.default
+++ b/debian/kdump-tools.default
@@ -34,8 +34,12 @@ USE_KDUMP=0
# is the default.
# Example - start a shell if the vmcore copy fails:
# KDUMP_FAIL_CMD="echo 'makedumpfile FAILED.'; /bin/bash; reboot -f"
+# KDUMP_DUMP_DMESG - This variable controls if the dmesg buffer is dumped.
+# If unset or set to 1, the dmesg buffer is dumped. If set to 0, the dmesg
+# buffer is not dumped.
KDUMP_COREDIR="/var/crash"
#KDUMP_FAIL_CMD="reboot -f"
+#KDUMP_DUMP_DMESG=
# ---------------------------------------------------------------------------
--
2.0.0.rc0
--- End Message ---
--- Begin Message ---
Source: makedumpfile
Source-Version: 1.5.6-2
We believe that the bug you reported is fixed in the latest version of
makedumpfile, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Louis Bouchard <[email protected]> (supplier of updated makedumpfile
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Fri, 23 May 2014 12:33:24 +0200
Source: makedumpfile
Binary: makedumpfile kdump-tools
Architecture: source amd64 all
Version: 1.5.6-2
Distribution: unstable
Urgency: medium
Maintainer: John Wright <[email protected]>
Changed-By: Louis Bouchard <[email protected]>
Description:
kdump-tools - scripts and tools for automating kdump (Linux crash dumps)
makedumpfile - VMcore extraction tool
Closes: 747173
Changes:
makedumpfile (1.5.6-2) unstable; urgency=medium
.
* [ Juerg Haefliger <[email protected]> ]
Make the dumping of dmesg configurable
.
Dumping the dmesg buffer has shown to be problematic when kernels
change. This patch introduces a new config variable that can turn
the dmesg dump off. The default behaviour unchanged, i.e., the
dmesg buffer is dumped.
Closes: 747173
Checksums-Sha1:
dddde8f396e74d81258fd0f5b2711bce728b4917 1460 makedumpfile_1.5.6-2.dsc
6eb0fbd64a087b0f802218f13ec5d0f9e6bb742c 14116
makedumpfile_1.5.6-2.debian.tar.xz
277bccafd87f4142f30e7c6546b43bbf36e8a22a 127578 makedumpfile_1.5.6-2_amd64.deb
bce62d5958455a3ff1f8433b81d921cca639aea2 16512 kdump-tools_1.5.6-2_all.deb
Checksums-Sha256:
2995b73f6583379c25d74ab9193fbb7d8be7a2bd46d96ba7fd03885d7292c6f6 1460
makedumpfile_1.5.6-2.dsc
8e7c528fde412bc3c744b2e234aa32ca1d5458ddb9eb4d9a5b9991fc1dde9a8f 14116
makedumpfile_1.5.6-2.debian.tar.xz
61c1f8729de0f31d53d073f04fb27fbe4228ffa019330aa2c16d4493cdd88f3d 127578
makedumpfile_1.5.6-2_amd64.deb
32b694db9951c255fd0c7b88a194d1c36e94265b571f48d3716dfb205a976664 16512
kdump-tools_1.5.6-2_all.deb
Files:
222c251971977904d6667c6eb90717e2 127578 devel optional
makedumpfile_1.5.6-2_amd64.deb
b144aa7d781279811e2a91e23b0ec5c3 16512 devel optional
kdump-tools_1.5.6-2_all.deb
61d56af2b22749a6ffbf35a9d832dd99 1460 devel optional makedumpfile_1.5.6-2.dsc
f19c44d1326ede6cabf38550585b98f0 14116 devel optional
makedumpfile_1.5.6-2.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iEYEARECAAYFAlOT8YYACgkQ0UIZh3p4ZWFQ5wCfdZV6bCZlSWAwALL6O41tB6jk
nXwAn0317KBIakzOZRWMCSWwRG/1t2dZ
=XjQ9
-----END PGP SIGNATURE-----
--- End Message ---
