Your message dated Sun, 08 Jun 2014 10:23:25 +0000
with message-id <[email protected]>
and subject line Bug#743741: fixed in modem-manager-gui 0.0.16-3
has caused the Debian Bug report #743741,
regarding modem-manager-gui: fails to build with clang instead of gcc
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
743741: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=743741
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: modem-manager-gui
Version: 0.0.16-2
Severity: minor
Tags: patch
User: [email protected]
Usertags: clang-ftbfs
Dear Maintainer,
Your package fails to build with clang instead of gcc. [-Wreturn-type]
The attached patch fixes it.
Buildlogs and patch are here:
https://github.com/nonas/debian-clang/tree/master/buildlogs/modem-manager-gui
Regards,
Nicolas
-- System Information:
Debian Release: jessie/sid
APT prefers testing-updates
APT policy: (500, 'testing-updates'), (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.13-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Description: fix FTBFS with clang instead of gcc
Author: Nicolas Sévelin-Radiguet <[email protected]>
Last-Update: 2014-04-05
--- a/src/libpaths.c
+++ b/src/libpaths.c
@@ -294,7 +294,7 @@
guint ptr, start, end, entry, entries;
gchar *entryhash, *entryname, *entryext;
- if (libcache == NULL) return;
+ if (libcache == NULL) return 0;
/*Cache file must be terminated with value 0x00*/
if (libcache->mapping[libcache->mapsize-1] != 0x00) {
--- a/src/main.c
+++ b/src/main.c
@@ -732,7 +732,7 @@
appdata = (mmgui_application_data_t)data;
- if (appdata == NULL) return;
+ if (appdata == NULL) return FALSE;
currenttime = time(NULL);
@@ -1425,7 +1425,7 @@
mmguiapp = (mmgui_application_t)data;
- if (mmguiapp == NULL) return;
+ if (mmguiapp == NULL) return FALSE;
if (mmguiapp->options->askforhide) {
/*Ask at exit*/
@@ -1752,7 +1752,7 @@
mmguiapp = (mmgui_application_t)data;
- if (mmguiapp == NULL) return;
+ if (mmguiapp == NULL) return FALSE;
if (mmguicore_devices_get_current(mmguiapp->core) != NULL) {
unreadmessages = mmgui_smsdb_get_unread_messages(mmguicore_devices_get_sms_db(mmguiapp->core));
@@ -1795,7 +1795,7 @@
guint id, contacttype;
mmgui_contact_t contact;
- if (mmguiapp == NULL) return;
+ if (mmguiapp == NULL) return 0;
model = gtk_tree_view_get_model(GTK_TREE_VIEW(mmguiapp->window->contactstreeview));
selection = gtk_tree_view_get_selection(GTK_TREE_VIEW(mmguiapp->window->contactstreeview));
@@ -2958,8 +2958,8 @@
mmguiapp = (mmgui_application_t)data;
- if (mmguiapp == NULL) return;
- if (mmguiapp->core == NULL) return;
+ if (mmguiapp == NULL) return FALSE;
+ if (mmguiapp->core == NULL) return FALSE;
device = mmguicore_devices_get_current(mmguiapp->core);
@@ -2995,8 +2995,8 @@
mmguiapp = (mmgui_application_t)data;
- if (mmguiapp == NULL) return;
- if (mmguiapp->core == NULL) return;
+ if (mmguiapp == NULL) return FALSE;
+ if (mmguiapp->core == NULL) return FALSE;
device = mmguicore_devices_get_current(mmguiapp->core);
@@ -4183,7 +4183,7 @@
gint smsvalidflags;
enum _mmgui_main_new_sms_dialog_result result;
- if (mmguiapp == NULL) return;
+ if (mmguiapp == NULL) return 0;
smsvalidflags = MMGUI_MAIN_NEW_SMS_VALIDATION_VALID;
--- End Message ---
--- Begin Message ---
Source: modem-manager-gui
Source-Version: 0.0.16-3
We believe that the bug you reported is fixed in the latest version of
modem-manager-gui, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Graham Inggs <[email protected]> (supplier of updated modem-manager-gui
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sun, 08 Jun 2014 11:41:49 +0200
Source: modem-manager-gui
Binary: modem-manager-gui
Architecture: source amd64
Version: 0.0.16-3
Distribution: unstable
Urgency: medium
Maintainer: Graham Inggs <[email protected]>
Changed-By: Graham Inggs <[email protected]>
Description:
modem-manager-gui - Modem Manager GUI
Closes: 721782 743741
Changes:
modem-manager-gui (0.0.16-3) unstable; urgency=medium
.
* Change architecture to linux-any (Closes: #721782).
* New d/patches/clang_FTBFS_Wreturn-type.patch:
Non-void functions should return a value (Closes: #743741).
(Fixes FTBFS with clang instead of gcc)
* Bump Standards-Version to 3.9.5, no changes.
* Update d/watch.
Checksums-Sha1:
baa019a01d24e667dcd3a9ff136ed61cd6463c40 2003 modem-manager-gui_0.0.16-3.dsc
15a80db073ef49460fbec1bd70787bf70ac20242 5984
modem-manager-gui_0.0.16-3.debian.tar.xz
b7fe0c4f734051bc265a392b1c971940e02fc23a 185816
modem-manager-gui_0.0.16-3_amd64.deb
Checksums-Sha256:
70fdcc07d5705e60c0a1dd68be9b91a9960d63fa6683bc033ede0290c8bdf1c1 2003
modem-manager-gui_0.0.16-3.dsc
7c5c8765adc509f11c448954280c29ad56eda0a7c72185ecce8c7007d5e60e30 5984
modem-manager-gui_0.0.16-3.debian.tar.xz
e029c01487edb3ae8a07f90e81f3af05ad7d668730e055c6d7fdc2417fa40138 185816
modem-manager-gui_0.0.16-3_amd64.deb
Files:
5b13a6552b230c23768253b7bc23f354 185816 net optional
modem-manager-gui_0.0.16-3_amd64.deb
4c3ca9d73a9f695d95b3b39bde9fba8c 2003 net optional
modem-manager-gui_0.0.16-3.dsc
8dbb33c653c3edc9153bbe924b2f576b 5984 net optional
modem-manager-gui_0.0.16-3.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCgAGBQJTlDBEAAoJEACQ/CG1zRrMrWUP/RxalsO/gsKoXKQesW8WQfm6
AfWQcQaBHPiRmbmd4gcE71MrOgOxc2V617yx0ftmBV+wFsuLGaLCnItWRlOfNDxj
yXBn1BSWWRM+ytEGYksLgsHNBxNckHA+UMInIcZLtI0oLwsPfvG1zuGA9H/xINdN
9RTTZDU28AjAluDIVZIH2o7GjSr+P3QRrIBGH4HgeOR17USif950WH3qJjBqJdgC
zyvDwOSFV8RDqc52k92FBluOQBqu4zP97RZFbGnR5FSJxaLtEHK3P5kcPozyC9i1
Ihk7b4iO5pgj9P3R1gv/Kzjm1smlFaTN6XOpfOYUt9HtQwk8AyyD5bo/QjCAaFd7
kTnaU/54vUas8VbWORlCLt/azykmJx97+lRLI/o6ReSvStTEVFRRS9Ct1hv9+zUY
cigmmcTQRTm0gBv0lTbbrhIV6ek7LZKAi20P5l4a2h1YEyEwQIQBHPAJOgxnCTnv
NmJUgRfzrq1GK/UQdGwflc1iQ6d1Len7/6Uu/YApNrsAY1EoFQgpAgbgPfwM9EdE
OlToGL8ma+vIZbrM4SLS9Z/9ZSoQqSlZrykYrnAIiZLceMCdnRGTQzIq8oxDoeXc
GnnVxZiy4Gedo+/Tk85O9/hevxv4RHRJyjg0ehC3d7d0dHrhZegv4kfwmUy4L6ff
busEleajJFQPwdyOGeXU
=h5Ws
-----END PGP SIGNATURE-----
--- End Message ---
