Your message dated Thu, 12 Jun 2014 04:04:01 +0000
with message-id <[email protected]>
and subject line Bug#751224: fixed in 0ad 0.0.16-3
has caused the Debian Bug report #751224,
regarding FTBFS with newer libminiupnpc10
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
751224: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=751224
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: 0ad
Version: 0.0.16-2
Severity: important
Tags: patch

Dear package maintainer,

We would like to have a transition to the last version of libminiupnpc10
which I uploaded to experimental. Unfortunately, 0ad FTBFS when building
with that new version.

I've attached to this bug report a patch for 0ad, which you can simply
drop in debian/patches. Please upload a new version of 0ad including this
patch ASAP, so we can start the miniupnpc transition.

Note that I have tested the patch, and 0ad built fine with it. However,
I didn't check/test for the UPnP functionality.

Cheers,

Thomas Goirand (zigo)
Description: Allow build with miniUPnPc > 9
 UPNP_GetSpecificPortMappingEntry() API changed, this patch makes it possible
 to support both old and new versions.
Author: Thomas Goirand <[email protected]>
Forwarded: no
Last-Update: 2014-06-11

--- 0ad-0.0.16.orig/source/network/NetServer.cpp
+++ 0ad-0.0.16/source/network/NetServer.cpp
@@ -272,11 +272,19 @@ void* CNetServerWorker::SetupUPnP(void*)
 	}
 
 	// Check that the port was actually forwarded.
+#if defined(MINIUPNPC_API_VERSION) && MINIUPNPC_API_VERSION > 9
+	ret = UPNP_GetSpecificPortMappingEntry(urls.controlURL,
+									 data.first.servicetype,
+									 psPort, protocall,
+									 intClient, intPort, NULL/*desc*/,
+									 NULL/*enabled*/, duration, NULL);
+#else
 	ret = UPNP_GetSpecificPortMappingEntry(urls.controlURL,
 									 data.first.servicetype,
 									 psPort, protocall,
 									 intClient, intPort, NULL/*desc*/,
 									 NULL/*enabled*/, duration);
+#endif
 
 	if (ret != UPNPCOMMAND_SUCCESS)
 	{

--- End Message ---
--- Begin Message ---
Source: 0ad
Source-Version: 0.0.16-3

We believe that the bug you reported is fixed in the latest version of
0ad, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Vincent Cheng <[email protected]> (supplier of updated 0ad package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 11 Jun 2014 19:46:46 -0700
Source: 0ad
Binary: 0ad 0ad-dbg
Architecture: source amd64
Version: 0.0.16-3
Distribution: unstable
Urgency: medium
Maintainer: Debian Games Team <[email protected]>
Changed-By: Vincent Cheng <[email protected]>
Description:
 0ad        - Real-time strategy game of ancient warfare
 0ad-dbg    - Real-time strategy game of ancient warfare (debug)
Closes: 751224
Changes:
 0ad (0.0.16-3) unstable; urgency=medium
 .
   * Add debian/patches/support_miniupnpc_1.9.patch to fix FTBFS when built
     with miniupnpc >= 1.9. (Closes: #751224)
   * Tighten build-dep on libminiupnpc-dev (>= 1.6).
Checksums-Sha1:
 e3b2f4b5cb8386d9aafe2524609cc06118b8239d 2465 0ad_0.0.16-3.dsc
 94820d5c2a8fcc01edb19a31933d0401ea51bf8e 93688 0ad_0.0.16-3.debian.tar.xz
 a4be87b9f341dd1b996cf17405071df93fe5dc8c 2683670 0ad_0.0.16-3_amd64.deb
 dfb3718cbfd978bfbaf2272deb8176bdf4cd44a8 54580968 0ad-dbg_0.0.16-3_amd64.deb
Checksums-Sha256:
 1e10c248c2ba6354ba6dc772919414958baa34f1bfe3bc056bb2f1d03f4617ec 2465 
0ad_0.0.16-3.dsc
 20b1b46d52631c6ba65017bd42a7dc9048226248fe1f5c8f4ba9df5e3895313e 93688 
0ad_0.0.16-3.debian.tar.xz
 b125857fc9f70c38f217dc66da6282a67bf3f194a5e30bf73cc03e7b7fa5e092 2683670 
0ad_0.0.16-3_amd64.deb
 3c16061fb76ad7302b8cb75c33eb3fbfc99af7764d9b7f7130d66691b78c755f 54580968 
0ad-dbg_0.0.16-3_amd64.deb
Files:
 6cc3e585073aec9682b5c92e691ed7a8 2683670 games optional 0ad_0.0.16-3_amd64.deb
 0f59130266f2bc860d1e98235a177487 54580968 debug extra 
0ad-dbg_0.0.16-3_amd64.deb
 b3a3c7eafffaa584e7b258b357c8fac0 2465 games optional 0ad_0.0.16-3.dsc
 028b8b46b038a78fd5c2077fb54b30a7 93688 games optional 
0ad_0.0.16-3.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJTmRw8AAoJEI7tzBuqHzL/Au8P/15ov/hUvyT7fAR1CZCqocYn
hCW+NFucFPALToBIbxqGSbeiVqyelUi30hHr9rR0DEaXL3S99VH21MEY5jFLeQyu
1qX9v6tM1jWU3r9F7beWvfLhcZB289n9J54bIbn7anUHpUSOXudgD1iIzsHDPDdh
r2k4DeM3RZAoZYQfx/dkRFkVed2jhjMhuNYQrKD9639vbhLGQbm+1+yVULwgc+fm
ViiWzKwg2uDnN6B7Kmn4h4aKhdQQ7ngo0ozFv4SE+PPa9b9LpEQMvWc4u5nWRlYh
32hv+AbQlICqhe26gzkl/Z+LEwJGm3kmPlSjS0vOe8kvYthdmAprl0EvQE0a7k+C
FSDD8sooKVtFSe1isrLY117lvEhnWtR+keLo1LlbHWOdDELswCbl1o+IlX9zK+b9
zfUs40wk7Oz6UvUvbl2D6GW+SOJEFyYdIYKkjwIafm4Uz83bko5AnaKAnmwproaO
SN02uOcXfa7VWWkJ0V3I5OB4K+vNaXkGc9POIRJF0br5ar1KD8JNSWDNXHcptJ/Z
z2NmQt31eHQifsrWvl61v4SOJfOzzdkqTTQF4dwUnbY8ECnXRkalNa8DwQSE0UCv
dTLf6xLhwwVsJKIJyKDKpM+28bdpCxaZLGJlBqMGeN3n/jgRxy0nQLISt3kAN7ZS
HRpJLHSQMP0aZIWF2j/K
=wP1X
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to