Your message dated Thu, 26 Jun 2014 09:57:20 +0000 with message-id <[email protected]> and subject line Bug#745708: fixed in open-iscsi 2.0.873+git0.3b4b4500-2 has caused the Debian Bug report #745708, regarding open-iscsi: umountiscsi.sh prematurely exits when encountering targets without block devices to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 745708: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=745708 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: open-iscsi Version: 2.0.873-3 Severity: normal Tags: patch Dear Maintainer, While rebooting a server with iscsi partitions I encountered bug #691732 . Seeing that #691732 was fixed in version 2.0.873+git0.3b4b4500-1 of open-iscsi I looked over the changes and noticed that if umountiscsi.sh finds an iscsi target without block devices it does an exit 0 while in the middle of the for loop and skips the rest of the targets. This could be a problem if the target without block devices is not the last target. See my patch below which continues instead of an exit. Sammy -- System Information: Debian Release: 7.4 APT prefers stable APT policy: (990, 'stable'), (500, 'stable-updates') Architecture: amd64 (x86_64) Kernel: Linux 3.13-0.bpo.1-amd64 (SMP w/4 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages open-iscsi depends on: ii libc6 2.13-38+deb7u1 ii udev 204-8~bpo70+1 open-iscsi recommends no packages. open-iscsi suggests no packages. -- Configuration Files: /etc/iscsi/initiatorname.iscsi [Errno 13] Permission denied: u'/etc/iscsi/initiatorname.iscsi' -- no debconf information --- patch for umountiscsi.sh --- diff --git a/debian/umountiscsi.sh.init b/debian/umountiscsi.sh.init index 8f7161b..d5b0591 100644 --- a/debian/umountiscsi.sh.init +++ b/debian/umountiscsi.sh.init @@ -56,9 +56,8 @@ do_stop () { for BLOCK_FILE in $SESSION_DIR/target*/*\:*/block/*; do BLOCK_DEV=`echo "$BLOCK_FILE" | sed 's/.*block\///'` if [ "${BLOCK_DEV}" = "*" ];then - log_warning_msg "No iSCSI block devices found" - log_end_msg 0 - exit 0 + log_warning_msg "iSCSI target without block devices found" + continue fi DOS_PARTITIONS="`awk "/^\/dev\/$BLOCK_DEV/ { print \\$2; }" < /proc/mounts`" for DEVICE in $DOS_PARTITIONS; do --- end patch ---
--- End Message ---
--- Begin Message ---Source: open-iscsi Source-Version: 2.0.873+git0.3b4b4500-2 We believe that the bug you reported is fixed in the latest version of open-iscsi, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Ritesh Raj Sarraf <[email protected]> (supplier of updated open-iscsi package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Thu, 26 Jun 2014 13:05:48 +0530 Source: open-iscsi Binary: open-iscsi open-iscsi-udeb Architecture: source amd64 Version: 2.0.873+git0.3b4b4500-2 Distribution: unstable Urgency: medium Maintainer: Debian iSCSI Maintainers <[email protected]> Changed-By: Ritesh Raj Sarraf <[email protected]> Description: open-iscsi - High performance, transport independent iSCSI implementation open-iscsi-udeb - Configure iSCSI (udeb) Closes: 736349 745708 750610 Changes: open-iscsi (2.0.873+git0.3b4b4500-2) unstable; urgency=medium . [ Philipp Hug ] * [b517ebb] Start open-iscsi after installation and make sure initiatorname is generated. . [ Ritesh Raj Sarraf ] * [7e1ae42] Add patch to enable fsck, mount and swap for network block devices. Thanks to Turbo Fredriksson (Closes: #736349) * [92ac387] Don't prematurely exit when encountering targets with no block device. Thanks to Sammy Atmadja (Closes: #745708) * [7363428] Add autotools-dev for updated config.{sub,guess}. Also add dh-autoreconf in build-depends to support new architectures. Thanks to Chen Baozi <[email protected]> and Wookey (Closes: 750610) Checksums-Sha1: c32b13ef95268b47b5a08d06720ff89323e6967f 2465 open-iscsi_2.0.873+git0.3b4b4500-2.dsc 28e6d82b40dd89b834afc9d919b5b862a77d757f 16028 open-iscsi_2.0.873+git0.3b4b4500-2.debian.tar.xz a95e6055de97f3ac1c6564e3a5c6ab2323db0aed 294130 open-iscsi_2.0.873+git0.3b4b4500-2_amd64.deb 2e8bb3c16935da0c0b2aaf6644ed760140454433 254230 open-iscsi-udeb_2.0.873+git0.3b4b4500-2_amd64.udeb Checksums-Sha256: 75f00b1275f701d932665b7f15ed58ad840e532fa0defa3070b8600e6e869846 2465 open-iscsi_2.0.873+git0.3b4b4500-2.dsc 7035c38bbb6e41e68dffb3de7097cb5e677a0d9884f6c4a306178cc1508f8dab 16028 open-iscsi_2.0.873+git0.3b4b4500-2.debian.tar.xz 18a2e201bfaf99b7637318a8652f20e0f9da4a3c68b18b9a7263e088918fa0ce 294130 open-iscsi_2.0.873+git0.3b4b4500-2_amd64.deb 8158e5e6207494b9259748cc5635a2a17d12e8b82ee7aace6a75103589ee97d2 254230 open-iscsi-udeb_2.0.873+git0.3b4b4500-2_amd64.udeb Files: f8e0bf107919f7d7564d3dd95836faf0 294130 net optional open-iscsi_2.0.873+git0.3b4b4500-2_amd64.deb 2d895cdb9dad153fdd2f3b52e520a7d5 254230 debian-installer optional open-iscsi-udeb_2.0.873+git0.3b4b4500-2_amd64.udeb 9527367cb4ff01bfecce26afb160fd98 2465 net optional open-iscsi_2.0.873+git0.3b4b4500-2.dsc d0aab26bbb2c10720b1b5c32b953eae3 16028 net optional open-iscsi_2.0.873+git0.3b4b4500-2.debian.tar.xz -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQJ8BAEBCgBmBQJTq+BMXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ0MDI1NDNCMkQ5ODg1NDAwN0Y2MjdEMzZB NjNBNThBM0YyRTE3NTY5AAoJEKY6WKPy4XVp+YgP/jQu02nnWkxa4fWvGZbGuf+8 l29z1aogd56n3+naxPzufbzDBAyHitQ9SoK9tCNX5c4Ix8Vl8i4oo+ha94N+lELu UHPLv1TOaMjVbzVW/XFFOnCQtbEgbyMp6f5iEWh4iZAZ2CD4yFnuxfuVJHjXHFlm nIxS28GZ4I/HfuS/T2nGgunOnRVdDWxzxqrzijyAxAcxfpqHPT4BLRikDIQsog8a KJgVEm7UgMMopFrLsQVF6t4OuptlxJKxHORDn/IJW4fIec+C+x9UjqR2IIjqaj6s dYBXnglMbpY+4jwtzW1Fcga9PIwSJH9TPlB6+oENxPJgLtNealESIEQDAPZRLg2x IrEYTQxwVQbYfNl6bg0oa7wPB1Zyz2etxUBuXn4DjaDoR+XIl7CtpwA4eIdaO0CF xBw72sp4KRRqOsnff/A5Z+Fje7RuCUPJVsMAQpKgC6ou6RFdXS+DcgFy/7oU4/7X VkxrVUqLFONVOyb8jW9B2ktox0PI919RE3MFXQzvZjCL2GUUR8I9TR7a9zkQxK2J RjhlpONTy5m9qxNve5FwdE0QiL4JkT9rQT2agulRP9C2rBA7cG+nf8YwFSlqKM2q kOJLKAR7XqkNquAXjA3xMA8yl/cxJnC9nfkfmtH8Ov8VXqefWJ4J5IfXQaXksAoG 2oMI+gXvYDZzHhsnifHD =dGd7 -----END PGP SIGNATURE-----
--- End Message ---
