Your message dated Sat, 28 Jun 2014 18:19:09 +0000
with message-id <[email protected]>
and subject line Bug#746179: fixed in pkg-php-tools 1.12
has caused the Debian Bug report #746179,
regarding Please, handle multiple versions with Composer
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
746179: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=746179
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: pkg-php-tools
Version: 1.11
Severity: normal
Tags: patch
Control: affects -1 aws-sdk-for-php

Hi,

The upcoming aws-sdk-for-php version, that relies on composer, requires:

        "guzzle/guzzle": ">=3.7.0,<=3.9.9"

The current dh_phpcomposer chokes on it:

        [pear_error: message="Unable to parse version (>=3.7.0,<=3.9.9)" code=0 
mode=return level=notice prefix="" info=""]

and produces an awful version string:

        php-guzzle (ERROR:parsing ? >=3.7.0,<=3.9.9)

The attached patch fixes the issue. I’m not sure if I should commit
such non well tested (and potentially ugly) patch directly, please tell
me if you would feel comfortable with that (on the other hand, since I’m
using the #738690 and #738284 proposed patches for a while without
drawback, I just pushed the fixes).

Regards

David
From c8b0f5400c65ea61ed59370fd48df605cedee45a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?David=20Pr=C3=A9vot?= <[email protected]>
Date: Sun, 27 Apr 2014 13:21:46 -0400
Subject: [PATCH] Composer: Handle multiple versions

---
 lib/scripts/phppkginfo | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

diff --git a/lib/scripts/phppkginfo b/lib/scripts/phppkginfo
index 59cad76..5d8fd8b 100755
--- a/lib/scripts/phppkginfo
+++ b/lib/scripts/phppkginfo
@@ -451,9 +451,20 @@ function composerDebianVersion($pkg, $version, $link) {
 function composerDebianDependencies($link, $infos) {
 	$ret = '';
 	foreach ($infos as $pkg => $version) {
-		$dep = composerDebianVersion($pkg, $version, $link);
-		if ($dep !== NULL) {
-			$ret.= $dep.', ';
+		if ((!preg_match ('/\s+as +[^,\s]+$/', $version)) and (strpos ($version, ','))) {
+			$versions = explode(',', $version);
+			foreach ($versions as $version) {
+				$dep = composerDebianVersion($pkg, $version, $link);
+				if ($dep !== NULL) {
+					$ret.= $dep.', ';
+				}
+			}
+		}
+		else {
+			$dep = composerDebianVersion($pkg, $version, $link);
+			if ($dep !== NULL) {
+				$ret.= $dep.', ';
+			}
 		}
 	}
 	return substr($ret, 0, -2);
-- 
2.0.0.rc0

Attachment: signature.asc
Description: Digital signature


--- End Message ---
--- Begin Message ---
Source: pkg-php-tools
Source-Version: 1.12

We believe that the bug you reported is fixed in the latest version of
pkg-php-tools, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
David Prévot <[email protected]> (supplier of updated pkg-php-tools package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 28 Jun 2014 13:42:25 -0400
Source: pkg-php-tools
Binary: pkg-php-tools
Architecture: source all
Version: 1.12
Distribution: unstable
Urgency: medium
Maintainer: Debian PHP PEAR Maintainers <[email protected]>
Changed-By: David Prévot <[email protected]>
Description:
 pkg-php-tools - various packaging tools and scripts for PHP packages
Closes: 737558 738284 738690 746179 751413 751422
Changes:
 pkg-php-tools (1.12) unstable; urgency=medium
 .
   * Team upload
 .
   [ Prach Pongpanich ]
   * Support Zend extensions (Closes: #737558)
 .
   [ Mathieu Parent ]
   * Override extension/com to none, as it is for MS Windows only
 .
   [ David Prévot ]
   * dh_phppear: Keep newline in description (Closes: #738690)
   * Composer:
     - Allow wildcard for WIP releases (Closes: #738284)
     - Handle multiple versions (Closes: #746179)
     - Handle self.version (Closes: #751413)
 .
   [ Daniel Beyer ]
   * Composer: handle uppercase WIP releases (Closes: #751422)
Checksums-Sha1:
 81df4fc69136001b5c0ade50754300d94c92647a 1736 pkg-php-tools_1.12.dsc
 4ad66f69225b70e815abd7a0021aa7e33ac96b5f 20780 pkg-php-tools_1.12.tar.xz
 16095a46d7de86550f182ab3372ad214fe4ec624 23664 pkg-php-tools_1.12_all.deb
Checksums-Sha256:
 868fc60f22af36a5dee82ce8227c8a9466c3bb960c517ae358abb52d70d058fb 1736 
pkg-php-tools_1.12.dsc
 b94e70b69a1fdde971ee439cb167da04182c4867097a42b8c15ff0179cb1bcfa 20780 
pkg-php-tools_1.12.tar.xz
 f265a19a98bb4e42ffddf3b851102adf484f274bb75269a76a0550b5e55c0743 23664 
pkg-php-tools_1.12_all.deb
Files:
 b94ad1824d061709c9e793509f68086b 23664 php extra pkg-php-tools_1.12_all.deb
 ea599f81d630c169a6410d6cb89a4207 1736 php extra pkg-php-tools_1.12.dsc
 216c4112a9bca44d40396ca9d3aec823 20780 php extra pkg-php-tools_1.12.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJTrwXUAAoJELgqIXr9/gny86cQAKAU3Pe442AHJUEqvKUDXa55
701PXyUJ1y7JsFLXquDxgxHYQJ+oZLbhVvZJAXloF7uXn19tzVNGSOmLeWD6EEcG
XhnGoq9BulxuhSArFdd6zQTpSNmuzyXPoO1KNlaHTdy5Yg2hz1lHtDq186hquW27
tGdynv5BdHzn/Rk7J4kTjejOTLCag4BaUAPDCyIynIt6ZUJiPMOh4FCaLxosL34c
B5chq2JWEI7kqrwV9rjYBHLsIMviv7L54WveGTt6kvKiL+KZ8NFTQvzWWPruyRwk
APY3yi7BW3J0Ax1hHtqVXIXFZDLoqfFs4cHsN98q83Kb+Vcz7Joz0MQUgEyyS1gX
FRFWDqu4PH/6p7GLuoc7ifgypxWfd8GgrqrWZFq089Hglw2igEXpWWUmlHJ2T+dG
s22gSzCxHUIC4iogzFgj42FglgtYdzkCd7bDs4kBJFR9jpl6ydEr+WWQAWjRX+fO
NY9bFW+oy8+TyRVCDTSffoUo+8EJzon5iVrt1j7op1wBb6dhSFynWS6acyinXPz4
bgv0rRsXjXUV6n/rZP2TiO7Hw6QgYX1JRmDHvEbybakKAft9MdHh7OraUDqu4ajx
q6kwzjTG8U6ALieqG6ueCsTFXrnFnW2oJbyMSzgFt09OokIoxDAFK6FSPrJwkVc7
H58ZFU5VL4CWp+Y1x/Uh
=Q+4O
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to