Your message dated Sat, 9 Aug 2014 12:02:44 +0200
with message-id <[email protected]>
and subject line Re: Processed: reopening 429315, reassign 429315 to
mingw-w64-common
has caused the Debian Bug report #429315,
regarding /usr/i586-mingw32msvc/include/oaidl.h: Should include wtypes.h
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
429315: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=429315
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: mingw32-runtime
Version: 3.12-1
Severity: important
File: /usr/i586-mingw32msvc/include/oaidl.h
oaidl.h defines SF_TYPE like this:
typedef enum tagSF_TYPE {
SF_ERROR=VT_ERROR,
SF_I1=VT_I1,
SF_I2=VT_I2,
SF_I4=VT_I4,
SF_I8=VT_I8,
SF_BSTR=VT_BSTR,
SF_UNKNOWN=VT_UNKNOWN,
SF_DISPATCH=VT_DISPATCH,
SF_VARIANT=VT_VARIANT
}SF_TYPE;
The VT_* constants used here, such as VT_ERROR, come from wtypes.h . However,
oaidl.h does not include wtypes.h , and oleauto.h includes oaidl.h without
including wtypes.h . This results in compiler errors due to a missing
definition for VT_ERROR. Either oaidl.h should include wtypes.h, or oleauto.h
should include wtypes.h before including oaidl.h . I suggest the former, as I
prefer to have self-contained header files.
- Josh Triplett
-- System Information:
Debian Release: lenny/sid
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Kernel: Linux 2.6.22-rc1 (PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
mingw32-runtime depends on no packages.
Versions of packages mingw32-runtime recommends:
ii mingw32 3.4.5.20060117.1.dfsg-3 Minimalist GNU win32 (cross) compi
-- no debconf information
--- End Message ---
--- Begin Message ---
On Tue, 5 Aug 2014 09:52:53 -0700, Josh Triplett <[email protected]>
wrote:
> On Sun, Aug 03, 2014 at 07:17:36PM +0200, Stephen Kitt wrote:
> > On Fri, 01 Aug 2014 17:42:09 +0000, [email protected] (Debian Bug
> > Tracking System) wrote:
> > > > reopen 429315
> > > > # Still a bug
> >
> > I didn't close the mingw32-runtime bugs arbitrarily, I checked their
> > reproducibility beforehand. As far as I can see oaidl.h in mingw-w64 is
> > OK:
> >
> > % cat oaidl.c
> > #include <oaidl.h>
> >
> > int main(int argc, char **argv) {
> > return SF_VARIANT;
> > }
> >
> > % i686-w64-mingw32-gcc oaidl.c -o oaidl.exe
> >
> >
> > In fact running that through the preprocessor reveals that oaidl.h does
> > now include wtypes.h.
> >
> > As to your underlying bug, I believe oleauto.h isn't supposed to be
> > included without windows.h...
>
> IIRC, the code that originally motivated reporting this bug included
> oleauto.h without windows.h, and apparently worked fine on Windows.
If you ever come across this code again I'd like to see it! I tried building
the following using Visual Studio 2010 and it failed:
#include <oleauto.h>
int main(int argc, char **argv) {
return 0;
}
Including windows.h before oleauto.h allows the code to build.
> It does appear that oaidl.h includes wtypes.h indirectly now, but only
> by coincidence; windows.h doesn't directly include wtypes.h, only
> indirectly through other headers that include wtypes.h for the same
> reason oaidl.h should. In any case, however, this bug now seems much
> less urgent.
Indeed, wtypes.h is only included indirectly via windows.h which is itself
included by oaidl.h.
Anyway, I'll close this bug for now since the behaviour I'm seeing with
MinGW-w64 is the same as that I'm seeing with Visual Studio; feel free to
re-open it if you come across a counter-example.
Regards,
Stephen
signature.asc
Description: PGP signature
--- End Message ---
