Your message dated Mon, 11 Aug 2014 15:42:14 +0000 with message-id <[email protected]> and subject line Bug#657882: fixed in wmhdplop 0.9.9-3 has caused the Debian Bug report #657882, regarding gkrellm-hdplop: Fails to find any disk device after /run transition to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 657882: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=657882 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: gkrellm-hdplop Version: 0.9.9-2 Severity: normal Dear Maintainer, after the recent /run transition, which also finally turned /etc/mtab into a symlink to /proc/mounts, *hdplop (both incarnations) may fail to find a single disk device automatically. This is likely due to the root device now being exposed as mounted on /dev/disk/by-uuid/$UUID whereas the former /etc/mtab as written by mount still contained a device name as taken from /etc/fstab, which in my case could be parsed by *hdplop. It's unclear if this wouldn't have hit other environments earlier depending on their fstab contents, I just assume for now that I'm one of the remaining handful of users of this tool ;) The fundamental issue is of course the rather crude code in devnames.c's device_id_from_name() which tries to manually resolve device symlinks, but cannot possibly work with any symlink except those located directly in /dev - symlinks in subdirectories of /dev will fail. Impact on wmhdplop: Doesn't start except when called explicitely with some "-d /dev/sda" or such option. Impact on gkrellm-hdplop: Starts but is dazed and confused, leaving a black window in gkrellm. Clicking on the black window will then crash gkrellm, as it hits an assertion that the device list cannot be empty. I've prepared a small patch that makes *hdplop work again for me, the patch replaces the broken manual symlink resolving by a simple call to realpath(3), hopefully not breaking other stuff. I refrained from doing any more changes to the code, even though it looks like it needs some love. Upstream seems to have lost interest five years ago, though... So, without much further ado, here's my crude fix: --- devnames.c.orig 2012-01-29 16:06:50.540706883 +0100 +++ devnames.c 2012-01-29 16:04:28.729321785 +0100 @@ -186,9 +186,10 @@ if (lstat(devname,&stat_buf)) { BLAHBLAH(1,perror(devname)); return -1; } if (S_ISLNK(stat_buf.st_mode)) { - char lname[512]; - int n = readlink(devname, lname, 511); lname[n] = 0; - snprintf(devname,512,"/dev/%s",stripdev(lname)); + devname_ = realpath(devname, NULL); + if(!devname_) { BLAHBLAH(1,perror(devname)); return -1; } + strncpy(devname, devname_, 512); devname[511] = 0; + free(devname_); if (stat(devname,&stat_buf)) { BLAHBLAH(1,perror(devname)); return -1; } } if (!S_ISBLK(stat_buf.st_mode)) { Don't look too closely, specifically on the strncpy(3) stuff, but I felt this is still better than abusing snprintf(3) like the original code does some lines above, and as I said, starting to really fix things here looks like a bottomless pit... Thanks, Andre. -- System Information: Debian Release: wheezy/sid APT prefers testing APT policy: (500, 'testing') Architecture: i386 (i686) Kernel: Linux 3.1.10 (SMP w/4 CPU cores; PREEMPT) Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash Versions of packages gkrellm-hdplop depends on: ii libc6 2.13-24 ii libfreetype6 2.4.8-1 ii libice6 2:1.0.7-2 ii libimlib2 1.4.4-1+b1 ii libsm6 2:1.2.0-2 ii libx11-6 2:1.4.4-4 ii libxext6 2:1.3.0-3 ii zlib1g 1:1.2.3.4.dfsg-3 Versions of packages gkrellm-hdplop recommends: ii hddtemp <none> ii ttf-freefont 20100919-1 gkrellm-hdplop suggests no packages. -- no debconf information
--- End Message ---
--- Begin Message ---Source: wmhdplop Source-Version: 0.9.9-3 We believe that the bug you reported is fixed in the latest version of wmhdplop, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Doug Torrance <[email protected]> (supplier of updated wmhdplop package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Mon, 11 Aug 2014 01:19:01 -0500 Source: wmhdplop Binary: wmhdplop gkrellm-hdplop Architecture: source amd64 Version: 0.9.9-3 Distribution: unstable Urgency: medium Maintainer: Doug Torrance <[email protected]> Changed-By: Doug Torrance <[email protected]> Description: gkrellm-hdplop - hard drive activity monitor GKrellM plugin wmhdplop - hard drive activity monitor dockapp Closes: 657882 691823 738225 738259 Changes: wmhdplop (0.9.9-3) unstable; urgency=medium . * New maintainer (Closes: #691823). * debian/compat - Bump to 9. * debian/control - Bump to debhelper (>=9) in Build-Depends. - Bump Standards-Version to 3.9.5. - Change Recommends from ttf-freefont to fonts-freefont-ttf (Closes: #738225, #738259). - Expand long descriptions to differentiate wmhdplop and gkrellm-hdplop. - Remove (>= 20100122.1) from autotools-dev Build-Depends; no earlier version exists any more in Debian. * debian/copyright - Update to machine-readable format v1.0. * debian/dirs - Remove unneccessary file; directory is already created by dh_auto_install. * debian/rules - Simplify to use dh. * debian/patches/ldflags-to-ldadd.patch - Prevent undefined symbol error (LP: #995272). * debian/patches/find-disk-device.patch - Use realpath instead of symlink to find device (Closes: #657882). Checksums-Sha1: 92f02c5e5e944ffef93d65b6cfeec35b8d50cb3b 1846 wmhdplop_0.9.9-3.dsc 234384d8628912634fd45e71851ba9f4ed1548a1 232684 wmhdplop_0.9.9.orig.tar.gz da004c33b50e8f90779abe331e007a273bc05c36 5204 wmhdplop_0.9.9-3.debian.tar.xz a5d2dfa3ed4ddbc238322ae11a5d9d949bae1786 32302 wmhdplop_0.9.9-3_amd64.deb b09d6955ce587fe80e143c9b46c0243fe7336317 31392 gkrellm-hdplop_0.9.9-3_amd64.deb Checksums-Sha256: 89cee4a325844ed0cce00d2364dd3dbdd010abd9728cc5cc26087f59a1f01a4c 1846 wmhdplop_0.9.9-3.dsc 68f27918a8da4af2389544441eeee3a6fda3a875cd55603a3e04abedc1726553 232684 wmhdplop_0.9.9.orig.tar.gz 64a683d523cccd250013fe9d1d170ba29474ee76b8bd53ba42a483b2efca921f 5204 wmhdplop_0.9.9-3.debian.tar.xz c09649e753963523786e513ae0194eb4bb89481891135e6cbd0bcdf1b0c98a3a 32302 wmhdplop_0.9.9-3_amd64.deb 796529ade3f57ebb850828d09c35fd7f01062d822f71ba1f0a07c27bbcdfa69a 31392 gkrellm-hdplop_0.9.9-3_amd64.deb Files: 42f150d2d027e1a365f6a3ef8324b0db 32302 x11 optional wmhdplop_0.9.9-3_amd64.deb f5fd256a04175f2822c1602d9a4de426 31392 x11 optional gkrellm-hdplop_0.9.9-3_amd64.deb 56b5dfd052055513634a7f82c4207aaf 1846 x11 optional wmhdplop_0.9.9-3.dsc a64337205bc30faa45053965cc957b0e 232684 x11 optional wmhdplop_0.9.9.orig.tar.gz d5da0196a8db5caa64ca2c783d1e94c8 5204 x11 optional wmhdplop_0.9.9-3.debian.tar.xz -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCAAGBQJT6N+EAAoJEHQmOzf1tfkTOVwP/RSmqiUZxcb9W11X4kG+02Qs 4jYUrHkkXyfRMj0vs8uhenLTmnahhkAVEJ1EtIRgonCq7ofHupaQNg/Y4WrXp60+ ax48JIfN/5/FNkDTTZdxhi1qEhZJoexwhfups24ORpIrH1dZL3S5xKQoSGXlUw71 LMgRmOCfvaDbv8BPssrw2fuPmhe8r3VLLe/5g6G/S3MNvkondR0854/FPY2gGIo3 Yj10Oh9RUUPZXc3b7nUbuZLH2EyZxbO+zrO63WKrvCldRiSj39+sAFL5FX20HYw/ RaYbRGpFtOXZtSsd7byDOb6a8a+krsckhu4DOgQ0jG2r5iht0IbnyMPyxI8UOv13 BD99RzLgZvrLKz2P8OShf7dGkwKHB5I6jatSbo8fWlCFeBrMaJryyLXxY7AERs4e shAkOXonAP1r3oDMqXmHe+yDoPphXXIw4GS8kWrkm4zNX9tk+FOb6DpcCbTdQ/9x MDiEINa1JqoQbWqexnoTgoriHvutNw7yIJuku2MzGh0gbaqc65JJK5H7J18W+F5I WIB4D153gc2aoiTq832fq7RSbVh4HJMUdNI1cYY6m/cwvTGzZe//ADk+HU8h2vw5 XlnvRFElvk27pVcaPVpbzIuzVi2ZTUrCLgHztvvj/9kE7aTGLZxGCD3SAIFFATFY hXtxTE4XUuNM4HDfzOhz =8oUk -----END PGP SIGNATURE-----
--- End Message ---
