Your message dated Wed, 27 Aug 2014 09:21:22 +0000
with message-id <[email protected]>
and subject line Bug#754792: fixed in libbfio 20140105-2
has caused the Debian Bug report #754792,
regarding libbfio: FTBFS on hurd-386
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
754792: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=754792
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: libbfio
Version: 20130507-1
Severity: important
Tags: patch
User: [email protected]
Usertags: hurd
Hello,
libbfio fails to build from source due to usage of PATH_MAX,which is not
defined on GNU/Hurd. The attached patch fixes usage of PATH_MAX as
second argument to getcwd() by using calls to getcwd (NULL, 0) instead.
Supporting (NULL, 0) as arguments is an extension to POSIX.1-2001 for
libc4, libc5 and glibc, so most modern systems have it. In order to
simplify the patch, only this version is implemented.
In case there is a need for a dual code path this can be fixed to, at
the cost of additional #ifdef's in the code and a configure.ac check for
the getcwd (NULL, 0) functionality.
Note also that with the patch applied, the package needs to build-depend
on quilt.
The failure of this package to build blocks the build of e.g. libewf,
libpff and dff, and libewf is flagged as out-of-date since a long time
by now for Hurd.
Thanks!
Index: libbfio-20130507/libcpath/libcpath_path.c
===================================================================
--- libbfio-20130507.orig/libcpath/libcpath_path.c
+++ libbfio-20130507/libcpath/libcpath_path.c
@@ -356,9 +356,6 @@ int libcpath_path_get_current_working_di
}
#if defined( WINAPI )
*current_working_directory_size = (size_t) _MAX_PATH;
-#else
- *current_working_directory_size = (size_t) PATH_MAX;
-#endif
*current_working_directory = libcstring_narrow_string_allocate(
*current_working_directory_size );
@@ -387,7 +384,6 @@ int libcpath_path_get_current_working_di
goto on_error;
}
-#if defined( WINAPI )
if( _getcwd(
*current_working_directory,
*current_working_directory_size ) == NULL )
@@ -403,9 +399,8 @@ int libcpath_path_get_current_working_di
goto on_error;
}
#else
- if( getcwd(
- *current_working_directory,
- *current_working_directory_size ) == NULL )
+ *current_working_directory = getcwd (NULL, 0);
+ if( current_working_directory == NULL )
{
libcerror_system_set_error(
error,
@@ -417,6 +412,8 @@ int libcpath_path_get_current_working_di
goto on_error;
}
+ *current_working_directory_size = 1 + libcstring_narrow_string_length(
+ *current_working_directory );
#endif
return( 1 );
@@ -3113,9 +3110,7 @@ int libcpath_path_get_current_working_di
#if defined( WINAPI )
*current_working_directory_size = (size_t) _MAX_PATH;
#else
- narrow_current_working_directory = libcstring_narrow_string_allocate(
- PATH_MAX );
-
+ narrow_current_working_directory = getcwd (NULL, 0);
if( narrow_current_working_directory == NULL )
{
libcerror_error_set(
@@ -3126,20 +3121,6 @@ int libcpath_path_get_current_working_di
function );
goto on_error;
- }
- if( getcwd(
- narrow_current_working_directory,
- PATH_MAX ) == NULL )
- {
- libcerror_system_set_error(
- error,
- LIBCERROR_ERROR_DOMAIN_RUNTIME,
- LIBCERROR_RUNTIME_ERROR_GET_FAILED,
- errno,
- "%s: unable to retrieve current working directory.",
- function );
-
- goto on_error;
}
narrow_current_working_directory_size = 1 + libcstring_narrow_string_length(
narrow_current_working_directory );
--- End Message ---
--- Begin Message ---
Source: libbfio
Source-Version: 20140105-2
We believe that the bug you reported is fixed in the latest version of
libbfio, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Pierre Chifflier <[email protected]> (supplier of updated libbfio package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Wed, 27 Aug 2014 09:04:21 +0200
Source: libbfio
Binary: libbfio-dev libbfio-dbg libbfio1
Architecture: source amd64
Version: 20140105-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Forensics <[email protected]>
Changed-By: Pierre Chifflier <[email protected]>
Description:
libbfio-dbg - Library to provide basic input/output abstraction (debug)
libbfio-dev - Header files and libraries for developing applications for libbfi
libbfio1 - Library to provide basic input/output abstraction
Closes: 754792
Changes:
libbfio (20140105-2) unstable; urgency=medium
.
* Fix FTBFS on hurd-386 (Closes: #754792)
Thanks to Svante Signell for the patch.
Checksums-Sha1:
70f19eaec005a6a446e29d5538a1e7577179440c 1690 libbfio_20140105-2.dsc
a7341e7fc7bf8e82af6058ba9d95c1c2b1090602 6136 libbfio_20140105-2.debian.tar.xz
85fee7fb18027a5ba79b71a13bdecd456cf30e50 592500
libbfio-dev_20140105-2_amd64.deb
7c7cdd580e997bf2f31a765eb27e2913aa215307 283282
libbfio-dbg_20140105-2_amd64.deb
68f71995101f13cb8e67c6de9a5f26692df72f64 314304 libbfio1_20140105-2_amd64.deb
Checksums-Sha256:
0670483f85165bb167cc20a836ae63b89fe1691de99a457bf5b03e9127600d00 1690
libbfio_20140105-2.dsc
8f1cd386834515e3db25b2bc2d2316c9dc69cccf78bb4234c89deb9977583dd0 6136
libbfio_20140105-2.debian.tar.xz
02ae7ddb907882567f04367f3b9c8d7deb558b907b0c52355ec5be1a51c24db5 592500
libbfio-dev_20140105-2_amd64.deb
4458e33d42cbb59c72057f4e4ee257744b61356fde9488e9b2f4763e553be85a 283282
libbfio-dbg_20140105-2_amd64.deb
b3455f25407adbf952e3ca5cfc4bed49597a962d713f6c441aa42ea3b8ce2f4e 314304
libbfio1_20140105-2_amd64.deb
Files:
f7e373bc1892cc352ad6d5ce6cfcc3f9 592500 libdevel optional
libbfio-dev_20140105-2_amd64.deb
3a1be7a0481c980028969fc9f46c9fbe 283282 debug extra
libbfio-dbg_20140105-2_amd64.deb
4715a3f394100e180cc30bdf85272f74 314304 libs optional
libbfio1_20140105-2_amd64.deb
7948bf792970c26b5bc58cf823a14b6c 1690 libs optional libbfio_20140105-2.dsc
5a7b3a835abb9f2dfa36dbcec2b471c0 6136 libs optional
libbfio_20140105-2.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQEcBAEBAgAGBQJT/YwnAAoJEFqCeQfe0MQYSSQIAMN2XdPNjf3ViClUHO2pz1IY
gMLyc4qHhB5czi/8TL1sqBuEEBICEZKHiKsDvg+7ATiNLcrv5ercE1ssmsy3ay8c
eaDaQKVZUlsRWVFl81QZj3Ffti/hZtYgzc/wR9dJbrCa+wZcysrsr5+yumd6Rogp
q4/HGQyOeNV/QEt5VddMUqX39xoKbHMY/S4W+PFSv3B3b/nK4IUOPlWlYCXXK8g7
GQ2G6BOHWsYnGXR3Ob+RJvdmMU0cGIFqA/3HWl1Y0/jRA5Frc1uZNofmH5o76OTN
5QrYR9wcNwV+FPEocstenI6O6CSOVgatYgnFyPyuE6EbFPjGpSlh3HdjQzqo11Q=
=R6p/
-----END PGP SIGNATURE-----
--- End Message ---
