Your message dated Thu, 11 Sep 2014 01:48:50 +0000
with message-id <[email protected]>
and subject line Bug#693430: fixed in gitg 3.13.91-1
has caused the Debian Bug report #693430,
regarding gitg: off-by-one in line numbering of diff in "Changes" tab
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
693430: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=693430
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: gitg
Version: 0.2.4-1.1
Severity: minor

A typical content of the "Changes" tab looks like this in ascii art:

      diff --git a/foo b/foo
      index abcde..12345 100644
3  5  @@ -3,8 +5,7 @@ context
4  6   common context
5  7   common context
6      common context
7     -line only in a/foo
   8  -line only in a/foo
8  9  +line only in b/foo
9  10 common context
10 11 common context
11 12 common context
12 13

Please observe how the @@ line is already numbered. It should have no
numbers instead. As a consequence the last "common context" line is
numbered as the first deleted line.

Also notice how there is an empty line numbered. This seems like a wrong
fix to the wrong numbering.

The corresponding code is in gitg-diff-view.c function ensure_scan, but
I have no idea how to fix this.

Helmut

--- End Message ---
--- Begin Message ---
Source: gitg
Source-Version: 3.13.91-1

We believe that the bug you reported is fixed in the latest version of
gitg, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dmitry Smirnov <[email protected]> (supplier of updated gitg package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 11 Sep 2014 11:43:39 +1000
Source: gitg
Binary: gitg
Architecture: source amd64
Version: 3.13.91-1
Distribution: experimental
Urgency: low
Maintainer: Dmitry Smirnov <[email protected]>
Changed-By: Dmitry Smirnov <[email protected]>
Description:
 gitg       - git repository viewer
Closes: 693430 740423
Changes:
 gitg (3.13.91-1) experimental; urgency=low
 .
   * New major upstream release [August 2014] (Closes: #740423).
     + fixed "diff off-by-one line numbering" (Closes: #693430).
   * Build-Depends:
     + gobject-introspection
     + libgee-0.8-dev
     + libgit2-dev
     + libgit2-glib-1.0-dev (>= 0.0.20)
     + libgtkspell3-3-dev
     + libjson-glib-dev
     + libpeas-dev
     + libwebkit2gtk-3.0-dev
     + valac
     + libxml2-utils
   * Added "debian/missing-sources" with uncompressed "jquery-2.0.3.js".
Checksums-Sha1:
 97b09140f7cc8ee36b92f85106d498834a28f163 2176 gitg_3.13.91-1.dsc
 9ba1852be6d75bca10de7394ec1a931815c3b2d2 1173596 gitg_3.13.91.orig.tar.xz
 3fa406e1196af81bc7f0bfc26c86d2caf7f27be7 68244 gitg_3.13.91-1.debian.tar.xz
 996238c8ab1e871565c607e56af0eb7cd1237d27 430032 gitg_3.13.91-1_amd64.deb
Checksums-Sha256:
 274df94bcc622f619bc536729079aeba47a0f25c7b3358ebaafa49f3b531961d 2176 
gitg_3.13.91-1.dsc
 67ec4c1281024e63df36f9e74554609aae5cd0672acf5ee870e5bd9d9f0940b0 1173596 
gitg_3.13.91.orig.tar.xz
 66625d1391cdc38e8e11f09755f065820f10d6afab775ab6025d792c5c149aa7 68244 
gitg_3.13.91-1.debian.tar.xz
 878927d31277fa4cc5da81ee0bbcf04162d7401668940820108e70c22547c65c 430032 
gitg_3.13.91-1_amd64.deb
Files:
 96617398dcef67255d32dc571e043ed3 430032 vcs optional gitg_3.13.91-1_amd64.deb
 8d6c6b4a6e7bc848b43574f8932fb97c 2176 vcs optional gitg_3.13.91-1.dsc
 203f5841923968f4c965b747a905713d 1173596 vcs optional gitg_3.13.91.orig.tar.xz
 5fce6915604940f2e5d03ace876eb8be 68244 vcs optional 
gitg_3.13.91-1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJUEP7KAAoJEFK2u9lTlo0bJGgQAMKYqP2ElGYioHEmV5muPZHY
I5bUSrEsjel//T7OBcYQUHhGMkgCJKk2EvU1rAsxuJx7P3LGOwquU4ZcHTMGXaH/
/dUCflOXSrlPrWtUmZj0DfqA85vkwEnaT/ebpWQ6aSW+Ut5baloOmGWyQReCcehk
/C5HUE8IhIIsW/YGxxFEePuM4CzN5UPYpyikNOoGQ3nj3EkNcRg/889tczbfk6iX
0F2cfaID/hJ4KkwIZklmDE0T7P+gXQCuYIlGIiohiLkV6nuK0o/uL1/zQTOjzEyH
ZguOqTcF3fV/O7A/4pQHrZCY8VyO4Jb78WXhGW7sxm3SFCyWd8xBanNM3coF+Ze/
5IcPndvbMcoXcdIPsXl1eQ30jJleTvAVzDkqHq21ewHISYnsLhg8bL6O+2SORlvq
Hq8qWL69ezUU2sPd8LAEeS/wMNtGwxeaByemjex2xC4wIYo7cB7osySKCgRfjEQQ
/jLoxbcOzKZ3tmb1LQhbPX7InvGJtuJHpxgbzRQPyKwnU/tp2APBWfo/UUpXX2E7
oChiJDDQlE4XyDJfVaEONsXgI1MgKqJWmHlPwoi9QioltWx1FvOL/uWSr+9APcY5
XUIaJHadMjw9PSLSVX4aFb7kLGKNBveyl5AJDCkx3Y8BhIJwwBvWqh2UjY48Aw+V
NrlwwpDoOyLrDoZGaOnA
=HRvC
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to