Your message dated Wed, 24 Sep 2014 21:22:13 +0000
with message-id <[email protected]>
and subject line Bug#750952: fixed in netselect 0.3.ds1-26
has caused the Debian Bug report #750952,
regarding netselect-apt: netselect choose inexistant mirrors - (dash)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
750952: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=750952
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: netselect-apt
Version: 0.3.ds1-25
Severity: critical
Tags: patch
Justification: breaks the whole system



-- System Information:
Debian Release: 7.5
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-4-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages netselect-apt depends on:
ii  netselect  0.3.ds1-25
ii  wget       1.13.4-3+deb7u1

Versions of packages netselect-apt recommends:
ii  curl  7.26.0-1+wheezy9

Versions of packages netselect-apt suggests:
ii  dpkg-dev  1.16.14

-- no debconf information

When the script enters final phase for an unknown reason it tries a mirror host 
-
Apparently this cause curl to interpret the hostname as an option and return 
immediatly.
# Debian packages for stable
deb - stable main contrib non-free
# Uncomment the deb-src line if you want 'apt-get source'
# to work with most packages.
deb-src - stable main contrib non-free


To address the issue I have add 2 tests and corrected one that
I think was wrong inside the test_host function:
--- x   2014-06-08 22:50:28.628202003 +0200
+++ /usr/bin/netselect-apt      2014-06-08 22:50:41.068091221 +0200
@@ -111,7 +111,9 @@
 {
     local host="$1"
     local rv=0
-    [ ! -x /usr/bin/curl  ] && return 0
+    [ ! -x /usr/bin/curl  ] && return 255
+    [[ "@${host:0:1}" == "@-" ]] && return 255
+    [[ -z "${host}" ]] && return 255
 
     # First test: does it actually serve anything?
     curl -m 2 -q -s "$host"  >/dev/null 2>&1


The return -1 on the calling function validate_host seems not good either, 
generates return: -1: invalid option
Probably need to be changed to return 255

--- End Message ---
--- Begin Message ---
Source: netselect
Source-Version: 0.3.ds1-26

We believe that the bug you reported is fixed in the latest version of
netselect, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Javier Fernández-Sanguino Peña <[email protected]> (supplier of updated netselect 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 23 Sep 2014 20:30:12 +0200
Source: netselect
Binary: netselect netselect-apt
Architecture: source all i386
Version: 0.3.ds1-26
Distribution: unstable
Urgency: medium
Maintainer: Javier Fernández-Sanguino Peña <[email protected]>
Changed-By: Javier Fernández-Sanguino Peña <[email protected]>
Description: 
 netselect  - speed tester for choosing a fast network server
 netselect-apt - speed tester for choosing a fast Debian mirror
Closes: 713838 750952
Changes: 
 netselect (0.3.ds1-26) unstable; urgency=medium
 .
   * netselect-apt: Apply patch provided by Ben Wong in order to
     fix some bugs
      - Add 'jessie' to netselect to make it possible to search mirrors
        of that codename (Closes: #713838)
      - Ignore corrupted results (negative score) and throw them out.
        Netselect does not handle gracefully mirrors which use
        a Round Robin DNS (see bug #755238).
        The fix prevents netselect-apt from selecting mirrors with a '-'
        in some cases (Closes: #750952)
      - Return with an error in test_host if curl is not available or
        if an empty host is provided (as suggested by doekia in #750952)
Checksums-Sha1: 
 9a49d6ec5dfe50aa6b7d7048d694282a211b86ac 1950 netselect_0.3.ds1-26.dsc
 f931f794c0f5a3e953e26b4014044746f877f946 39148 netselect_0.3.ds1-26.diff.gz
 c5553332c252716528133de1ceb9e87db3d44dc7 17066 netselect-apt_0.3.ds1-26_all.deb
 9ca3cbaae74b515f4e827575c2dfb33a88219518 31240 netselect_0.3.ds1-26_i386.deb
Checksums-Sha256: 
 49f424e9594f4b20e55fb917449263aac6da49db2439d05d214deb891b5036f9 1950 
netselect_0.3.ds1-26.dsc
 52b32c231ec5a18b75b4d09491baacef04b2a296cfda256c276b3d1906ff0e5d 39148 
netselect_0.3.ds1-26.diff.gz
 eaf9f9cb2282ab57d6fe2ddeb2a4b67915acbf5f5ab21881dc382b26ff47ba7e 17066 
netselect-apt_0.3.ds1-26_all.deb
 293019996efae2a62757b583ccf2c3fa6332a8a01cfba50e895972fcdc2389b0 31240 
netselect_0.3.ds1-26_i386.deb
Files: 
 b7e1c61a3f80d74b03c59192da5ee66e 17066 net optional 
netselect-apt_0.3.ds1-26_all.deb
 7e625d01be00bfe0734ab35c997f84ca 31240 net optional 
netselect_0.3.ds1-26_i386.deb
 131a26e3cf84a0beb6b09270dc39ac99 1950 net optional netselect_0.3.ds1-26.dsc
 6a0e03c0a3e39130673ca68e1238febe 39148 net optional 
netselect_0.3.ds1-26.diff.gz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIVAwUBVCMw2zg8os7RvajdAQhFWw//TFfRMtaDDIyJ/IMhNaFYyPHxPm+15KhY
xiA2q0a27OCT6ihtvY6Vd3BOGRQyDeDwaG667qtYWi05cyTp4KPpYvm25Os0E/Ey
WYSc+XtCYl2ypRE0lbR0ak2+0+VA6+VlIVw3ElTVypwRGUAfB7oElMJcTqjy5hdx
oEpX7AoNjDxFKE/7lLaxue85PFLHE+K8mApUCAXt/3SAhu3n7Hn8GX15wsm/bGcs
RtDWO5N4egz3Etu7CyQfJ06xeO1PaO25q7QFGtMhNVZtB2QVNpgGtPeFoFhjiBnb
w7OudpYXYPWIeoof/pPFyIbVAx1GKapwYWcFQoz8JdmfxtweCHO4JtCOk0GcSUJ5
irBROx3s/VjDNVpxq9a3iTPR+eoVBtM3Fd7/OoOjkkRrf4VfDOQKgnDo9kH7pOGp
JlrzyHqqGdXdTAQknF9Jv7oIYJatU+XCauLLHjG7BTsdOeDy0tWIapuP02s+es2T
flZThfkY+ylQfeTmQJN40jpx/fzKEOh/G0+272zpJwDHsbAQOyOk1UF0r8pzO/FA
6tqyY5lUsZYJ62jPDLB/TU2FVLKdbCa1j9YTKnIETlsAGE9YKpH/lkzK+ea0IRhC
V4I7T62J+vNjcp2AAHfoyW6yc/DnHZkBKiO3W9GOYYjq6A/Qh57zC7asAXbLpNwu
9PjywdVczzM=
=Eo2f
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to