Your message dated Wed, 08 Oct 2014 12:34:33 +0000
with message-id <[email protected]>
and subject line Bug#762608: fixed in haproxy 1.5.5-1
has caused the Debian Bug report #762608,
regarding haproxy: service haproxy stop returns 4 if haproxy was already not
running.
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
762608: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=762608
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: haproxy
Version: 1.5.4-1
Severity: normal
Tags: patch
User: [email protected]
Usertags: origin-ubuntu utopic ubuntu-patch
Dear Maintainer,
pacemaker was running haproxy. haproxy was killed by oom. pacemaker
tries to stop then start haproxy, but fails because stop failed with 4
rather than exiting with 0. Since haproxy was in fact stopped after
the 'service haproxy stop' call, 0 should be returned rather than 4
(by my reading of http://www.debian.org/doc/debian-policy/ch-opersys.html)
*** /tmp/tmpykD9sX/bug_body
In Ubuntu, the attached patch was applied to achieve the following:
* haproxy.init: return 0 on stop if haproxy was not running. (LP: #1038139)
Thanks for considering the patch.
-- System Information:
Debian Release: jessie/sid
APT prefers utopic-updates
APT policy: (500, 'utopic-updates'), (500, 'utopic-security'), (500,
'utopic'), (100, 'utopic-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.16.0-16-generic (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Description: check whether haproxy is running before killing it
If 'service haproxy stop' is called when haproxy is already not
running, then stop currently returns 4. This patch will make it
return 0, since 'stop' had the expected end result (haproxy is stopped)
Author: ariel-cafelug
Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/haproxy/+bug/1038139
diff -Nru haproxy-1.5.4/debian/haproxy.init haproxy-1.5.4/debian/haproxy.init
--- haproxy-1.5.4/debian/haproxy.init 2014-09-02 12:26:00.000000000 -0500
+++ haproxy-1.5.4/debian/haproxy.init 2014-09-23 12:06:14.000000000 -0500
@@ -60,7 +60,9 @@
return 0
fi
for pid in $(cat $PIDFILE) ; do
- /bin/kill $pid || return 4
+ if kill -0 $pid 2>/dev/null; then
+ /bin/kill $pid || return 4
+ fi
done
rm -f $PIDFILE
return 0
--- End Message ---
--- Begin Message ---
Source: haproxy
Source-Version: 1.5.5-1
We believe that the bug you reported is fixed in the latest version of
haproxy, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Apollon Oikonomopoulos <[email protected]> (supplier of updated haproxy
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Wed, 08 Oct 2014 12:34:53 +0300
Source: haproxy
Binary: haproxy haproxy-dbg haproxy-doc vim-haproxy
Architecture: source amd64 all
Version: 1.5.5-1
Distribution: unstable
Urgency: medium
Maintainer: Debian HAProxy Maintainers
<[email protected]>
Changed-By: Apollon Oikonomopoulos <[email protected]>
Description:
haproxy - fast and reliable load balancing reverse proxy
haproxy-dbg - fast and reliable load balancing reverse proxy (debug symbols)
haproxy-doc - fast and reliable load balancing reverse proxy (HTML documentatio
vim-haproxy - syntax highlighting for HAProxy configuration files
Closes: 762608
Changes:
haproxy (1.5.5-1) unstable; urgency=medium
.
[ Vincent Bernat ]
* initscript: use start-stop-daemon to reliably terminate all haproxy
processes. Also treat stopping a non-running haproxy as success.
(Closes: #762608, LP: #1038139)
.
[ Apollon Oikonomopoulos ]
* New upstream stable release including the following fixes:
+ DOC: Address issue where documentation is excluded due to a gitignore
rule.
+ MEDIUM: Improve signal handling in systemd wrapper.
+ BUG/MINOR: config: don't propagate process binding for dynamic
use_backend
+ MINOR: Also accept SIGHUP/SIGTERM in systemd-wrapper
+ DOC: clearly state that the "show sess" output format is not fixed
+ MINOR: stats: fix minor typo fix in stats_dump_errors_to_buffer()
+ DOC: indicate in the doc that track-sc* can wait if data are missing
+ MEDIUM: http: enable header manipulation for 101 responses
+ BUG/MEDIUM: config: propagate frontend to backend process binding again.
+ MEDIUM: config: properly propagate process binding between proxies
+ MEDIUM: config: make the frontends automatically bind to the listeners'
processes
+ MEDIUM: config: compute the exact bind-process before listener's
maxaccept
+ MEDIUM: config: only warn if stats are attached to multi-process bind
directives
+ MEDIUM: config: report it when tcp-request rules are misplaced
+ MINOR: config: detect the case where a tcp-request content rule has no
inspect-delay
+ MEDIUM: systemd-wrapper: support multiple executable versions and names
+ BUG/MEDIUM: remove debugging code from systemd-wrapper
+ BUG/MEDIUM: http: adjust close mode when switching to backend
+ BUG/MINOR: config: don't propagate process binding on fatal errors.
+ BUG/MEDIUM: check: rule-less tcp-check must detect connect failures
+ BUG/MINOR: tcp-check: report the correct failed step in the status
+ DOC: indicate that weight zero is reported as DRAIN
* Add a new patch (haproxy.service-set-killmode-to-mixed.patch) to fix the
systemctl stop action conflicting with the systemd wrapper now catching
SIGTERM.
* Bump standards to 3.9.6; no changes needed.
* haproxy-doc: link to tracker.debian.org instead of packages.qa.debian.org.
* d/copyright: move debian/dconv/* paragraph after debian/*, so that it
actually matches the files it is supposed to.
Checksums-Sha1:
1eb83abec693236f024d48aa0a686cde59bdc447 2224 haproxy_1.5.5-1.dsc
052a2e202336564a73d8d4c44443ac19cc165f12 1337461 haproxy_1.5.5.orig.tar.gz
1948cb98c00a608ad2c0f09c99ea7832de51a5ec 35248 haproxy_1.5.5-1.debian.tar.xz
d601790ea44e2f060f2ec38544924f155171545a 638650 haproxy_1.5.5-1_amd64.deb
9c6a475a12c9b0275cc5dad0a3432beec81d97ce 1667644 haproxy-dbg_1.5.5-1_amd64.deb
5289802834c7920691e543235a6dedb0cdf9a189 265410 haproxy-doc_1.5.5-1_all.deb
9508e4efaf774d62108d38b715cc22415cc119e2 98926 vim-haproxy_1.5.5-1_all.deb
Checksums-Sha256:
bee2ea4b6c725c72d748539e060f8ead6976d4d6bc4eb01840d2fcdc11993487 2224
haproxy_1.5.5-1.dsc
e8d014e99a025e7d7878d402d30e03666c6d205c630a0b3c25f53a09fff4827c 1337461
haproxy_1.5.5.orig.tar.gz
747a1ece573fc27272c16e79292abb7c8d746753c62dab833215f4de76852dd2 35248
haproxy_1.5.5-1.debian.tar.xz
3931aec475a6d703943520004c148cb9ea59e8ff7ece6b3db2b0c548e41901b2 638650
haproxy_1.5.5-1_amd64.deb
3e89482e8e4c2a8af38ee7f35702c1d5221eaa8a43f0bcd09ee9df2621d6de86 1667644
haproxy-dbg_1.5.5-1_amd64.deb
48580bfcd54fe8b6f84aa778412f5959487f69d5030e102ebcb29eded0ca3ab5 265410
haproxy-doc_1.5.5-1_all.deb
8fa1da2bc332ef8a71af78a66398769585c1f824ea90ca4dd06e6f88ca31bad9 98926
vim-haproxy_1.5.5-1_all.deb
Files:
c23833448a03d9b18b531d87825a168e 638650 net optional haproxy_1.5.5-1_amd64.deb
8a3edbed43264392d103700a5c8e2964 1667644 debug extra
haproxy-dbg_1.5.5-1_amd64.deb
ed5a1e76c8350fb10b0c7551875306c4 265410 doc extra haproxy-doc_1.5.5-1_all.deb
4178b4c24a2767ea18f3e1f160663ba0 98926 net optional vim-haproxy_1.5.5-1_all.deb
86bfb9cbd9555fb5a6118e0a76b0ba9e 2224 net optional haproxy_1.5.5-1.dsc
952e4c2057d763a3fb74173a81028be5 1337461 net optional haproxy_1.5.5.orig.tar.gz
ed94d538494c28e20485be4491b15b15 35248 net optional
haproxy_1.5.5-1.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCAAGBQJUNSWcAAoJEHLTQsHpUUMGmEwP/RuavzAN2sSE1DrlcCqkxQdZ
VtZjgsEg21eshYzkBCymqbjro9c19nhphcfEJ9vg7gh5uhIT8DiRO7i/HnWiMYj2
OnN4mOiR+iRz8zo1H9zL+jAeaq1TULKOsAILNKK8BqNZOjp7M4xwnez0dnxgRlFt
80kCq58Rn86fZmKEfOmRcJg12TzDFlKPr2AjEFFDRnFoJ51wTtv9LjJnY4aTV1n3
88xs9faIcNwa6+RnyJ56bI8JloTUjEONEdwbcGn+JbH8k/w38aR/FE5GdorR3SnQ
csToI0UNAZ9NnntDYBMMwRS889gWMDKSIviqtehfEjqnXEJXwmqxrXqqTQg9sPi/
lmbs/pLIJFdnvtLJ5BCycyDbiBbFMjMz6xpjMPzvnVZM2rNkdbSpNJymq3oQy1jE
f3nkzi+NjTbgvH7fxbeKixNYHUn29pviQySkBDMSDr4rCH4s5voHUpMksdCoIPfk
rPb4Thz8yy4VCJjkz+0GIxCel32UGDPmX6z5Y3OA8iL450R4uNi4Ab2eWEUAnrLH
Dy+c0LDaxj2Ra/eB3qd9Jam/yBSSi8VOBeRQa8IE+2Kf0GYCOfDumDJs78pJeoVI
j1ODRSSV+RtPVdO4VLMgAI0b+vlv5YZVr/mhQIkn+lIq4J5Dv9vrjGGKdowsl1iO
6xNxcOY7BTS+mm0jKSCD
=M117
-----END PGP SIGNATURE-----
--- End Message ---
