Your message dated Wed, 08 Oct 2014 21:20:19 +0000
with message-id <[email protected]>
and subject line Bug#756127: fixed in kexec-tools 1:2.0.7-2
has caused the Debian Bug report #756127,
regarding kexec-tools: kexec --load fails: "Base address: $address is not page 
aligned"
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
756127: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=756127
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: kexec-tools
Version: 1:2.0.4-1
Severity: normal
Tags: patch

Dear Maintainer,

One of those bugs that make me wonder why nobody else came across
them. Severity left to normal although it's a grave functionality bug
but it might be caused by some of the non-Debian components on my
system.

This is a Raspberry Pi, running Debian wheezy in the armel
architecture, on a home-brew 3.10.x vmlinux kernel (the fork provided
by the Raspberry folks), and also a home-brew initrd. Now trying out
an 3.14 vanilla kernel using a DTB I tried kexec from jessie for
the --dtb option, but when using --load I instead got:

    Base address: cffea0 is not page aligned

Digging around in the code revealed initrd_base is simply computed
from the kernel image size without asserting any page alignment. The
patch below fixes this for that specific use case and resulted in
successful reboot using a 3.10 kernel while 3.14 fails, for reasons
that are very likely are outside kexec's domain.

Please review carefully, perhaps with the help of people who have more
understanding of the code than I do. Also other architectures should
be checked whether the same issue exists there, too. At a first
glance it seems they are not affected but I might be wrong.

    Christoph

-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: armel (armv7l)

Kernel: Linux 3.10.49 (SMP w/4 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash


diff --git a/kexec/arch/arm/kexec-zImage-arm.c 
b/kexec/arch/arm/kexec-zImage-arm.c
index dd2e06f..c5e78e1 100644
--- a/kexec/arch/arm/kexec-zImage-arm.c
+++ b/kexec/arch/arm/kexec-zImage-arm.c
@@ -343,7 +343,7 @@ int zImage_arm_load(int argc, char **argv, const char *buf, 
off_t len,
        /* assume the maximum kernel compression ratio is 4,
         * and just to be safe, place ramdisk after that
         */
-       initrd_base = base + len * 4;
+       initrd_base = _ALIGN_UP(base + len * 4, getpagesize());
 
        if (use_atags) {
                /*

Attachment: signature.asc
Description: Digital signature


--- End Message ---
--- Begin Message ---
Source: kexec-tools
Source-Version: 1:2.0.7-2

We believe that the bug you reported is fixed in the latest version of
kexec-tools, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Khalid Aziz <[email protected]> (supplier of updated kexec-tools package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Wed, 08 Oct 2014 11:01:58 -0600
Source: kexec-tools
Binary: kexec-tools kexec-tools-udeb
Architecture: source amd64
Version: 1:2.0.7-2
Distribution: unstable
Urgency: medium
Maintainer: Khalid Aziz <[email protected]>
Changed-By: Khalid Aziz <[email protected]>
Description:
 kexec-tools - tools to support fast kexec reboots
 kexec-tools-udeb - tools to support fast kexec reboots (udeb) (udeb)
Closes: 699008 729451 734697 747119 754609 756127 757510 764360
Changes:
 kexec-tools (1:2.0.7-2) unstable; urgency=medium
 .
   * Fix build failure on ppc (closes: Bug#754609)
   * Replaced s390 arch with s390x (closes: Bug#729451)
   * Added patch from Roland to support powerpcspe (closes: Bug#734697)
   * Added support for systemd (closes: Bug#764360, closes: Bug#699008)
   * Enhanced kexec init scripts to work with systemd as well and now
     "sudo reboot" from an X11 terminal works (closes: Bug#747119)
   * Includes upstream fix to align initrd_base address to pagesize
     (closes: Bug#756127)
   * Added Turkish translation (closes: Bug#757510)
Checksums-Sha1:
 c089457998a0fc6948ab6920b96e6c087d940c92 1468 kexec-tools_2.0.7-2.dsc
 f3143c33a1446eaa4c6c9143243a23ffd539ee8f 19740 
kexec-tools_2.0.7-2.debian.tar.xz
 cc8ee228fbe9611b380374dfc7c319c3ac4c41c8 80002 kexec-tools_2.0.7-2_amd64.deb
 2a89652d20cfa776856d8cd7c6058da64636ca44 52002 
kexec-tools-udeb_2.0.7-2_amd64.udeb
Checksums-Sha256:
 dce81d5f2988b444894edd332406bebaa1ebaea85780188b12d2161cd2651d8b 1468 
kexec-tools_2.0.7-2.dsc
 8ac249575288e2575b508ad640ee05c40d5898e2ff7e8ee0b57ffb1523a6bbbd 19740 
kexec-tools_2.0.7-2.debian.tar.xz
 e0dcb95401acc65945b6024c575eb4a8e4d3305a28cb98e6753a9a0ab19447a4 80002 
kexec-tools_2.0.7-2_amd64.deb
 f3d0a5344e580ef6755e2338d75004628ccd4dce1514d79a2ed8398508afe3fc 52002 
kexec-tools-udeb_2.0.7-2_amd64.udeb
Files:
 99392378a10e6fe1804483ed559dd3ae 1468 admin optional kexec-tools_2.0.7-2.dsc
 986ad08eea6ffa88d98a8eb85114be72 19740 admin optional 
kexec-tools_2.0.7-2.debian.tar.xz
 993ac34aad596ad4ed328ccdad9bc1df 80002 admin optional 
kexec-tools_2.0.7-2_amd64.deb
 1802d6bf3955bbc89c34a84fed6697f0 52002 debian-installer optional 
kexec-tools-udeb_2.0.7-2_amd64.udeb
Package-Type: udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlQ1lC4ACgkQlQEY26iVtiGBCwCfcHaCnem5RXw6KYrVl23zioiO
g0UAn1TwPkPYBES346ee26vHryXfbOEQ
=f4Jx
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to