Your message dated Thu, 09 Oct 2014 09:26:47 +0000
with message-id <[email protected]>
and subject line Bug#764508: fixed in virt-manager 1:1.0.1-2.1
has caused the Debian Bug report #764508,
regarding virt-manager: Flagging a USB device as removable fails
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
764508: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=764508
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: virt-manager
Version: 1:1.0.1-2
Severity: normal
Tags: upstream
Tags: fixed-upstream
Tags: patch
X-Debbugs-Cc: [email protected]
Hi,
virt-manager 1.0 ships support for flagging USB devices as removable
(contributed by a Tails developer, because we do need this here).
Unfortunately, a follow-up refactoring by an upstream contributor
(commit eee5061a) broke this feature with a tiny typo, and on current
sid I get:
Error changing VM configuration: define_disk() got an unexpected
keyword argument 'removeable'
Fortunately, another upstream contributor fixed this trivial typo with
commit eb5b26131 (by removing *one* char, s/removeable/removable/),
that is part of the 1.1 upstream release.
The attached patch (against current Vcs-Git) import the fixup commit
from upstream as a quilt patch. I've tested on current sid that it
does indeed fix the bug for me.
It would be great to have this fixed in Jessie :) Have you plans to
re-upload virt-manager in time for it to migrate before the freeze?
If you prefer me to NMU with these changes, just say so.
Cheers,
--
intrigeri
>From 420703e8d921e8ea407a9e2d78c664d2b2618477 Mon Sep 17 00:00:00 2001
From: intrigeri <[email protected]>
Date: Wed, 8 Oct 2014 17:04:48 +0000
Subject: [PATCH 1/2] fix-removable-drive-support.patch: new patch,
cherry-picked from upstream.
---
debian/patches/fix-removable-drive-support.patch | 19 +++++++++++++++++++
debian/patches/series | 1 +
2 files changed, 20 insertions(+)
create mode 100644 debian/patches/fix-removable-drive-support.patch
diff --git a/debian/patches/fix-removable-drive-support.patch b/debian/patches/fix-removable-drive-support.patch
new file mode 100644
index 0000000..d826937
--- /dev/null
+++ b/debian/patches/fix-removable-drive-support.patch
@@ -0,0 +1,19 @@
+Author: Giuseppe Scrivano <[email protected]>
+Date: Tue Jun 24 13:59:12 2014 +0200
+Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1112629
+Origin: upstream, https://git.fedorahosted.org/cgit/virt-manager.git/commit/?id=eb5b2613110dfaa23626a16704d18df0dbba5086
+Description: details.py: fix typo s|removeable|removable|
+
+diff --git a/virtManager/details.py b/virtManager/details.py
+index dd43259..d3826e5 100644
+--- a/virtManager/details.py
++++ b/virtManager/details.py
+@@ -2166,7 +2166,7 @@ class vmmDetails(vmmGObjectUI):
+ kwargs["shareable"] = self.widget("disk-shareable").get_active()
+
+ if self.edited(EDIT_DISK_REMOVABLE):
+- kwargs["removeable"] = bool(
++ kwargs["removable"] = bool(
+ self.widget("disk-removable").get_active())
+
+ if self.edited(EDIT_DISK_CACHE):
diff --git a/debian/patches/series b/debian/patches/series
index b028b2a..4ff2c04 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,3 +1,4 @@
virtinst/fix-path-to-hvmloader.patch
virtinst/Fix-patch-to-pygrub.patch
Move-GConf-values-to-GSettings.patch
+fix-removable-drive-support.patch
--
2.1.1
--- End Message ---
--- Begin Message ---
Source: virt-manager
Source-Version: 1:1.0.1-2.1
We believe that the bug you reported is fixed in the latest version of
virt-manager, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
intrigeri <[email protected]> (supplier of updated virt-manager package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Thu, 09 Oct 2014 10:20:56 +0200
Source: virt-manager
Binary: virt-manager virtinst
Architecture: source all
Version: 1:1.0.1-2.1
Distribution: unstable
Urgency: medium
Maintainer: Debian Libvirt Maintainers
<[email protected]>
Changed-By: intrigeri <[email protected]>
Description:
virt-manager - desktop application for managing virtual machines
virtinst - Programs to create and clone virtual machines
Closes: 764508
Changes:
virt-manager (1:1.0.1-2.1) unstable; urgency=medium
.
* Non-maintainer upload, with permission from maintainer.
* fix-removable-drive-support.patch: new patch, cherry-picked from upstream
(Closes: #764508).
Checksums-Sha1:
0077a2a58cb85fee223ab4a8fbf28a97fdd6fd85 2073 virt-manager_1.0.1-2.1.dsc
a87c5806897ff476179e30e0165c9fb0de7481f1 11580
virt-manager_1.0.1-2.1.debian.tar.xz
24199d38ee291e0d826aaee4abe4db98394768c1 881290 virt-manager_1.0.1-2.1_all.deb
5728b895dde01994c14f37875a8e88c02200cc0a 163700 virtinst_1.0.1-2.1_all.deb
Checksums-Sha256:
b6d212ea9d5624a48796ae78ffbef434f5a92c7c729dc08af8b135cafb888878 2073
virt-manager_1.0.1-2.1.dsc
99e11b50ca5a1c26fbc114efba116a695fb94b8669cb436d5ee5794fb47ee907 11580
virt-manager_1.0.1-2.1.debian.tar.xz
59b852c5813c52a0abfe9654668a6e0a57477efb252b44914a493037f7b4e580 881290
virt-manager_1.0.1-2.1_all.deb
76413a6da86845ba3e3034bf45c68c9af39fe921a2814b2aad70c1ff0e6801ed 163700
virtinst_1.0.1-2.1_all.deb
Files:
b9fdb6092f5a1bbceab2cd1365fd4524 2073 admin optional virt-manager_1.0.1-2.1.dsc
65936f769c4243aee1f4cae83f993542 11580 admin optional
virt-manager_1.0.1-2.1.debian.tar.xz
910c1d81ebe3c0b56f0ee461b97c2ddf 881290 admin optional
virt-manager_1.0.1-2.1_all.deb
036d194a28e48cc41cbb6f24b0fa8d5e 163700 admin optional
virtinst_1.0.1-2.1_all.deb
-----BEGIN PGP SIGNATURE-----
iQIcBAEBCgAGBQJUNkbPAAoJELrOFdKldJj/iSIQAJmDnHZQw6lt85ukkMsMN+bI
/4xWwHHK63FlOKsnbj7dOVBGts7sZdSEjw5azS7OJiTp6EQYMA1DcAc/u7hsTvnb
X83qS78uM+ocAMjf3MC4ImPz5psU5bo4NRyjgYRZj9Fylv8g5ep0R5KxXwu8TXqh
WNaRZy/ZlUy6JzFb0U0vxe6mSoRhKWN1MBWm9hlS6/WkvJLhvpRF/p383Sb697WK
NUECaTvFf/juup9c6tUkqamF+mvHejM7BhvSI5wsEJy8bO2/YjXdDQyTylU1t2wI
mNmQgSQh0vDNxhFsTAYwh1qbF7yEtZfOm6kPhPUmPlxWikDyOKYH6fwkI1abhUne
MkuJovdtLZcyjlMSLTmAOKiwRkIrow+f4/+aIe6Bv9BVI+ThJPfUibH9oUiYj20B
809bjGRw0iwbsQsJv7TWJvJshQS89FrCKih8J1aAOeonLo6XuiBLwI0AcBO+kRom
ZdVR1XbRYwGisMbILXfENXnmWH0ZTlNgqq6q9KFQt+HeAGziaG9vWCLkUXacPXUY
veLrUL5FBnNCCTvmZZo3mM7JS2vMRShZARfC69VsyyhDywqPOfgKj0jH9im/z9K1
MwlFvkPHAwq3SeR2JFiqweR2qDYg1Gvc3NvaIKggQLkaDHjvkkRx4pIbi9l+JoQw
ALJJtpzpj5GyTfZskZS9
=uvBM
-----END PGP SIGNATURE-----
--- End Message ---
