Your message dated Fri, 17 Oct 2014 15:57:16 +0000
with message-id <[email protected]>
and subject line Bug#750401: fixed in nsca-ng 1.4-1
has caused the Debian Bug report #750401,
regarding nsca-ng: Conflicting declarations of struct pidfh
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
750401: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=750401
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: nsca-ng
Version: 1.2-1
Usertags: goto-cc
During a rebuild of all Debian packages in a clean sid chroot (using cowbuilder
and pbuilder) the build failed with the following error. Please note that we
use our research compiler tool-chain (using tools from the cbmc package), which
permits extended reporting on type inconsistencies at link time.
[...]
gcc -std=gnu99 -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat
-Werror=format-security -Wl,-z,relro -o nsca-ng auth.o conf.o fifo.o hash.o
nsca-ng.o server.o ../common/libcommon.a ../../lib/libcompat.a -lconfuse -lev
-lssl -lcrypto -lrt -lbsd ../../lib/pidfile/libpidfile.a
error: conflicting function declarations "pidfile_open"
old definition in module nsca-ng file /usr/include/bsd/libutil.h line 63
struct pidfh * (const char *, unsigned int, signed int *)
new definition in module pidfile file pidfile.c line 112
struct pidfh * (const char *path, unsigned int mode, signed int *pidptr)
reason for conflict in struct pidfh in second member:
unsigned int <padding>
char [4097l]
Makefile:364: recipe for target 'nsca-ng' failed
make[4]: *** [nsca-ng] Error 64
make[4]: Leaving directory
'/srv/jenkins-slave/workspace/sid-goto-cc-nsca-ng/nsca-ng-1.2/src/server'
Makefile:322: recipe for target 'all-recursive' failed
make[3]: *** [all-recursive] Error 1
It seems the shipped version implementing struct pidfh and the one from system
libutil.h don't match:
http://sources.debian.net/src/nsca-ng/1.2-1/lib/pidfile/pidfile.c?hl=61#L59
http://sources.debian.net/src/libbsd/0.6.0-2/include/bsd/libutil.h?hl=51#L49
Notably, the pf_path member will differ in alignment on all systems where
sizeof(char*)>sizeof(int). This might presently be safe insofar as nsca-ng.c
does not attempt to access any of the pidfh members directly, but only maintains
a pointer. (And the linker would hopefully choose the implementation from system
libbsd anyway.)
Yet it seems to be worth fixing either the implementation in pidfile.c or
configure/the Makefile such as not to include libpidfile.a when libbsd is
available.
Best,
Michael
pgp4ObICW1s5x.pgp
Description: PGP signature
--- End Message ---
--- Begin Message ---
Source: nsca-ng
Source-Version: 1.4-1
We believe that the bug you reported is fixed in the latest version of
nsca-ng, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Alexander Wirt <[email protected]> (supplier of updated nsca-ng package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Fri, 17 Oct 2014 15:49:54 +0200
Source: nsca-ng
Binary: nsca-ng-client nsca-ng-server
Architecture: source amd64
Version: 1.4-1
Distribution: unstable
Urgency: medium
Maintainer: Alexander Wirt <[email protected]>
Changed-By: Alexander Wirt <[email protected]>
Description:
nsca-ng-client - Send monitoring commands to NSCA-ng server
nsca-ng-server - Monitoring command acceptor
Closes: 750401
Changes:
nsca-ng (1.4-1) unstable; urgency=medium
.
* [681226d] Fix postinst
* [8e6a5cf] Imported Upstream version 1.4
- Fix pidfile(3) API detection
(Closes: #750401)
* [e36f694] Refresh patch
* [af0c838] Add systemd support
* [5d6f4c1] deprecate default file
* [a29a1bd] Bump standards version
* [1af9aea] Make linitian happy
* [72a1b75] Add some notes about socket activation in config
Checksums-Sha1:
69cb25226034b3e370a5eb10b1601f6987654140 1833 nsca-ng_1.4-1.dsc
5b8423d14d1bab2dc87605694f828363a1e671e4 354012 nsca-ng_1.4.orig.tar.gz
2040e2dfcf2a7aab41a6a8b5cf6e2e8a7ace5a87 6380 nsca-ng_1.4-1.debian.tar.xz
7691fa7a942359718bd7c8eac2db013343c10198 47454 nsca-ng-client_1.4-1_amd64.deb
64e238d2c109806d1f5b23e7a98803bd580f5c59 49304 nsca-ng-server_1.4-1_amd64.deb
Checksums-Sha256:
0f168aac18af1b05423cc92f11fef14f1a55c67df8e21096bd6d1c1a51391e3c 1833
nsca-ng_1.4-1.dsc
25f8e0439104e72443325e5f2503ed39329dccb7928de162dbb7fe6df7196a29 354012
nsca-ng_1.4.orig.tar.gz
2ac302a51b21ec7106d0829aa59bcf094920d42b91dbd65d2c22ccc5692c0fff 6380
nsca-ng_1.4-1.debian.tar.xz
3aa5e5cb7aca36c7eae76f1a7ea6380e0e48bdefd749a0707d461c0ffdb22731 47454
nsca-ng-client_1.4-1_amd64.deb
ad4f207b2aed65427b151c145e1d9017d0c32f3351facd87ca1cc8f30c97ceff 49304
nsca-ng-server_1.4-1_amd64.deb
Files:
c92ec196741fb095d08aa61033be46b1 1833 net extra nsca-ng_1.4-1.dsc
5193cd5e20b938d149a638ba12395f3c 354012 net extra nsca-ng_1.4.orig.tar.gz
6edfb8f121122f27753689200d3646de 6380 net extra nsca-ng_1.4-1.debian.tar.xz
04ac8ba69252cb86730bd3ef07b15102 47454 net extra nsca-ng-client_1.4-1_amd64.deb
643ce9d8351c33b956e3ff5721e8abb9 49304 net extra nsca-ng-server_1.4-1_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBAgAGBQJUQR71AAoJEB5F+Mqd4jsWwMoP/3gVl0jvWrWNemh4SP6vX36w
/8fexYsWNkNQQJXhfAdWSQVxR+X8AMJ1BtI8CUwRiFBAUG1+y7s1OfMRfASEW2GK
+tIIBh1b4BLaByjRrN7d2NcRCC6icR+NCiR0xOxZqfz2GBN4EY+pPEtQIo31kCzb
GVSytPJlKdlIUOsiHxSQ6bBx6Xb3u4fcL6gXt0I4zLHtz48EH7w0t+QAV73OzX81
2X7Kv7wFUuwSQYcbvigd8+Z0dO346HZ7aJ3wiUaIrE6qTMEpsTqupSHWorXLwqpb
wTX4x3LqVJU0KdDZR2xNNeYh7s64mpO0Dfe/pgB+YFjTsp0zjQMJqE+PIBJGvgvI
Hwt4HOXgnr61Oa8ZMV4zsKWf0OpUXbVT1DoBl2jdHVjWRSD5QVzbrQfFyG0Eyoc5
vRgPmW+2G+EvM3+7YcF/4u66yt9pmN4lX39rrfcCnwPjY6gnrUzjTRmUfZEIP3BX
CJiX0zh8JHNS/b/IlhMsqk3IH1PNZKchrJLSjKq88CsDHw1ML2sftTAh/vf/L8ZX
tQIul3nzf2z23RGLOp3iHm62blSsndJHaTisSzUtf4AlnbKr5h0jeqG7Le/lB+MN
md5hnSbAO1Lo7qUrhsSaXN5b92NT8nGW+1Kdvwu5Szzp6nVVkx550kK7DiZwY0GT
2tEexizUUF4cuG4xCsvx
=CIKz
-----END PGP SIGNATURE-----
--- End Message ---
