Your message dated Mon, 27 Oct 2014 17:33:45 +0000
with message-id <[email protected]>
and subject line Bug#477713: fixed in dirvish 1.2.1-1.3
has caused the Debian Bug report #477713,
regarding dirvish: Dirvish cronjob should fail if it is already running
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
477713: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=477713
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: dirvish
Version: 1.2.1-1.1
Severity: normal
Tags: patch

I have some machines that take a long time to run their backups.

The dirvish cron job runs every day, but sometimes yesterday's dirvish 
jobs are still running.  The dirvish cron job happily tries to run 
dirvish again; now you get half the network bandwidth available, so if 
that day's backups take that long again, they'll create an infinite 
backlog....

The /etc/dirvish/dirvish-cronjob that starts the backups can address 
this; I have attached a patch that does address it.

I release the patch under the terms of the GNU General Public License 
version 2 or later, at your option.

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing')
Architecture: i386 (i686)

Kernel: Linux 2.6.22-3-vserver-686 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL 
set to en_US.UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages dirvish depends on:
ii  libtime-modules-perl         2006.0814-2 Various Perl modules for time/date
ii  libtime-period-perl          1.20-8      Perl library for testing if a time
ii  perl                         5.8.8-12    Larry Wall's Practical Extraction 
ii  perl-modules                 5.8.8-12    Core Perl modules
ii  rsync                        3.0.2-1     fast remote file copy program (lik

Versions of packages dirvish recommends:
ii  ssh                           1:4.7p1-8  secure shell client and server (me

-- no debconf information
36a37,62
> ## Asheesh's locking addition
> fail() {
>       echo "Cron job currently running; I'm outta here."
>       exit 1;
> }
> 
> 
> die_if_dirvish_locked() {
>       OTHER_PID=$(cat /var/lock/dirvish-cronjob 2>/dev/null)
>       # if the PID file exists:
>       [ -f  /var/lock/dirvish-cronjob ] && 
>       ps "$OTHER_PID" 2>&1 >/dev/null && fail
> }
> 
> lock_dirvish() {
>       MY_PID=$$
>       echo "$MY_PID" > /var/lock/dirvish-cronjob
> }
> 
> unlock_dirvish() {
>       rm -f /var/lock/dirvish-cronjob
> }
> 
> die_if_dirvish_locked
> lock_dirvish
> 
44a71,72
> unlock_dirvish
> 

--- End Message ---
--- Begin Message ---
Source: dirvish
Source-Version: 1.2.1-1.3

We believe that the bug you reported is fixed in the latest version of
dirvish, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Bdale Garbee <[email protected]> (supplier of updated dirvish package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 06 Aug 2014 08:43:48 -0600
Source: dirvish
Binary: dirvish
Architecture: source all
Version: 1.2.1-1.3
Distribution: unstable
Urgency: low
Maintainer: Paul Slootman <[email protected]>
Changed-By: Bdale Garbee <[email protected]>
Description:
 dirvish    - Filesystem based backup system using rsync
Closes: 477713
Changes:
 dirvish (1.2.1-1.3) unstable; urgency=low
 .
   * Non-maintainer upload.
   * patch from John Altstadt that prevents overlapping runs on a per-vault
     level, which is a better approach than locking at the runall script
     level, closes: #477713
Checksums-Sha1:
 d43b05885f0746e08a82a211347f45a1f9c7e9ce 1684 dirvish_1.2.1-1.3.dsc
 a2ea00ac218da45b952e76bd4b4f9d5a1d045e39 13700 dirvish_1.2.1-1.3.debian.tar.xz
 b4daf806dbc0cf71b48228ebe7fdae18337b400a 55822 dirvish_1.2.1-1.3_all.deb
Checksums-Sha256:
 763ff06336299ca83e9bc35f9be8c844c8d9f15f07dd47afa4a2c656d4d2a860 1684 
dirvish_1.2.1-1.3.dsc
 5116aa2bd1027c11354dae0d09c8496cc9136aa08369a2231026702f6c8a29bc 13700 
dirvish_1.2.1-1.3.debian.tar.xz
 4d05c8bd7e8882f75458bc8d4b2364793b3db84b111a57a81a664ab291aa69b6 55822 
dirvish_1.2.1-1.3_all.deb
Files:
 09f53a7b4953c534d3c732a948617825 1684 admin optional dirvish_1.2.1-1.3.dsc
 289468d269055b85bb7d113ba3e44060 13700 admin optional 
dirvish_1.2.1-1.3.debian.tar.xz
 e4935551bb5ad2f1f4f54ea6dc4751db 55822 admin optional dirvish_1.2.1-1.3_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIVAwUBVE59mjqTYZbAldlBAQrUqQ/+J0qWM1AKFeln3l6W1doaIQkbmMspvlOg
u3/7opBezv2g31q+ZKULcOa0LB29SvuQA2E0g8IO+nILbf3urm6MFXPvb9WmhtRb
ET/j8UnkBECLFmLBrdjXesKxjPwStJLu7IMOvE1ov+HFvhl2gk90vK/ysb85moIT
LMs2vGa5jebqj9t4MXjqZYE4HaNFss1cwK8GgIcJHCKXYGDWZ3kq+RwHSWMdorJv
bRa+Nmk6iHafnXOH9skIw+CbXTPSSsnVJr32F9Yn+f8jFL2rGcOvgO8ZJ+PalmW6
Bc8ykJjAyJkxzTWHLe6br8ZotIKzwSEjeEN/SLbHFIShzTNHE4LRRbBkGeePgpiW
+ZqzdRvijTRmy3K8NfHii6Rc5y79ZghuayiceB4jWy9G2fX5XgOoA7yfv9NH9ulY
sbGPy2dWYfUAPjMtuDL7mQsitFod3vfbX45Vr3CKK5U/zG295IHyl+2Iko8KR+/T
SnMivddQpEU9BKENmbA6V/EJ7X0w3mNiABiLNKW+Ou4RfIebJDoOXGbHd1JTBKEV
f5QOw6R8YVx0HA0NPgP3LCjDB9onD5ger6ShAmxjAzrdiAYWQLhNn9nkVbbM+nR9
RGZfUcpmi3rPokptwrZhDCdZDqSsUoV8tlpVCMtMIHvsEAhgdRDSGtO43kkRpGgP
WH+A6LdANtA=
=GY1e
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to