Your message dated Wed, 29 Oct 2014 15:35:54 +0000
with message-id <[email protected]>
and subject line Bug#761209: fixed in squid3 3.4.8-2
has caused the Debian Bug report #761209,
regarding squid3: init script fails to parse an indented cache_dir directive
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
761209: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=761209
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: squid3
Version: 3.1.20-2.2+deb7u2
Severity: normal
Tags: patch

Dear Maintainer,

the squid3 init script fails to parse the cache_dir directive from our
squid3.conf. The reason is that our cache_dir directive is indented with
two spaces:

  cache_dir ufs /var/spool/squid3 10000 16 256

The sed expression that parses the config file doesn't allow for leading
white space:

s/^'$1'['"$w"']\+ ...

^ matches the beginning of the string and $1 matches cache_dir, and so
the expression will only parse lines that directly begin with cache_dir.

This prevents the init script from populating the cache dir; the
administrator has to resolve this by manually running squid3 -z. If the
cache dir is not populated, squid3 won't start and will instead log the
following error to cache.log:

2014/09/11 18:50:46| /var/spool/squid3/00: (2) No such file or directory
FATAL:  Failed to verify one of the swap directories, Check cache.log
        for details.  Run 'squid -z' to create swap directories
        if needed, or if running Squid for the first time.
Squid Cache (Version 3.1.20): Terminated abnormally.


I've attached a patch that fixes the following issues:
- consistent tab indentions in the init script
- fixes the w= line in find_cache_dir that is apparently supposed to
  contain a space followed by a tab, but currently just contains five
  spaces.
- allows for spaces before cache_dir in both find_cache_dir and
  find_cache_type.

-- System Information:
Debian Release: 7.6
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: i386 (x86_64)
Foreign Architectures: amd64

Kernel: Linux 3.14-0.bpo.2-amd64 (SMP w/8 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages squid3 depends on:
ii  adduser           3.113+nmu3
ii  libc6             2.13-38+deb7u4
ii  libcap2           1:2.22-1.2
ii  libcomerr2        1.42.5-1.1
ii  libdb5.1          5.1.29-5
ii  libexpat1         2.1.0-1+deb7u1
ii  libgcc1           1:4.7.2-5
ii  libgssapi-krb5-2  1.10.1+dfsg-5+deb7u2
ii  libk5crypto3      1.10.1+dfsg-5+deb7u2
ii  libkrb5-3         1.10.1+dfsg-5+deb7u2
ii  libldap-2.4-2     2.4.31-1+nmu2
ii  libltdl7          2.4.2-1.1
ii  libpam0g          1.1.3-7.1
ii  libsasl2-2        2.1.25.dfsg1-6+deb7u1
ii  libstdc++6        4.7.2-5
ii  libxml2           2.8.0+dfsg1-7+wheezy1
ii  logrotate         3.8.1-4
ii  lsb-base          4.1+Debian8+deb7u1
ii  netbase           5.0
ii  squid3-common     3.1.20-2.2+deb7u2

squid3 recommends no packages.

Versions of packages squid3 suggests:
ii  resolvconf   1.67
ii  smbclient    2:3.6.19-1~bpo70+1
pn  squid-cgi    <none>
ii  squidclient  3.1.20-2.2+deb7u2
pn  ufw          <none>

-- Configuration Files:
/etc/logrotate.d/squid3 changed:
/var/log/squid3/*.log {
        daily
        compress
        delaycompress
        rotate 7
        missingok
        nocreate
        sharedscripts
        prerotate
                /usr/lib/iserv/botdetector $1
        endscript
        postrotate
                test ! -e /var/run/squid3.pid || /usr/sbin/squid3 -k rotate
        endscript
}

/etc/squid3/squid.conf changed:
  http_port 10.0.0.13:3128 intercept
  http_port 127.0.0.1:3128
  cache_dir ufs /var/spool/squid3 10000 16 256
  maximum_object_size 1 GB


-- no debconf information
--- squid3.orig	2014-09-11 18:56:59.946223957 +0200
+++ squid3	2014-09-11 19:06:28.736129772 +0200
@@ -33,20 +33,20 @@
 ulimit -n 65535
 
 find_cache_dir () {
-        w="     " # space tab
-        res=`sed -ne '
-                s/^'$1'['"$w"']\+[^'"$w"']\+['"$w"']\+\([^'"$w"']\+\).*$/\1/p;
-                t end;
-                d;
-                :end q' < $CONFIG`
-        [ -n "$res" ] || res=$2
-        echo "$res"
+	w=" 	" # space tab
+	res=`sed -ne '
+		s/^['"$w"']\+'$1'['"$w"']\+[^'"$w"']\+['"$w"']\+\([^'"$w"']\+\).*$/\1/p;
+		t end;
+		d;
+		:end q' < $CONFIG`
+	[ -n "$res" ] || res=$2
+	echo "$res"
 }
 
 find_cache_type () {
 	w=" 	" # space tab
 	res=`sed -ne '
-		s/^'$1'['"$w"']\+\([^'"$w"']\+\).*$/\1/p;
+		s/^['"$w"']\+'$1'['"$w"']\+\([^'"$w"']\+\).*$/\1/p;
 		t end;
 		d;
 		:end q' < $CONFIG`
@@ -59,8 +59,8 @@
 	cache_type=`find_cache_type cache_dir`
 
 	#
-    # Create spool dirs if they don't exist.
-    #
+	# Create spool dirs if they don't exist.
+	#
 	if [ "$cache_type" = "coss" -a -d "$cache_dir" -a ! -f "$cache_dir/stripe" ] || [ "$cache_type" != "coss" -a -d "$cache_dir" -a ! -d "$cache_dir/00" ]
 	then
 		log_warning_msg "Creating $DESC cache structure"
@@ -106,7 +106,7 @@
 }
 
 case "$1" in
-    start)
+	start)
 	log_daemon_msg "Starting $DESC" "$NAME"
 	if start ; then
 		log_end_msg $?
@@ -114,7 +114,7 @@
 		log_end_msg $?
 	fi
 	;;
-    stop)
+	stop)
 	log_daemon_msg "Stopping $DESC" "$NAME"
 	if stop ; then
 		log_end_msg $?
@@ -122,13 +122,13 @@
 		log_end_msg $?
 	fi
 	;;
-    reload|force-reload)
+	reload|force-reload)
 	log_action_msg "Reloading $DESC configuration files"
 	start-stop-daemon --stop --signal 1 \
 		--pidfile $PIDFILE --quiet --exec $DAEMON
 	log_action_end_msg 0
 	;;
-    restart)
+	restart)
 	log_daemon_msg "Restarting $DESC" "$NAME"
 	stop
 	if start ; then
@@ -137,10 +137,10 @@
 		log_end_msg $?
 	fi
 	;;
-    status)
+	status)
 	status_of_proc -p $PIDFILE $DAEMON $NAME && exit 0 || exit 3
 	;;
-    *)
+	*)
 	echo "Usage: /etc/init.d/$NAME {start|stop|reload|force-reload|restart|status}"
 	exit 3
 	;;

--- End Message ---
--- Begin Message ---
Source: squid3
Source-Version: 3.4.8-2

We believe that the bug you reported is fixed in the latest version of
squid3, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Luigi Gangitano <[email protected]> (supplier of updated squid3 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 29 Oct 2014 15:50:51 +0100
Source: squid3
Binary: squid3 squid3-dbg squid3-common squidclient squid-cgi squid-purge
Architecture: source all i386
Version: 3.4.8-2
Distribution: unstable
Urgency: medium
Maintainer: Luigi Gangitano <[email protected]>
Changed-By: Luigi Gangitano <[email protected]>
Description:
 squid-cgi  - Full featured Web Proxy cache (HTTP proxy) - control CGI
 squid-purge - Full featured Web Proxy cache (HTTP proxy) - control utility
 squid3     - Full featured Web Proxy cache (HTTP proxy)
 squid3-common - Full featured Web Proxy cache (HTTP proxy) - common files
 squid3-dbg - Full featured Web Proxy cache (HTTP proxy) - Debug symbols
 squidclient - Full featured Web Proxy cache (HTTP proxy) - control utility
Closes: 728222 732183 760400 761209 763867 765476
Changes:
 squid3 (3.4.8-2) unstable; urgency=medium
 .
   [ Santiago Garcia Mantinan <[email protected]> ]
   * Add patch to remove bashisms from cert_tool
   * Add manual page for squid-purge
   * Create run_dir needed for SMP with several workers to run. This
     fixes #710126 (Closes: #732183, #760400)
   * Use CONFIG instead of sq (Closes: #763867)
   * Remove find_cache_type and use grepconf (both functions were =).
   * Allow find_cache_dir and grepconf to have whitespace in the beginning
     (Closes: #761209)
   * Add config check before reload/restart, thanks Freddy (Closes: #728222)
 .
   [ Amos Jeffries <[email protected]> ]
   * debian/squid3.postinst
     - update grepconf to support SMP macros and sub-config files
       when locating cache_dir and effective user/group
 .
   * debian/squid3.rc
     - remove special handling for obsolete COSS cache type
     - change grepconf to support SMP macros and sub-config files
 .
   * debian/rules
     - add distribution details to squid -v display output
       this obsoletes the Ubuntu fix-distribution.patch
 .
   * debian/control
     - bumped libecap dependency version to 0.2.0-2
 .
   * debian/squid3.resolvconf
     - added check on /usr availability before squid3 restart (Closes: #765476)
 .
   [ Luigi Gangitano <[email protected]> ]
   * debian/squid3.rc
     - Change config check to config parse on start/reload/restart
 .
   * debian/control
     - Fixed XS-Vcs-Git Header pointing anonscm.debian.org
Checksums-Sha1:
 8d44c458dfd553a103a94f6ff31b5780d97a4603 2289 squid3_3.4.8-2.dsc
 2b1027875e0fa828cf9c7cc70f27c10d3852857d 26876 squid3_3.4.8-2.debian.tar.xz
 5f15c2fbd6e65d071bb2e7e812930476c3b10132 257674 squid3-common_3.4.8-2_all.deb
 1f81f784103117a0a37b996a2cc60ad3f8d0e6ac 2090026 squid3_3.4.8-2_i386.deb
 506370631752045736376ad7e20d27006d1123ea 7360302 squid3-dbg_3.4.8-2_i386.deb
 05f7043c06d57f5fa26c0492cd0d4b2c7c60c2b2 141202 squidclient_3.4.8-2_i386.deb
 0694d6658d037671e6c6869ec5be413da172440c 144644 squid-cgi_3.4.8-2_i386.deb
 9fc8b4c7f65a5461b5aa20cc8c91c3058d309645 139736 squid-purge_3.4.8-2_i386.deb
Checksums-Sha256:
 b612ad2ed7cd263e90f4a0dc3ce883fbd4e4d37450d079ad6e7e508998057ec7 2289 
squid3_3.4.8-2.dsc
 dc63d993c322e649a66f7339bcea117dfc4624948c717ed2fe95c48c71230a20 26876 
squid3_3.4.8-2.debian.tar.xz
 4ac1c27baf54d4ba619d2512f9f7feb438bba1e6e2938e9526521f9f98d97b90 257674 
squid3-common_3.4.8-2_all.deb
 00e56dc8ee104d25d1fb9bf2853a4925a975b21e0b679ac09a725a35089b1a4b 2090026 
squid3_3.4.8-2_i386.deb
 04a0563ef0ee3281bd3ee0cd98e7d8e8351f4c9361eb9a35b84080348bf00f14 7360302 
squid3-dbg_3.4.8-2_i386.deb
 35898164d5c0cc52228d1594c2f9a68772140fe5eca962654537964ff2a6d695 141202 
squidclient_3.4.8-2_i386.deb
 f19de5fc0fdd0947a8dc5a185bed31ceac1b6357242db968d520a2c48dbab3e2 144644 
squid-cgi_3.4.8-2_i386.deb
 8d41a7932ced4d157113064812a44ba51e78a8a2e4ebd33b08b38d1359a9a3ec 139736 
squid-purge_3.4.8-2_i386.deb
Files:
 84624ae6b4e2578dc36440ae6d581222 2289 web optional squid3_3.4.8-2.dsc
 30f23bf36c99776c5a6cb1591a3211be 26876 web optional 
squid3_3.4.8-2.debian.tar.xz
 ed5e85633c0aac13b6f129a52e20b18a 257674 web optional 
squid3-common_3.4.8-2_all.deb
 610b49e098adf0efb81b13660305244a 2090026 web optional squid3_3.4.8-2_i386.deb
 67a71d3cd543e429c78e9517f4eb4908 7360302 debug extra 
squid3-dbg_3.4.8-2_i386.deb
 27faf12dc3c5abe1201ca4e504622a40 141202 web optional 
squidclient_3.4.8-2_i386.deb
 146fcce73ffc9d731eb828d9a0bc3aca 144644 web optional squid-cgi_3.4.8-2_i386.deb
 c032a8f9c9c200500f5a0879c78d16d7 139736 web optional 
squid-purge_3.4.8-2_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJUUP+QAAoJEAKE8gwrqXztaRoP/2+uPD6fjTxnigmP86XHEUbH
EWlHCGF4RvXMlCd/aJmCbJC4Cz1pya15BOJGJk5SjrpUiYQ97Y01Rrm/ZS/1hwzD
SRz8KTgXZW4QLxCqvvJ+bTZEcaLY2SpjrhQD1uumiWwvxuUik/pZqW+hszjb/DPc
A5BO6RbdPmqEbYDYtop6nhStIVq0hB3BqSBMmcfJuAQPW8ZZbQZJGQnqJFxZmFzg
0C3wcWkjiJCkTiIijPACi2yz8JSYsQTVF9zrT1lUM6cGsnoYiGDhd9VvNitYZbv0
k+dFXX2hNkOPzagfTo1RDADXB9h/wQaxKLc9Kgao/lO702Lil+9F88TqmqWa4qA2
gIJsJurf3KHKW5kR8iIKor7vVeaTPa6nUKPO0bxjzNgkeAbVzVEXq+9pGyr9uird
APXKztVHJmzt/INRlLNT35U27os/jN7bJHsr3rLlgEuIrxvrjPX67lp9yAfAvW0M
sl/Bc+o+PyFv69ccpB4wBKWf1pBUZxsnP7ZzXCpBatf8BmaqyZaX3gzPlsLzjq1V
JXBETj0Xn+GT7WpfVUxoqGSgJ+zk7Zuw2pr4+ANs3h9t7v7x2t1LJvED6/Wk7N4k
3ewfOgHiTNgVqPgTAPoVj+ki0HQ27hJTRtBUckC9yomw0KofeaTHd79Jat2bddit
cLDoJCrgFXSI+yfo/6HK
=8X9b
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to