Your message dated Mon, 22 Dec 2014 21:35:13 +0000
with message-id <[email protected]>
and subject line Bug#545921: fixed in videogen 0.33-1
has caused the Debian Bug report #545921,
regarding videogen: Multiple issues with the some_modes script.
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
545921: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=545921
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: videogen
Version: 0.32-3
Severity: normal
Tags: patch

This script doesn't seem to be updated very frequently.  There are a few
issues which are fixed in the attached patch:

* a reference to XF86Config(-4)
* it fails silently when dialog, whiptail, and gdialog aren't installed
* the DEF_MINSYNC variable is ignored
* the logic to check for MINSYNC out of range is wrong and incomplete
* spelling mistake (choosen)
* inconsistent command indentation

Not fixed here: Most recent LCD monitors support "reduced blank" modes
which can be generated with the cvt(1) command.  They may be needed
instead of the modes produced by videogen to obtain good refresh rates
with high resolution modes on low end video cards.  It would be nice
if it were also packaged and this script could call it too.


-- System Information:
Debian Release: 4.0
  APT prefers oldstable
  APT policy: (500, 'oldstable')
Architecture: amd64 (x86_64)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.27.28
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=ANSI_X3.4-1968) 
(ignored: LC_ALL set to C)

Versions of packages videogen depends on:
ii  bc                     1.06-20           The GNU bc arbitrary precision cal
ii  libc6                  2.3.6.ds1-13etch9 GNU C Library: Shared libraries

videogen recommends no packages.

-- no debconf information


The patch:

--- /usr/bin/some_modes 2006-08-23 06:35:16.000000000 -0700
+++ some_modes  2009-09-09 16:47:00.000000000 -0700
@@ -1,7 +1,7 @@
 #!/bin/bash
 # +-----------------------------------------------------------+
 # |                                                           |
-# | use this script to generate some mode lines automatically |
+# | Use this script to generate some mode lines automatically |
 # | with videogen.                                            |
 # |                                                           |
 # | (c) Szabolcs Rumi, 1997-2001                              |
@@ -11,6 +11,7 @@
 # you may change this to the location of the videogen program
 VIDEOGEN="${VIDEOGEN=videogen} -f=/dev/null"
 
+
 # set this to the maximum dot clock your video card can generate [MHz]
 DOTCLOCK="225"
 DEF_DOTCLOCK=$DOTCLOCK
@@ -27,34 +28,40 @@
 MINSYNC="0.5"
 DEF_MINSYNC="0.5"
 
+# set this to emit mode lines compatible with the non-free NVidia driver
 NVIDIA="yes"
 
-# load our settings
+
+# load your previous settings
 if test -f ~/.videogenrc ; then
-. ~/.videogenrc
+  . ~/.videogenrc
 fi
 
 if test -z "$DIALOG" ; then
   which dialog   > /dev/null && DIALOG=dialog
   which whiptail > /dev/null && DIALOG=whiptail
-  which gdialog > /dev/null  && DIALOG=gdialog
+  which gdialog  > /dev/null && DIALOG=gdialog
+fi
+if test -z "$DIALOG" ; then
+  echo "$0: no dialog program found, unable to continue" 1>&2
+  exit 1
 fi
 
 # The dialog part
-#DIALOG=${DIALOG=whiptail}
 tempfile=`tempfile 2>/dev/null` || tempfile=/tmp/test$$
 trap "rm -f $tempfile" 0 1 2 5 15
 
 $DIALOG \
- --title "GENERAL WARNING" --clear        --yesno \
+ --title "GENERAL WARNING" --clear --yesno \
 "WARNING! WARNING! WARNING!
 
 THE USE OF THIS PROGRAM CAN CAUSE PERMANENT DAMAGE TO YOUR MONITOR AND/OR 
VIDEO CARD. IF YOU ARE NOT SURE WHAT YOU ARE DOING, HIT 'NO' NOW, OTHERWISE, 
HIT 'YES' TO CONTINUE.
 
 THE SOFTWARE IS PROVIDED 'AS IS', WITHOUT WARRANTY OF ANY KIND, EXPRESS OR 
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, 
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE 
SOFTWARE AUTHOR(s) BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER 
IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN 
CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE." 22 
70 || exit 1
 
- 
-$DIALOG --title "HINTS" --clear --msgbox \
+
+$DIALOG \
+ --title "HINTS" --clear --msgbox \
 "There are no perfect modelines for all monitors.
 
 There are many monitors that can be damaged by using wrong and non-standard 
modes, so better make sure that it will power-off if an invalid mode is tried.
@@ -63,55 +70,55 @@
 
 $DIALOG \
  --title "INPUT BOX" --clear \
-        --inputbox "Please enter the maximum dot clock your video card can 
generate [MHz]. (default: $DEF_DOTCLOCK)" 10 51 $DOTCLOCK 2> $tempfile
+ --inputbox "Please enter the maximum dot clock your video card can generate 
[MHz]. (default: $DEF_DOTCLOCK)" 10 51 $DOTCLOCK 2> $tempfile
 retval=$?
 
 case $retval in
   0)
-    read DOTCLOCK < $tempfile ;;
+    read DOTCLOCK < $tempfile || exit 1;;
   *)
     exit 1;;
 esac
 
 $DIALOG \
  --title "INPUT BOX" --clear \
-        --inputbox "Please enter the maximum horizontal refresh rate of your 
monitor [kHz]. (default: $DEF_HORIZ)" 10 51 $HORIZ 2> $tempfile
+ --inputbox "Please enter the maximum horizontal refresh rate of your monitor 
[kHz]. (default: $DEF_HORIZ)" 10 51 $HORIZ 2> $tempfile
 retval=$?
 case $retval in
   0)
-    read HORIZ < $tempfile ;;
+    read HORIZ < $tempfile || exit 1;;
   *)
     exit 1;;
 esac
 
 $DIALOG \
  --title "INPUT BOX" --clear \
-        --inputbox "Please enter the maximum vertical refresh rate of your 
monitor [Hz]. (default: $DEF_VERT)" 10 51 $VERT 2> $tempfile
+ --inputbox "Please enter the maximum vertical refresh rate of your monitor 
[Hz]. (default: $DEF_VERT)" 10 51 $VERT 2> $tempfile
 retval=$?
 
 case $retval in
   0)
-    read VERT < $tempfile ;;
+    read VERT < $tempfile || exit 1;;
   *)
     exit 1;;
 esac
 
 $DIALOG \
  --title "INPUT BOX" --clear \
-        --inputbox "Please enter the minimum horizontal sync pulse length of 
your monitor [us]. (default: $DEF_MINSYNC)" 10 51 $MINSYNC 2> $tempfile
+ --inputbox "Please enter the minimum horizontal sync pulse length of your 
monitor [us]. (default: $DEF_MINSYNC)" 10 51 $MINSYNC 2> $tempfile
 retval=$?
 
 case $retval in
   0)
-    read MINSYNC < $tempfile ;;
+    read MINSYNC < $tempfile || exit 1;;
   *)
     exit 1;;
 esac
 
 if test "$NVIDIA" = "yes" ; then
-       NV=""
+  NV=""
 else
-       NV="--defaultno"
+  NV="--defaultno"
 fi
 if $DIALOG $NV \
  --title "NVIDIA COMPATIBILITY" --yesno "The non-free Nvidia drivers available 
from www.nvidia.com require small changes in calculating algorithm. Without 
them, many Modelines are not accepted by the driver. Should videogen try to 
make compatible lines?" 10 51 2> $tempfile ; then
@@ -135,17 +142,27 @@
 # these lines were inserted to warn you not to forget to change the above vars
 # which are set to my hardware parameters by default
 tput bold 2>/dev/null
-echo 
'-------------------------------------------------------------------------'
-echo 'Now you can edit your XF86Config(-4) file, locate the "Monitor"'
-echo 'section and input the generated lines there. For framebuffer lines,'
-echo 'use "fbset" directly or enter them into /etc/fb.modes. Take a look at 
the'
-echo 'manpages fbset(1) and fb.modes(5) to see what this is about.'
-if [ -z "`echo \"-1.5 + $MINSYNC\" | bc | cut -f1 -d.`" ]  ; then
-   MINSYNC=1.5
-fi
-echo ''
-echo 'NOTE: choosen minimal horizontal sync value is too high, choosing 1.5!'
-echo 
'-------------------------------------------------------------------------'
+echo 
'+-----------------------------------------------------------------------+'
+echo '|                                                                       
|'
+echo '| To configure X, edit /etc/X11/xorg.conf.  Locate the "Monitor"        
|'
+echo '| section and place the generated Modeline lines there.  See the        
|'
+echo '| manpage xorg.conf(5) for more details.                                
|'
+echo '|                                                                       
|'
+echo '| To setup the framebuffer, pass the generated timing lines to "fbset"  
|'
+echo '| directly, or enter them into /etc/fb.modes.  Take a look at the       
|'
+echo '| manpages fbset(1) and fb.modes(5) to see what this is about.          
|'
+echo '|                                                                       
|'
+# videogen requires the minimum horizontal sync to be in the range [0.3..1.5]
+if [ "`echo \"10 * $MINSYNC\" | bc | cut -f1 -d.`" -lt 3 ] ; then
+  MINSYNC=$DEF_MINSYNC
+  echo "| NOTE: Chosen minimal horizontal sync value is too low, choosing 
$MINSYNC!  |"
+  echo '|                                                                      
 |'
+elif [ "`echo \"10 * $MINSYNC\" | bc | cut -f1 -d.`" -gt 15 ] ; then
+  MINSYNC=$DEF_MINSYNC
+  echo "| NOTE: Chosen minimal horizontal sync value is too high, choosing 
$MINSYNC! |"
+  echo '|                                                                      
 |'
+fi
+echo 
'+-----------------------------------------------------------------------+'
 tput sgr 0 2>/dev/null # turn off bold mode
 
 # these are the lines printing out the main thing



--- End Message ---
--- Begin Message ---
Source: videogen
Source-Version: 0.33-1

We believe that the bug you reported is fixed in the latest version of
videogen, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Bas Zoetekouw <[email protected]> (supplier of updated videogen package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 22 Dec 2014 11:39:09 +0100
Source: videogen
Binary: videogen
Architecture: source i386
Version: 0.33-1
Distribution: unstable
Urgency: low
Maintainer: Bas Zoetekouw <[email protected]>
Changed-By: Bas Zoetekouw <[email protected]>
Description:
 videogen   - Create arbitrary-res modelines using hardware parameters
Closes: 545921 670936
Changes:
 videogen (0.33-1) unstable; urgency=low
 .
   * New upstream release
    - fixed a bug that caused maximal vfreq to be disregarded when desired
      vfreq was higher
    - added ability to use floating point value for max_dotclk in the
      configuration file
   * Fixes to some_modes script (Closes: #545921)
     Thanks to Ross Combs.
   * Switch to dpkg-source 3.0 (quilt) format (Closes: #670936)
     Thanks to Jari Aalto.
   * Switch to debhelper version 9
   * Bumped standards-version to 3.9.6
Checksums-Sha1:
 b29edc45c225659527e7ffdb39447ff3e5c5dc32 1702 videogen_0.33-1.dsc
 e193c25ea3449f53fb7756053fbb24b615e7a60a 37439 videogen_0.33.orig.tar.gz
 b62d5bccd3b486ed93dac9b077db4323a69db829 10308 videogen_0.33-1.debian.tar.xz
 b120ad6399a8d0341990f4c1e54ccdf21b6d4dd9 28112 videogen_0.33-1_i386.deb
Checksums-Sha256:
 402f0abb3fff9749df9406993f4f9bdd45da29030c1c4b895b4aecc779847e53 1702 
videogen_0.33-1.dsc
 ef5774940d456084798aaff5c8732a5c36a17583ca9400f5aa809b0b1869a9b2 37439 
videogen_0.33.orig.tar.gz
 cd75caef2bbecd15acaa5b3977907de7ac344ae470e24aa1caea73a69ae7d223 10308 
videogen_0.33-1.debian.tar.xz
 fd09f9a9b7923ed3342acd1545d248d873cb5c0943d4e90feda020111809ee9f 28112 
videogen_0.33-1_i386.deb
Files:
 1833d5f3d8aaf09f133c4de96c944022 1702 x11 optional videogen_0.33-1.dsc
 41d0b11c245cb0bcc497c592ab6b4190 37439 x11 optional videogen_0.33.orig.tar.gz
 b87c4eb894359658b610df8aa04b8c7e 10308 x11 optional 
videogen_0.33-1.debian.tar.xz
 d1bd6677195b4509d417d2eb2bb48cb3 28112 x11 optional videogen_0.33-1_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJUmHVOAAoJENGDpRe/qY3mHPsQANK3NOFvUbP/jXX2A4qI3r/p
MyYfKhttDOFjJCI0T/SW8gZsI/p56Ud44CTkMlUfqdbFvsiLDeO1/DDLbSlyYtVC
HiCdeoxgtdsrKpJva9yu8pgrpmsEIWQ7nhIUKLpiuGE14ljT+TnHkjC+SQfkELWr
eA4zYGEIPfYRLoZs/tzogdrvHH4uP06+bf5sY8VZiiBXGROulni4d+wBUPgNdjiP
Ov8Wd+S55h0jcllybT7eHCnrNuFYep0PQ2EURzlYxg53i0kTDHtka7hyVAljacDG
HD+ofdc6IZbzzNpi5H3j3OsaGggx3b+HDCEwsQJkWPp1onA3nnDYU8yCmzxVT2ns
k4iQ0ZO1hW+CtyhmOtd68W4xHi2TyzT5+w/4ySetqIQmrzrZ9L5SG2fnGRu9YJ0V
LvQF6RzRRwKmeZKU8Fl8yRk1I8mSj2LP80oBa5IF3Du67sK0TJjOJYswAlO2KrV6
0IHmdCe3RQdNjhUWlB5HsKfK7oosRD6F8uH9HRSm+ZldeMoI8bo1YbKwHso/4ISC
ecb665snLL4ZqVWwZcoDn9dq5Ibjikx0POZK4AcIYIY8rwJWexTcgCXqgprEXJuu
tRjvdeEH3TiZEeSsojHzkTvv0XTYxbsKGkYAZJePLyZYkA19+og4fC3z1HuwR+lL
jTfIfzuXw2XtjWHbOpaA
=z2Ax
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to