Your message dated Sun, 11 Jan 2015 12:03:27 +0000 with message-id <[email protected]> and subject line Bug#775092: fixed in autopkgtest 3.9.1 has caused the Debian Bug report #775092, regarding Make sure proxy variable exists before using it to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 775092: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=775092 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Source: autopkgtest Version: 3.9 Severity: minor Tags: patch Hi, adt-setup-vm uses a $proxy variable which will not exist if no proxy is locally configured. Because theadt-setup-vm script sets -u, this generates an error during vmbootstrap: Setting up networking Running customize script /usr/share/autopkgtest/adt-setup-vm /usr/share/autopkgtest/adt-setup-vm: 86: /usr/share/autopkgtest/adt-setup-vm: proxy: parameter not set Regards, Christian PS: This is a re-submission, as the first submission must have been eaten by the spam filter or something (had a dollar sign in subject). I refreshed the patch to apply after the fix in #775076. Regards, Christian>From 62362d85fede808b8a79fa22477133be1c43cc83 Mon Sep 17 00:00:00 2001 From: Christian Kastner <[email protected]> Date: Sun, 11 Jan 2015 00:36:32 +0100 Subject: adt-setup-vm: Make sure $proxy variable exists before using it On systems where apt is not configured to use a proxy, the apt-config query will return the empty string, the eval will be a nullop, and the following access to $proxy will print an error because the shell has -u set. --- tools/adt-setup-vm | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/tools/adt-setup-vm b/tools/adt-setup-vm index 030e785..b2f83d2 100755 --- a/tools/adt-setup-vm +++ b/tools/adt-setup-vm @@ -85,11 +85,13 @@ echo 'force-unsafe-io' > "$root"/etc/dpkg/dpkg.cfg.d/autopkgtest # auto-detect apt-cacher-ng if [ -z "${ADT_APT_PROXY:-}" ]; then RES=`apt-config shell proxy Acquire::http::Proxy` - eval $RES - if echo "$proxy" | egrep -q '(localhost|127\.0\.0\.[0-9]*):3142'; then - ADT_APT_PROXY="http://10.0.2.2:3142" - # set http_proxy for the initial apt-get update - export http_proxy="$proxy" + if [ -n "$RES" ]; then + eval $RES + if echo "$proxy" | egrep -q '(localhost|127\.0\.0\.[0-9]*):3142'; then + ADT_APT_PROXY="http://10.0.2.2:3142" + # set http_proxy for the initial apt-get update + export http_proxy="$proxy" + fi fi fi -- 2.1.4
--- End Message ---
--- Begin Message ---Source: autopkgtest Source-Version: 3.9.1 We believe that the bug you reported is fixed in the latest version of autopkgtest, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Martin Pitt <[email protected]> (supplier of updated autopkgtest package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Sun, 11 Jan 2015 12:53:18 +0100 Source: autopkgtest Binary: autopkgtest Architecture: source all Version: 3.9.1 Distribution: unstable Urgency: medium Maintainer: Autopkgtest team <[email protected]> Changed-By: Martin Pitt <[email protected]> Description: autopkgtest - automatic as-installed testing for Debian packages Closes: 775073 775075 775076 775092 Changes: autopkgtest (3.9.1) unstable; urgency=medium . [ Martin Pitt ] * Revert installation of ubuntu-device-flash in adt-run autopkgtest, it's too unstable (timeouts and grub errors due to qemu in qemu). . [ Christian Kastner ] * adt-run: Fix detection of dpkg-dev in the testbed. (Closes: #775073) * adt-setup-vm: Set umask to 0022 so that ordinary users in the testbed can read generated files. (Closes: #775075) * adt-setup-vm: Modify guest's dpkg config for enabling force-unsafe-io, not host's, when a root directory is specified as argument. (Closes: #775076) * adt-setup-vm: Make sure $proxy variable exists before using it. Fixes crash when apt is not configured to use a proxy. (Closes: #775092) Checksums-Sha1: 6ad10c33416c4cf5aae1560a2eb8351a2d6e91a1 1759 autopkgtest_3.9.1.dsc 32ae5806274027c7aa60b10caef8db3de434e34f 158760 autopkgtest_3.9.1.tar.gz 3240d192068e7155ee4ab71bd0fe1b717acb62c1 137278 autopkgtest_3.9.1_all.deb Checksums-Sha256: 4ea073995265f19e6bf890e67110ca618a952989c0113ca3c8a73b6b31bba129 1759 autopkgtest_3.9.1.dsc bc20c6dc88c73704d20f519843a02cb7e57f4b6a2a52850a91e0c5fa2a176bd6 158760 autopkgtest_3.9.1.tar.gz 7ff1ffaa6a4340beea554b281051e826dfdafff6ff20f3ef47757f5df5e6462a 137278 autopkgtest_3.9.1_all.deb Files: 8bab498e049ffe5b1464cde30d0191dd 1759 devel optional autopkgtest_3.9.1.dsc f979208184639dd60281bb4e70ae27b3 158760 devel optional autopkgtest_3.9.1.tar.gz 2648c9be1e285cbb8150f37626c5be43 137278 devel optional autopkgtest_3.9.1_all.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCAAGBQJUsmTyAAoJENFO8V2v4RNHsHcP/j0Oqk7AR84G9nIKgo1ZPRS7 PRsiNdidm9DlkRfNvztFadlZpwLKn5JUpMgss9p7PJDL23ruF3LtgIyUdExrFIYT 73eV4pP3LV9BDo1m63K6VpRaEo+BOwizBJDZNQzcc5Q0UuF9IhN508EMX6XPoMyA A6jAhvTj1ZU9TO4R0VYG48jU5tHf5G7xGLOGLyEKSX4MlZ+ZujySn1sq218iQJxO WWX5bNq3uULZULQODIxmHTs0YlWs28qbMFdtudZCcM6kTcPv67OKUi01VvqjvbzA ZjHTxVHDFhtv7a52Irlmu77I0G6gikH8GAbGjd89rPt8qzkinrMdFIJPcZNX6UfL K0V6l6RV5wZ6DoTnE5mBtTlScNy3XHnAO8+tYWl8cyli2ryuGTtpqpn1gNT7+9d0 a+X8x5of2jWldwvdfv/w/lvF/pcISre6w6Ox9tQNI2B6E4bod1l0cBGlrSLYqWga hvVwQphHtTdYgtMulD7xie2Y1Ygw4tTkUQBlr55W1hp2hbAyzbh79lDwLm247uU6 b+X3T7PJrc6GaVXJOOYmU5uJukvmaeyJFjtccClwiikFpXI+qIB+z+N7iEI6puFY 9N3qEpB7Lgb7uuXyoLe7YYUQENzf3YZsnXTyx86ZQB1BcC29yTiqHbRJspmDfUg2 /oc0oSAhv71V71RUMvJK =juPL -----END PGP SIGNATURE-----
--- End Message ---

