Your message dated Sat, 7 Feb 2015 23:44:16 +0100
with message-id <[email protected]>
and subject line Re: Bug#701275: faketime: ftbfs with GCC-4.8
has caused the Debian Bug report #701275,
regarding faketime: FTBFS with ld --as-needed
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
701275: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=701275
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: faketime
Version: 0.9.1-1
Severity: important
Tags: patch
User: [email protected]
Usertags: origin-ubuntu saucy ubuntu-patch
In Ubuntu, the attached patch was applied to achieve the following:
* as-needed.patch: Fix object/library link order for --as-needed.
When building with --as-needed, libraries need to be listed on the
link line after the objects that reference them. In the autotools
world (and elsewhere), the LDFLAGS variable has been split into
LDFLAGS and LDADD to represent the need to list libs last. This
patch makes that change to your Makefile, so this builds correctly
with --as-needed in LDFLAGS.
... Adam
-- System Information:
Debian Release: wheezy/sid
APT prefers saucy-updates
APT policy: (500, 'saucy-updates'), (500, 'saucy-security'), (500, 'saucy')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.9.0-4-generic (SMP w/4 CPU cores)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -Nru faketime-0.9.1/debian/changelog faketime-0.9.1/debian/changelog
diff -Nru faketime-0.9.1/debian/patches/as-needed.patch faketime-0.9.1/debian/patches/as-needed.patch
--- faketime-0.9.1/debian/patches/as-needed.patch 1969-12-31 17:00:00.000000000 -0700
+++ faketime-0.9.1/debian/patches/as-needed.patch 2013-06-11 07:50:42.000000000 -0600
@@ -0,0 +1,25 @@
+Description: Fix link order for --as-needed.
+Author: Adam Conrad <[email protected]>
+Forwarded: no
+
+--- faketime-0.9.1.orig/src/Makefile
++++ faketime-0.9.1/src/Makefile
+@@ -53,7 +53,8 @@ INSTALL ?= install
+ PREFIX ?= /usr/local
+
+ CFLAGS += -std=gnu99 -Wall -DFAKE_STAT -DFAKE_INTERNAL_CALLS -fPIC -DPOSIX_REALTIME -DLIMITEDFAKING -DSPAWNSUPPORT
+-LDFLAGS += -shared -ldl -lm -lpthread
++LDFLAGS += -shared
++LDADD += -ldl -lm -lpthread
+
+ SRC = faketime.c
+ OBJ = faketime.o faketimeMT.o
+@@ -69,7 +70,7 @@ ${OBJ}: faketime.c
+ ${CC} -o $@ -c ${CFLAGS} ${EXTRA_FLAGS} $<
+
+ lib%.so.${SONAME}: %.o
+- ${CC} -o $@ -Wl,-soname,$@ ${LDFLAGS} $<
++ ${CC} -o $@ -Wl,-soname,$@ ${LDFLAGS} $< ${LDADD}
+
+ clean:
+ @rm -f ${OBJ} ${LIBS}
diff -Nru faketime-0.9.1/debian/patches/series faketime-0.9.1/debian/patches/series
--- faketime-0.9.1/debian/patches/series 2013-06-09 17:33:51.000000000 -0600
+++ faketime-0.9.1/debian/patches/series 2013-06-11 07:46:19.000000000 -0600
@@ -1,2 +1,3 @@
fix-build-system.patch
fix-infinite-recursion-on-real_clock_gettime.patch
+as-needed.patch
--- End Message ---
--- Begin Message ---
Version: 0.9.5-1
Hi,
Matthias Klose wrote:
> Package: src:faketime
> Version: 0.8-1
[...]
> The package fails to build in a test rebuild on at least amd64 with
> gcc-4.8/g++-4.8, but succeeds to build with gcc-4.7/g++-4.7.
The upstream bug https://github.com/wolfcw/libfaketime/pull/19 has
been closed in June 2013. The next upstream release afterwards was
0.9.5. Jessie and Sid now have 0.9.6-3.
0.9.5-1 (which should contain the upstream fix) built fine with
gcc-4.8 as can be seen on
https://buildd.debian.org/status/fetch.php?pkg=faketime&arch=i386&ver=0.9.5-1&stamp=1382156766
and other build logs. It also built fine with gcc-4.9 as the most
recent build logs show, e.g. those of 0.9.6-3.
Hence closing this bug report as fixed with 0.9.5-1.
Regards, Axel
--
,''`. | Axel Beckert <[email protected]>, http://people.debian.org/~abe/
: :' : | Debian Developer, ftp.ch.debian.org Admin
`. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5
`- | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE
--- End Message ---
