Your message dated Wed, 15 Apr 2015 10:00:09 +0000
with message-id <[email protected]>
and subject line Bug#596232: fixed in sane-frontends 1.0.14-10
has caused the Debian Bug report #596232,
regarding scanadf sets SIGCHLD to SIG_IGN
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
596232: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=596232
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: sane
Version: 1.0.14-9
Severity: normal
Tags: patch

According to POSIX, “If the SIGCHLD signal is set to be ignored by the calling process image, it is unspecified whether [after an exec*() call] the SIGCHLD signal is set to be ignored or to the default action in the new process image.”[0]

scanadf sets SIGCHLD to SIG_IGN just before calling fork() and execle(). This action will be inherited by child processes on Linux and Hurd systems (though, apparently, not on kFreeBSD). This is certainly undesired behaviour, and breaks every program that expect this signal action to be set reasonably at startup (e.g. Python programs using the subprocess module).

The attached (untested) patch should fix this bug.

[0] http://www.opengroup.org/onlinepubs/009695399/functions/exec.html

--
Jakub Wilk
diff --git a/src/scanadf.c b/src/scanadf.c
--- a/src/scanadf.c
+++ b/src/scanadf.c
@@ -1195,6 +1195,7 @@
 
 	case 0:
 	  /*  in child process  */
+	  signal(SIGCHLD, SIG_DFL);
 	  sprintf(cmd, "%s '%s'", script, fname);
 	  /*	  system(cmd); */
 	  execle(script, script, fname, NULL, environ);

Attachment: signature.asc
Description: Digital signature


--- End Message ---
--- Begin Message ---
Source: sane-frontends
Source-Version: 1.0.14-10

We believe that the bug you reported is fixed in the latest version of
sane-frontends, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jörg Frings-Fürst <[email protected]> (supplier of updated 
sane-frontends package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 11 Feb 2015 08:00:08 +0100
Source: sane-frontends
Binary: sane sane-dbg
Architecture: source amd64
Version: 1.0.14-10
Distribution: unstable
Urgency: medium
Maintainer: Jörg Frings-Fürst <[email protected]>
Changed-By: Jörg Frings-Fürst <[email protected]>
Description:
 sane       - scanner graphical frontends
 sane-dbg   - scanner graphical frontends (debug symbols)
Closes: 596232 612686 670380
Changes:
 sane-frontends (1.0.14-10) unstable; urgency=medium
 .
   * New maintainer (Close: #688556).
   * debian/control:
     - Add myself as maintainer.
     - Bump Standards-Version to 3.9.6.
     - Package sane:
       - Add ${misc:Depends} to Depends.
       - Remove useless "Section: graphics".
     - Add homepage.
     - Add Vcs-* to new git repository.
   * debian/compat:
     - Change from 5 to 9.
   * New debian/source/format
     - Set to "3.0 (quilt)".
   * Convert patches from dpatch to quilt.
   * Rewrite debian/copyright.
   * Rewrite builtsystem to dh and DebSrc3.0 (Closes: #670380):
     - Rewrite debian/rules.
     - New sane.links
     - New sane.install
   * Add debian/watch.
   * debian/patches:
     - New 20_scanadf-SIGCHLD.patch (Closes: #596232):
       - Sets SIGCHLD to SIG_DFL before execle().
     - New 25_manpages-typo.patch (Closes: #612686):
       - Correct some typos.
   * New package sane-dbg.
Checksums-Sha1:
 53b7d3605896731e323b6d3c5dbb35b3bb97e70c 2022 sane-frontends_1.0.14-10.dsc
 063e11df3e32d7a43161fd37026a4dc601d5482d 231892 
sane-frontends_1.0.14.orig.tar.gz
 4429a02807ecf7a4e4d6841f4bfb3cae6dfa8dcb 14212 
sane-frontends_1.0.14-10.debian.tar.xz
 9c3734063d6811e501c5fb429a8574485771c4da 94482 sane_1.0.14-10_amd64.deb
 99773993dc94c40495620dbffcf3492845b53fb0 234852 sane-dbg_1.0.14-10_amd64.deb
Checksums-Sha256:
 670bf66f972568d09a209c0abea5b026ed8369115d5b174b86f277bf67ec3da7 2022 
sane-frontends_1.0.14-10.dsc
 e7839dac1b70b5bb39124615aba8a136f5275d0e78bafd3d52ed76964ffea4a9 231892 
sane-frontends_1.0.14.orig.tar.gz
 82a7cea41142dc8f9ffa51b84e6a74b4f364da01917ce7085bfc259dcee59e66 14212 
sane-frontends_1.0.14-10.debian.tar.xz
 9ae2ca333a2ad716bff543c6e2e3840a886cad4e302161fba4278efa4bbec916 94482 
sane_1.0.14-10_amd64.deb
 f808c23b153c40f115045d1b0250e864716a4d5b131ae36af0733c0311577bf0 234852 
sane-dbg_1.0.14-10_amd64.deb
Files:
 61b1bd5e87ca2d6bb8bcb342b01fb6b8 2022 graphics optional 
sane-frontends_1.0.14-10.dsc
 c63bf7b0bb5f530cf3c08715db721cd3 231892 graphics optional 
sane-frontends_1.0.14.orig.tar.gz
 8cdaaaf8efbe40cf42b9df5d0f354656 14212 graphics optional 
sane-frontends_1.0.14-10.debian.tar.xz
 0d2d4aa3448309b6323901a5ef835be2 94482 graphics optional 
sane_1.0.14-10_amd64.deb
 a3908615aefca14d857f7417b71b791d 234852 debug extra 
sane-dbg_1.0.14-10_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJU3ErWAAoJEIDTAvWIbYOc2FkP/3RLP0UJf8tvx+P/8S7TWmoF
bbRrCyjoF3iFfw4caMZM+1qVhiNRzwbdvcIhuJe8jO0voSCz0A09bOPWEL645u7O
trJEbHAwJrUuso0nWoz0dbC3U+DbT87EDULcMZbYUeY6SLt3bEPou5BkHj4RT118
AUS4ky3hSsbyi+Ht8v/xpjllUz5af/FfxxGdjgpijSnsZHqSmN4EoTRBVjQdoXke
M3FUmscSXmdIRNVZJA+VxuQ8BbVYJKzdrGRbVjIi4nBEIHpY910k8Ti9uJojXfzO
O4DP/DVNV1/ke61Io7Bo/iWZWXMZC+btKxGPIIP/GoFGUcdQE3hz8OFRO3MxvUpU
l6MCLzVXmRzTswfUuhc2LigrnoyS05/supipGKJ/p4QeqoX3MlM5n28yd+VwYuEU
hir2tncl7qZEaTHoG0zcqBWxw6zjpdTPezh/j3ssr0B1TQP1e2OpZziJfhBoAI/V
atwUDxA/OHPODGXnTruoziUh3y7YxvLLK3n9ZHY6+5+B642RJzlAq8StnbgnDcqY
Ki8op2gvMYpC2euF2nh90uu4E89K6AocY/FuVt1lmID0ts7vdLUs06j+m5sS7Cik
A9XOveWN3TDGMfmKiMGRsbwRi33PkmZQAhRJfG7EbGn0OeBwBCfkgMwDtRYZeWGQ
mB2L3ygJlJU9BkSlF51V
=liyy
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to