Your message dated Wed, 29 Apr 2015 23:18:57 +0000
with message-id <[email protected]>
and subject line Bug#773094: fixed in atomix 3.16.0-1
has caused the Debian Bug report #773094,
regarding atomix: FTBFS with ld --as-needed
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
773094: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=773094
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: atomix
Version: 2.14.0-5
Severity: normal
Tags: patch
User: [email protected]
Usertags: origin-ubuntu vivid ubuntu-patch
Dear Maintainer,
In Ubuntu, we use ld --as-needed by default in the toolchain, and you package
fails to build from source with that option enabled because of the way
libraries are linked.
Even though Debian doesn't use ld --as-needed by default, it is a good idea to
make this change so that (1) we don't have to maintain a delta and (2) you
don't need to change anything in case Debian makes this default in the future.
You can read more about this option here:
https://wiki.debian.org/ToolChain/DSOLinking#Only_link_with_needed_libraries
In Ubuntu, the attached patch was applied to achieve the following:
* debian/patches/underlinking.diff: Restore Robie Basak's patch from
2.14.0-2ubuntu2 to build with -lm to fix an underlinking FTBFS.
* Use dh-autoreconf so that the patch is applied.
* Remove unnecessary -lm addition in debian/rules for LDFLAGS.
Thanks for considering the patch.
Logan Rosen
-- System Information:
Debian Release: jessie/sid
APT prefers vivid-updates
APT policy: (500, 'vivid-updates'), (500, 'vivid-security'), (500, 'vivid'),
(100, 'vivid-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.16.0-25-generic (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -Nru atomix-2.14.0/debian/control atomix-2.14.0/debian/control
--- atomix-2.14.0/debian/control 2013-03-03 22:06:27.000000000 -0500
+++ atomix-2.14.0/debian/control 2014-12-14 03:25:27.000000000 -0500
@@ -4,8 +4,8 @@
Maintainer: Debian Games Team <[email protected]>
Uploaders: Markus Koschany <[email protected]>
Build-Depends:
- autotools-dev,
debhelper (>= 9),
+ dh-autoreconf,
gnome-common,
libglib2.0-dev,
libgnome2-dev,
diff -Nru atomix-2.14.0/debian/patches/series atomix-2.14.0/debian/patches/series
--- atomix-2.14.0/debian/patches/series 2013-03-03 22:06:27.000000000 -0500
+++ atomix-2.14.0/debian/patches/series 2014-12-04 23:47:07.000000000 -0500
@@ -1,2 +1,3 @@
desktop.patch
about.patch
+underlinking.diff
diff -Nru atomix-2.14.0/debian/patches/underlinking.diff atomix-2.14.0/debian/patches/underlinking.diff
--- atomix-2.14.0/debian/patches/underlinking.diff 1969-12-31 19:00:00.000000000 -0500
+++ atomix-2.14.0/debian/patches/underlinking.diff 2014-12-05 00:03:54.000000000 -0500
@@ -0,0 +1,15 @@
+Author: Robie Basak <[email protected]>
+Description: Build with -lm to fix FTBFS
+Bug: https://bugzilla.gnome.org/show_bug.cgi?id=697371
+Last-Update: 2013-04-05
+
+--- a/src/Makefile.am
++++ b/src/Makefile.am
+@@ -26,6 +26,7 @@
+
+ atomix_LDADD = \
+ libatomix.a \
++ -lm \
+ $(ATOMIX_LIBS)
+
+ noinst_LIBRARIES = libatomix.a
diff -Nru atomix-2.14.0/debian/rules atomix-2.14.0/debian/rules
--- atomix-2.14.0/debian/rules 2013-06-22 14:28:41.000000000 -0400
+++ atomix-2.14.0/debian/rules 2014-12-05 00:05:40.000000000 -0500
@@ -1,9 +1,9 @@
#!/usr/bin/make -f
-export DEB_LDFLAGS_MAINT_APPEND = -lm -Wl,--as-needed
+export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed
export DEB_BUILD_MAINT_OPTIONS = hardening=+all
%:
- dh $@ --parallel --with autotools_dev
+ dh $@ --parallel --with autoreconf
override_dh_auto_configure:
dh_auto_configure -- \
--- End Message ---
--- Begin Message ---
Source: atomix
Source-Version: 3.16.0-1
We believe that the bug you reported is fixed in the latest version of
atomix, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Markus Koschany <[email protected]> (supplier of updated atomix package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Wed, 29 Apr 2015 16:12:13 PDT
Source: atomix
Binary: atomix atomix-data
Architecture: source all
Version: 3.16.0-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Games Team <[email protected]>
Changed-By: Markus Koschany <[email protected]>
Description:
atomix - puzzle game for building molecules out of separate atoms
atomix-data - puzzle game for building molecules out of separate atoms -- data
Closes: 773094 780714
Changes:
atomix (3.16.0-1) unstable; urgency=medium
.
* Imported Upstream version 3.16.0. (Closes: #780714)
* debian/control:
- Use dh-autoreconf instead of autotools_dev.
- Add gettext, appstream-util and libgtk-3-dev to Build-Depends.
- Drop obsolete GNOME 2 build-dependencies.
- Use cgit for Vcs-Browser field.
- Update homepage field and use gnome.org address.
* Declare compliance with Debian Policy 3.9.6.
* Update debian/watch to detect newer upstream releases.
* Drop all patches. They were merged or fixed upstream.
* Add icon-path.patch.
Since DATADIR is /usr/share/games in Debian this patch is necessary for
finding atomix-icon.png. It can be dropped when upstream fixes the
installation path and installs the icon to the hicolor directory.
* atomix-data.install: Do not install obsolete gnome directory.
* Drop atomix-data.links and install the data to
/usr/share/games/atomix
* debian/rules:
- Remove dh_fixperms override.
- Do not add -lm to LDFLAGS and build with autoreconf. This ensures that
Atomix will not FTBFS on Ubuntu any more. (Closes: #773094)
- Use dh_install --fail-missing.
- Add datadir option to dh_auto_configure.
- Add get-orig-source target.
* atomix.install: Do not install non-existent /var/games directory.
* atomix-data.install: Install /usr/share/locale directory
* atomix-data.install: Install /usr/share/appdata directory.
* Update debian/copyright for new release
* Add clean file and ensure that Atomix can be built twice in a row.
* Add fix-incorrect-arrow-click-sensitivity.patch
Cherry-pick upstream commit f53a3905e790170b1ad5e7f9dcb0c78c7fe841f2
to fix a bug with selecting nearby atoms.
* Add fix-locale-dir.patch and fix incorrect directory of installed
translation files due to Debian specific datadir.
Checksums-Sha256:
a3a96667e01c3490db2d0498aec62f1dedc0ac29762a8881658e8c15f38023d3 2023
atomix_3.16.0-1.dsc
c0fa8b9888c2068c3254cb74854b0f1cff9c26dd937d020e162f2ddcaf68f7a4 232979
atomix_3.16.0.orig.tar.gz
b7915fff8eacc9e1c1f4c5bf95cb7670e0e30a48c95f691bd8b86fc73eb98675 11160
atomix_3.16.0-1.debian.tar.xz
9964845fd0eb70c9375c288b420543410171d2ac9de876f3f9848b467ed0c1ce 159280
atomix-data_3.16.0-1_all.deb
Checksums-Sha1:
9217ebd7accf4a1c827e64318af455726ff90ef3 2023 atomix_3.16.0-1.dsc
67509cba21640722fabcb185a3b8039d33c4456c 232979 atomix_3.16.0.orig.tar.gz
1bbc38ddc8d99a61aa0aee688ad3692381979860 11160 atomix_3.16.0-1.debian.tar.xz
de1ca93f783284ebd355227f6185259ac7643687 159280 atomix-data_3.16.0-1_all.deb
Files:
376cdfbe6159000cd3ba3fba85e45f31 2023 games optional atomix_3.16.0-1.dsc
f1f03e1d149cf133de9660fe30ddfa7c 232979 games optional
atomix_3.16.0.orig.tar.gz
9507b580fc917c616645f8891d20e3bc 11160 games optional
atomix_3.16.0-1.debian.tar.xz
4c55ced79dc49bdd9648733535f21c84 159280 games optional
atomix-data_3.16.0-1_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCAAGBQJVQWVRAAoJEI7tzBuqHzL/PJUQAKbP9Qt2Yt8RgvCfkB+69vPR
8whRp2dG7CXtxbs68uq7tJoEgb8SLHw4WErgtxn+4+mIlKsVNRRyak0U5zxpGY7K
EehTisXm/yB9fs5dWu6VtxJWc+QjpvzGC8tZx3LfJOnmzou/EcDrR1FplTfUGBKc
VTKoCqusjpQfqWAJpTX9fP5r4useqBFt/rPXAU+lnnAwL64WS+LkoBZNT+KUrnGb
ZmSkWJC5RQlcgiUEXotkj+bt48/nJWjicnCvxbu3s5dwhxTLCX7USOQvYq7Eo5l4
Be0xnK1JOgnoaIPucIVCkJoP0nB/+tM589qRcOM7LncEnM0887BiIBGuyg7uMjKA
pIEAisDlG18NWv76DX+lap35waG8w1KExHxofcbnoEqg08a6flGyT7oBmtDnzKkX
R3gIrFCLhSH8kY4A38hM0q2tVry27f4AkHCJh2bCJ/5kIJFJQ4SOshUii29NCp8h
O4rdM6U/f/WUJRVaUBp9B25kbDp8Aqsbq8S42Gg4vEGQkI5V5BUfkqREowE+voLF
Sbaaern3q3Hi7muTo3LSw28uueQ+kuHuAjpcA0mRc++AQ5425CINVyuBmes4tbyw
3F+kTyRpv1PIgRLXsRzlcc2C+tNE6ejYSm67qRUCepfxEPPjL3oa5U+D6GaVw5uc
k4PxhDbAJTcSId0qrccl
=L/3J
-----END PGP SIGNATURE-----
--- End Message ---
