Your message dated Sat, 20 Jun 2015 16:51:44 +0000
with message-id <[email protected]>
and subject line Bug#768982: fixed in libaudio-mpd-perl 2.000-4
has caused the Debian Bug report #768982,
regarding libaudio-mpd-perl: cannot connect to mpd via a Unix socket
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
768982: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=768982
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: libaudio-mpd-perl
Version: 2.000-1
Severity: wishlist
Tags: upstream patch
Forwarded: https://rt.cpan.org/Public/Bug/Display.html?id=99762
Since mpd 0.14 (2008) it has been possible for mpd to listen on an
AF_UNIX socket. Access is controlled by Unix filesystem permissions,
making a password unnecessary.
The convention seems to be to set MPD_HOST to the absolute path to the
socket, e.g. "/home/me/.cache/mpd.socket", ignoring MPD_PORT; and to
recognise these connections via the leading "/".
The attached patch adds support for this, and seems to be enough to
enable mpd-dynamic to work in this configuration. I already
submitted it upstream.
Regards,
S
-- System Information:
Debian Release: jessie/sid
APT prefers proposed-updates
APT policy: (500, 'proposed-updates'), (500, 'unstable'), (500, 'testing'),
(500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages libaudio-mpd-perl depends on:
ii libaudio-mpd-common-perl 2.002-1
ii libgetopt-euclid-perl 0.4.5-1
ii libio-socket-ip-perl 0.32-1
ii libmoose-perl 2.1213-1
ii libmoosex-has-sugar-perl 1.000004-1
ii libmoosex-semiaffordanceaccessor-perl 0.10-1
ii libproc-daemon-perl 0.14-2
ii perl 5.20.1-2
ii perl-base [libio-socket-ip-perl] 5.20.1-2
libaudio-mpd-perl recommends no packages.
Versions of packages libaudio-mpd-perl suggests:
ii mpd 0.19.1-1
-- no debconf information
>From 576d58da0194aab9733846de39575239b42c3016 Mon Sep 17 00:00:00 2001
From: Simon McVittie <[email protected]>
Date: Sun, 9 Nov 2014 15:51:39 +0000
Subject: [PATCH] Add patch to allow a mpd Unix socket
---
debian/changelog | 3 ++
...001-Recognise-MPD_HOST-.-as-a-Unix-socket.patch | 48 ++++++++++++++++++++++
debian/patches/series | 1 +
3 files changed, 52 insertions(+)
create mode 100644 debian/patches/0001-Recognise-MPD_HOST-.-as-a-Unix-socket.patch
create mode 100644 debian/patches/series
diff --git a/debian/changelog b/debian/changelog
index 5aeca83..3aa76ec 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -6,6 +6,9 @@ libaudio-mpd-perl (2.000-2) UNRELEASED; urgency=medium
[ gregor herrmann ]
* debian/control: update {versioned,alternative} (build) dependencies.
+ [ Simon McVittie ]
+ * Add patch to allow a mpd Unix socket
+
-- Salvatore Bonaccorso <[email protected]> Sat, 16 Aug 2014 09:29:38 +0200
libaudio-mpd-perl (2.000-1) unstable; urgency=low
diff --git a/debian/patches/0001-Recognise-MPD_HOST-.-as-a-Unix-socket.patch b/debian/patches/0001-Recognise-MPD_HOST-.-as-a-Unix-socket.patch
new file mode 100644
index 0000000..37248ce
--- /dev/null
+++ b/debian/patches/0001-Recognise-MPD_HOST-.-as-a-Unix-socket.patch
@@ -0,0 +1,48 @@
+From: Simon McVittie <[email protected]>
+Date: Thu, 23 Oct 2014 21:32:19 +0100
+Subject: Recognise MPD_HOST="/..." as a Unix socket
+
+---
+ lib/Audio/MPD.pm | 22 ++++++++++++++++------
+ 1 file changed, 16 insertions(+), 6 deletions(-)
+
+diff --git a/lib/Audio/MPD.pm b/lib/Audio/MPD.pm
+index 530ef29..ffab9fc 100644
+--- a/lib/Audio/MPD.pm
++++ b/lib/Audio/MPD.pm
+@@ -38,7 +38,7 @@ has collection => ( ro, lazy_build, isa=>'Audio::MPD::Collection' );
+ has playlist => ( ro, lazy_build, isa=>'Audio::MPD::Playlist' );
+ has version => ( rw );
+
+-has _socket => ( rw, isa=>'IO::Socket::IP' );
++has _socket => ( rw, isa=>'IO::Socket' );
+
+
+ #--
+@@ -93,11 +93,21 @@ sub _connect_to_mpd_server {
+ my ($self) = @_;
+
+ # try to connect to mpd.
+- my $socket = IO::Socket::IP->new(
+- PeerAddr => $self->host,
+- PeerPort => $self->port,
+- )
+- or die "Could not create socket: $!\n";
++ my $socket;
++
++ if ($self->host =~ m{^/}) {
++ eval q{use IO::Socket::UNIX qw(); 1}
++ or die "Could not load IO::Socket::UNIX: $@\n";
++ $socket = IO::Socket::UNIX->new($self->host)
++ or die "Could not create socket: $!\n";
++ }
++ else {
++ $socket = IO::Socket::IP->new(
++ PeerAddr => $self->host,
++ PeerPort => $self->port,
++ )
++ or die "Could not create socket: $!\n";
++ }
+
+ # parse version information.
+ my $line = $socket->getline;
diff --git a/debian/patches/series b/debian/patches/series
new file mode 100644
index 0000000..3f9f3b7
--- /dev/null
+++ b/debian/patches/series
@@ -0,0 +1 @@
+0001-Recognise-MPD_HOST-.-as-a-Unix-socket.patch
--
2.1.3
--- End Message ---
--- Begin Message ---
Source: libaudio-mpd-perl
Source-Version: 2.000-4
We believe that the bug you reported is fixed in the latest version of
libaudio-mpd-perl, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Damyan Ivanov <[email protected]> (supplier of updated libaudio-mpd-perl package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sat, 20 Jun 2015 16:36:18 +0000
Source: libaudio-mpd-perl
Binary: libaudio-mpd-perl
Architecture: source all
Version: 2.000-4
Distribution: unstable
Urgency: medium
Maintainer: Debian Perl Group <[email protected]>
Changed-By: Damyan Ivanov <[email protected]>
Description:
libaudio-mpd-perl - module to communicate with MPD servers
Closes: 768982
Changes:
libaudio-mpd-perl (2.000-4) unstable; urgency=medium
.
* Add patch from Simon McVittie enabling UNIX socket support for MPD_HOST
environment variable
(Closes: #768982)
Checksums-Sha1:
7bc3ea90579af14ec5e6adbf5571902bcc2c1f9d 2648 libaudio-mpd-perl_2.000-4.dsc
a4e47850af8d0ffe789c74f33ef53a4122442f86 5752
libaudio-mpd-perl_2.000-4.debian.tar.xz
0aecaad2fc28967aee7feba4486b4d88e8cfbe6a 44524
libaudio-mpd-perl_2.000-4_all.deb
Checksums-Sha256:
af8018bbd5e21a8a817b2e65b9aec26654499247d47fe1bacb548b0924631242 2648
libaudio-mpd-perl_2.000-4.dsc
b179f270b2b32921e380eab0154f5f43200f9962c783d429b58fbe5e61d5420b 5752
libaudio-mpd-perl_2.000-4.debian.tar.xz
55d33929dcec6a510db3d3eb1ceeaa41e89ba635d32b179a12cf682cfb255b6f 44524
libaudio-mpd-perl_2.000-4_all.deb
Files:
19ca10d0c1ea9be8b19840a2a42358ff 2648 perl optional
libaudio-mpd-perl_2.000-4.dsc
b3b184e1ed0bb77ca604eac0454e8c84 5752 perl optional
libaudio-mpd-perl_2.000-4.debian.tar.xz
17ca8a9e46c3a413ec30bb5a0f6dc23d 44524 perl optional
libaudio-mpd-perl_2.000-4_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCAAGBQJVhZcCAAoJENu+nU2Z0qAE4QQP/32MLNE2f1W0iggrlRA4epDS
BK5b1QZGIrhEhwl/ywU5KYvyz7bKokALS2DZlh23ovFm0br7loXUNYyi8CrU+0cv
20X1x6xtsZ7Pm0KZ13OeE/5b+hQrYdLW1bGOOQNEjBWnVA2vtABnG1E0MAQ0tN6q
RCPdB9Ddn0K7iAr+ywEwDQv2U+qllIwY4SYxxT9QwlkSbUCOool0ZUFMdH/oKupd
sDO593V7jwX53KTqAYxZ7Z00cTTH/Q6p1W+XFfH6aGcMDODLC6QUFoJ5zDwPxEPO
CM/ybGAcPWgfzgHb+EnuWK+hwD2kRaUI+t96AEvfThaTzVYRKVGdFdkwpIKMY2aG
DGPy2Iy9muwkELptS+16b25m2x6leZWKIixSzU/E8DAS2VOZtMxFXwRSU5RutFQh
+qKgfU3ZN5d8KGLy1XOmlaljo0G+O+6aQLv0wMrY14xW5bevGuPyBcc80TMzXXYU
OdFd1g6ev1P9qNpJY5BnbUn9+tSCdpmFvy2/vShs2wL4n8cpMrLSwHhTPHHIV/jR
Dm7RQNP/VGBQ140JU2qh9IbSNS5xcgzUFxgx4zG3VLwddM41dZRLXLX3RHI1l0rp
AjbNsieeNoZG+ab5Q/mXRR7ufdEI5uOBH8B3Z8Z1n3gPuoUbEUjHJd+BEUIdImoX
5da+ocEKz3oKeDxNaZCF
=EUcR
-----END PGP SIGNATURE-----
--- End Message ---
