Your message dated Mon, 22 Jun 2015 22:50:47 +0200
with message-id <[email protected]>
and subject line cfdisk restores cursor on ctrl-c under ncurses
has caused the Debian Bug report #757000,
regarding cfdisk: does not re-enable cursor when pressing Ctrl-C
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
757000: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=757000
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: util-linux
Version: 2.25-6
Severity: minor

Dear Andreas,

thanks for fixing the cursor re-enabling on ending cfdisk via menu (see
bug 755991). The fix works nicely.

Yet, on Ctrl-C cfdisk does not re-enable the cursor.

I believe the fix would be somewhere in ui_end():

 660 static void die_on_signal(int dummy __attribute__((__unused__)))
 661 {
 662 »·······DBG(FRONTEND, ul_debug("die on signal."));
 663 »·······ui_end();
 664 »·······exit(EXIT_FAILURE);
 665 }

As this is also called after ui_run()

2058 »·······/* Don't use err(), warn() from this point */
2059 »·······ui_init(cf);
2060 »·······ui_run(cf);
2061 »·······ui_end();

I believe the fix is to move curs_set(1); into from ui_run into ui_end.

I will provide a patch upstream in a moment.

Thanks,
Martin

-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (200, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.16.0-rc7-tp520-fixcompwrite+ (SMP w/4 CPU cores; PREEMPT)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages util-linux depends on:
ii  initscripts    2.88dsf-53.2
ii  libblkid1      2.25-6
ii  libc6          2.19-7
ii  libmount1      2.25-6
ii  libncurses5    5.9+20140712-2
ii  libpam0g       1.1.8-3
ii  libselinux1    2.3-1
ii  libslang2      2.2.4-17
ii  libsmartcols1  2.25-6
ii  libtinfo5      5.9+20140712-2
ii  libuuid1       2.20.1-5.8
ii  lsb-base       4.1+Debian13
ii  tzdata         2014e-1
ii  zlib1g         1:1.2.8.dfsg-1

util-linux recommends no packages.

Versions of packages util-linux suggests:
ii  dosfstools          3.0.26-3
ii  kbd                 1.15.5-1
ii  util-linux-locales  2.25-6

-- debconf information:
  util-linux/noauto-with-nonzero-passnum:

--- End Message ---
--- Begin Message ---
Package: util-linux
Version: 2.26.2-7

The above noted version (currently sitting in experimental)
switches to ncurses, instead of slang. This means the reported
problem with cursor not being restored on ctrl-c from cfdisk
no longer exists.

Regards,
Andreas Henriksson

--- End Message ---

Reply via email to