Your message dated Tue, 14 Jul 2015 17:33:46 +0000
with message-id <[email protected]>
and subject line Bug#792414: fixed in libparse-debianchangelog-perl 1.2.0-5
has caused the Debian Bug report #792414,
regarding libparse-debianchangelog-perl: Remove support for broken timezone
names
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
792414: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=792414
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: libparse-debianchangelog-perl
Version: 1.2.0-4
Severity: wishlist
Tags: patch
Hi!
As pointed out in
<https://lists.debian.org/debian-policy/2015/06/msg00034.html>, the
changelog trailer part of the regex to support timezone names is bogus.
And it seems the best thing to do is to remove it instead of fixing it.
For more details either see tha above mail or the commit message on the
attached patch. Beware, that the patch has not been tested!
Thanks,
Guillem
From ca50d8718c5e3f0cd334541c24d966a69e64c86e Mon Sep 17 00:00:00 2001
From: Guillem Jover <[email protected]>
Date: Tue, 14 Jul 2015 17:18:16 +0200
Subject: [PATCH] Parse::DebianChangelog: Remove support for broken timezone
names
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The Debian changelog trailer regex intended to support a timezone name
inside parenthesis, like this:
-- Name <[email protected]> Sat, 30 May 2015 03:18:43 +0200 (CEST)
is bogus, and it only accepts one character. As in:
-- Name <[email protected]> Sat, 30 May 2015 03:18:43 +0200 (C)
which while also “valid”, as per RFC822, they are pretty much useless
as per RFC5322. It seems the regex was “inherited” from the dpkg
implementation which has kept that part unchanged since its inception
in dpkg 1.3.0, 1996-08.
So let's just drop it instead of fixing the regex, given that the
timezone name has never been accepted, many time-parsing functions
ignore it, it is redundant, declared obsolete by RFC5322 and Debian
policy dropped an explicit reference to it due to bug 569174.
Signed-off-by: Guillem Jover <[email protected]>
---
lib/Parse/DebianChangelog.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/Parse/DebianChangelog.pm b/lib/Parse/DebianChangelog.pm
index dbb1531..fe31735 100644
--- a/lib/Parse/DebianChangelog.pm
+++ b/lib/Parse/DebianChangelog.pm
@@ -390,7 +390,7 @@ sub parse {
} elsif (m/^\S/) {
$self->_do_parse_error($file, $.,
__g( "badly formatted heading line" ), "$_");
- } elsif (m/^ \-\- (?<name>.*) <(?<email>.*)>(?<sep> ?)(?<date>(?:\w+\,\s*)?\d{1,2}\s+\w+\s+\d{4}\s+\d{1,2}:\d\d:\d\d\s+[-+]\d{4}(\s+\([^\\\(\)]\))?)$/o) {
+ } elsif (m/^ \-\- (?<name>.*) <(?<email>.*)>(?<sep> ?)(?<date>(?:\w+\,\s*)?\d{1,2}\s+\w+\s+\d{4}\s+\d{1,2}:\d\d:\d\d\s+[-+]\d{4})$/o) {
$expect eq 'more change data or trailer' ||
$self->_do_parse_error($file, $.,
__g( "found trailer where expected %s",
--
2.4.3.573.g4eafbef
--- End Message ---
--- Begin Message ---
Source: libparse-debianchangelog-perl
Source-Version: 1.2.0-5
We believe that the bug you reported is fixed in the latest version of
libparse-debianchangelog-perl, which is due to be installed in the Debian FTP
archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
gregor herrmann <[email protected]> (supplier of updated
libparse-debianchangelog-perl package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Tue, 14 Jul 2015 19:14:09 +0200
Source: libparse-debianchangelog-perl
Binary: libparse-debianchangelog-perl
Architecture: source all
Version: 1.2.0-5
Distribution: unstable
Urgency: medium
Maintainer: Debian Perl Group <[email protected]>
Changed-By: gregor herrmann <[email protected]>
Description:
libparse-debianchangelog-perl - parse Debian changelogs and output them in
other formats
Closes: 792414
Changes:
libparse-debianchangelog-perl (1.2.0-5) unstable; urgency=medium
.
* Team upload.
* Add patch to remove support for broken timezone names.
Thanks to Guillem Jover for the bug report and the patch.
(Closes: #792414)
Checksums-Sha1:
04270876028b1993d0b2b92961144d672369162d 2707
libparse-debianchangelog-perl_1.2.0-5.dsc
fb21d03edfa0acbb657adf73e63b7276384c4392 10680
libparse-debianchangelog-perl_1.2.0-5.debian.tar.xz
a8733c69020f46874c930dc48e0185d59fd78d69 58896
libparse-debianchangelog-perl_1.2.0-5_all.deb
Checksums-Sha256:
39757ad2b5bcfd3519e0dc0b69a5f314d8f4ec64be639a12037dd170d142f5bf 2707
libparse-debianchangelog-perl_1.2.0-5.dsc
e70908a8572a4eb939458ac2c2257a8233441a1b177e9afca642a5a36e556c94 10680
libparse-debianchangelog-perl_1.2.0-5.debian.tar.xz
f5b5d15ea917e296ea1bae08fc027ea03844dafa418a0d6d41bdd1ff65591311 58896
libparse-debianchangelog-perl_1.2.0-5_all.deb
Files:
0aeb0ae4dc76a1378a603967fc650afd 2707 perl optional
libparse-debianchangelog-perl_1.2.0-5.dsc
2b2479c98869635098b51db0bf1115c6 10680 perl optional
libparse-debianchangelog-perl_1.2.0-5.debian.tar.xz
dea26765eff26734dc9d9dcc79a4f535 58896 perl optional
libparse-debianchangelog-perl_1.2.0-5_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQJ8BAEBCgBmBQJVpUOfXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREMUUxMzE2RTkzQTc2MEE4MTA0RDg1RkFC
QjNBNjgwMTg2NDlBQTA2AAoJELs6aAGGSaoGiv0QALwe65IWpkFGV/G7/bl2ITS6
kbbyZHsnoKOmvmOnRC/rgCCIj/nQ1QiOcERs6vIBij3cGYXNQRoc55VPufDbzY6/
zBKeix2MJIpgbw4496cZpBuX6B0VKgB1aEe96fECaqcWwAe2TgWE6mQQtuERsJ37
ewCr2TM7yOdsvvoXMprOGfVvpk0JOPnseUvjhWCIQWpYWPjMOZJw2zIEhiBeW6Tq
F/LdHU7y3jSDz7wgSftkjW/uOvoOuL5TKZd+LritE3aBSV3t0hPugpLXkrjzwjKc
3pZaV03e8XprvtG8kk2xxHowBw/SrrbpRfx8XWy9xG++I6meL4L7qAqjxv+08njD
8s6HwkaaYkdrLHbxHFQgMViT9aJYRNHaCo1mZzssqHBt64bd0krxjoxx1ed+dBzK
grFAypPiXgL0psF30t4Lw4G3gDHeF7HI3QSgD6Ht9Hl+rUeq7HlvyL9GzzBFOzj8
U+w5ZgxHZMVTGkrA5wboWab+oHX1aUJkDpqei2M8FNhwv2d35iwJfMqPLbJ0nbU0
pPkgoYSBwUsT7zjuGIzsnZJr6w6e4BDvtH4IIiN52FXUZ7kyt5ajAbuXWiLA2KBH
nIE6c6doMYICpIgJD+goqbXpzWVHxH5zZuH3wGfptpYzxkqsZB73sZgnbRv5JIK8
83m4QLfigHpfUAE57276
=0Fn0
-----END PGP SIGNATURE-----
--- End Message ---
