Your message dated Tue, 21 Jul 2015 22:19:48 +0000
with message-id <[email protected]>
and subject line Bug#772346: fixed in dvbcut 0.5.4+svn178-10
has caused the Debian Bug report #772346,
regarding dvbcut: Use QT4 QInputEvent::modifiers instead of QT3
QT...Event::state()
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
772346: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=772346
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: dvbcut
Version: 0.5.4+svn178-9
Severity: normal
Tags: patch
I noticed that (atleast for me) pressing modifier-keys (Shift/Alt/Ctrl) while
navigating the video (either by using the mousewheel or cursor-keys) does not
change the step-size.
After changing the use QWheelEvent::state() (and QKeyEvent::state()) to
QInputEvent::modifier() in dvbcut::eventFilter() these work again.
(Since they are not documented, these are (by default):
without modifier: move 1500 frames =~ 1 minute (at 25fps)
Shift: 25 frames =~ 1 second
Ctrl: 1 frame
Alt: 22500 frames =~ 15 minutes)
(These are changable in the configfile. However the config is not written, I'll
post another patch in a seperate bugreport)
-- System Information:
Debian Release: jessie/sid
APT prefers testing-updates
APT policy: (500, 'testing-updates'), (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.16.0-4-amd64 (SMP w/8 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages dvbcut depends on:
ii liba52-0.7.4 0.7.4-17
ii libao4 1.1.0-3
ii libavcodec56 6:11-2
ii libavformat56 6:11-2
ii libavutil54 6:11-2
ii libc6 2.19-13
ii libgcc1 1:4.9.1-19
ii libmad0 0.15.1b-8
ii libqt4-network 4:4.8.6+git64-g5dc8b2b+dfsg-2+b1
ii libqt4-qt3support 4:4.8.6+git64-g5dc8b2b+dfsg-2+b1
ii libqt4-sql 4:4.8.6+git64-g5dc8b2b+dfsg-2+b1
ii libqt4-xml 4:4.8.6+git64-g5dc8b2b+dfsg-2+b1
ii libqtcore4 4:4.8.6+git64-g5dc8b2b+dfsg-2+b1
ii libqtgui4 4:4.8.6+git64-g5dc8b2b+dfsg-2+b1
ii libstdc++6 4.9.1-19
ii libswscale3 6:11-2
Versions of packages dvbcut recommends:
ii mplayer2 [mplayer] 2.0-728-g2c378c7-4+b1
dvbcut suggests no packages.
Author: Tim Riemenschneider <[email protected]>
Description: use the Qt4 QtInputEvent::modifiers() method instead of the Qt3 Q<Wheel|Key>Event::state()
(the later is not working anymore?)
--- a/src/dvbcut.cpp
+++ b/src/dvbcut.cpp
@@ -2144,17 +2144,24 @@
bool myEvent = true;
int delta = 0;
int incr = WHEEL_INCR_NORMAL;
+ Qt::KeyboardModifiers mods;
if (e->type() == QEvent::Wheel && watched != ui->jogslider) {
QWheelEvent *we = (QWheelEvent*)e;
// Note: delta is a multiple of 120 (see Qt documentation)
delta = we->delta();
- if (we->state() & Qt::Key_Alt)
+ mods = we->modifiers();
+ if(mods & Qt::AltModifier) {
incr = WHEEL_INCR_ALT;
- else if (we->state() & Qt::Key_Control)
+ } else if(mods & Qt::ControlModifier) {
incr = WHEEL_INCR_CTRL;
- else if (we->state() & Qt::Key_Shift)
+ } else if(mods & Qt::ShiftModifier) {
incr = WHEEL_INCR_SHIFT;
+ } else if(mods & Qt::MetaModifier) {
+ // TODO: do we want/need another step-size?
+ // incr = WHEEL_INCR_META;
+ }
+
}
else if (e->type() == QEvent::KeyPress) {
QKeyEvent *ke = (QKeyEvent*)e;
@@ -2163,12 +2170,17 @@
delta = -delta;
else if (ke->key() != Qt::Key_Left)
myEvent = false;
- if (ke->state() & Qt::Key_Alt)
+ mods = ke->modifiers();
+ if(mods & Qt::AltModifier) {
incr = WHEEL_INCR_ALT;
- else if (ke->state() & Qt::Key_Control)
+ } else if(mods & Qt::ControlModifier) {
incr = WHEEL_INCR_CTRL;
- else if (ke->state() & Qt::Key_Shift)
+ } else if(mods & Qt::ShiftModifier) {
incr = WHEEL_INCR_SHIFT;
+ } else if(mods & Qt::MetaModifier) {
+ // TODO: do we want/need another step-size?
+ // incr = WHEEL_INCR_META;
+ }
}
else
myEvent = false;
--- End Message ---
--- Begin Message ---
Source: dvbcut
Source-Version: 0.5.4+svn178-10
We believe that the bug you reported is fixed in the latest version of
dvbcut, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Bernhard Übelacker <[email protected]> (supplier of updated dvbcut package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Tue, 21 July 2015 18:08:10 +0200
Source: dvbcut
Binary: dvbcut
Architecture: source
Version: 0.5.4+svn178-10
Distribution: unstable
Urgency: medium
Maintainer: Bernhard Übelacker <[email protected]>
Changed-By: Bernhard Übelacker <[email protected]>
Description:
dvbcut - Qt application for cutting parts out of DVB streams
Closes: 772346 772413 793089
Changes:
dvbcut (0.5.4+svn178-10) unstable; urgency=medium
.
* Make storing of settings work with Qt4 (Closes: #772413)
* Make keyboard modifier for mousewheel work with Qt4 (Closes: #772346)
(Both found and fixed by Tim Riemenschneider, thanks)
* Add to help page the mousewheel keyboard modifiers
* Fix headless index creation on ARM architecture.
* Push stanards version to 3.9.6.
* Transition from libav to ffmpeg (Closes: #793089)
(Thanks to Sebastian Ramacher and Andreas Cadhalpun)
Checksums-Sha1:
ae336e8c391be4618f337b6061839b1b9d2e7083 1977 dvbcut_0.5.4+svn178-10.dsc
b12c35bcb74d0e80836e663751a86c69634c0121 49820
dvbcut_0.5.4+svn178-10.debian.tar.xz
Checksums-Sha256:
021423fdcdc229db4a3d13e86ae73629e0fad1fd847b541e71c8cd594818b3cb 1977
dvbcut_0.5.4+svn178-10.dsc
29dca30bb52b78427952c737b468877f100f98226026f32f67a5eba2b40e0d0d 49820
dvbcut_0.5.4+svn178-10.debian.tar.xz
Files:
bbc2ca093ea3c207a44131f60a54cd60 1977 graphics optional
dvbcut_0.5.4+svn178-10.dsc
819b04015bcc804c86a70c0acf13e607 49820 graphics optional
dvbcut_0.5.4+svn178-10.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCAAGBQJVrr+uAAoJEGny/FFupxmTC+MQAMJeOjTj6a0geSPFJxgXlqoB
MsJh2BEP6WGGB4uK0L7kIRZrArS2CMsbDljmKEJUNqTC0NiNLZKtyVPKdErlxkZ6
MPru4JQHzUdC7u82jX8XVAa5GKDWxl0nRzkAi1CiVJdKLKcPVm2pENOXDbWnZp5Z
nln9ecHgj8hM37PEORxfjrr3vBgJSuYbnjvViRHjl3pkVyNL22/V5J4MSCWaZy/t
V8ozOwR6d8kNwb0X1ivU8Q2qvt8VoyglxYgQs/g7yY3IvDdQKP3qkZHsCLoKF0yh
EP2AUrN2KAg1RmKA3/dZZiOpWKO9jf+qfoTqDMN5Jvd/yQEVTKBsVm/Uk/EAMrgO
LW0bpKxeSkNpg/aT19BEd9plwqg6MCmeMvYYvaLTPVni9rilGXIkJ42S63iBLgNL
Td1eejRCizPuPSMo70QSr6yFqMhO0RiZdWrjcv8OJMNP5RdvAM1tBkzSt/kOl8Bt
mJ22CjPaTEoZj2NY/Tx5dT+UvRRESMbkxFMxQR8g2umdR9wtMGjMVG1IlHVgbjzY
SU2+yzgGZrSr94E/CTXpzGJfbcr4SRPqhxdYA5Ls+xBgmYgMm2CQUGUi2bKfDcS/
+pPYV9MBEWo6V/7Tqhk1QEVoI1ghj0aquOuEiPFK9wRJdMtrRxF0Aev6ZvCGDTCo
c8aX+1NKEbEnW6jzn3Ag
=PcCQ
-----END PGP SIGNATURE-----
--- End Message ---
