Your message dated Wed, 29 Jul 2015 10:04:47 +0000
with message-id <[email protected]>
and subject line Bug#793944: fixed in haskell-devscripts 0.9.11
has caused the Debian Bug report #793944,
regarding haskell-devscripts: please support UTF-8 encoded debian/control files 
in dh_haskell_depends
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
793944: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=793944
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: haskell-devscripts
Version: 0.9.10
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: toolchain
X-Debbugs-Cc: [email protected]

Hi,

While working on the "reproducible builds" effort [1], we have noticed
that haskell-devscripts produces different packages depending on the
build locale.

This is due to grep(1) identifying a file as "binary" and thus returns
"binary file matches" instead of the actual lines that match and
therefore
the substvar files are not populated correctly.

This can be seen in the wild in "haskell-yi-language" where the unicode
ellipsis character in the package long description causes the resulting
package to have — or not have — a Recommends field based on whether it
was built in a UTF-8 locale or not.

The attached patch uses the -a switch to bypass grep's automagic.

 [1]: https://wiki.debian.org/ReproducibleBuilds


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      [email protected] / chris-lamb.co.uk
       `-
diff --git a/dh_haskell_depends b/dh_haskell_depends
index 97af37b..3ecebec 100644
--- a/dh_haskell_depends
+++ b/dh_haskell_depends
@@ -88,10 +88,10 @@ for pkg in `dh_listpackages $args`; do
                     echo "haskell:Recommends=" >> $sfile.tmp
                     doc=`echo $pkg | sed -e 's/-dev$/-doc/'`
                     prof=`echo $pkg | sed -e 's/-dev$/-prof/'`
-                    grep -v '^#' debian/control | grep $doc > /dev/null \
+                    grep -av '^#' debian/control | grep $doc > /dev/null \
                         && suggests="$doc" \
                         || suggests=""
-                    if grep -v '^#' debian/control | grep $prof > /dev/null
+                    if grep -av '^#' debian/control | grep $prof > /dev/null
                     then
                         [ "$suggests" = "" ] \
                             && suggests="$prof" \
@@ -143,7 +143,7 @@ for pkg in `dh_listpackages $args`; do
                 | sort -u \
                 | sed -e :a -e '$!N; s/\n/, /; ta'`
             dev=`echo $pkg | sed -e 's/^[^-]\+-\(.\+\)-doc/lib${hc}-\1-dev/'`
-            grep -v '^#' debian/control | grep $dev > /dev/null \
+            grep -av '^#' debian/control | grep $dev > /dev/null \
                 && recommends="$recommends, $dev" \
                 || recommends="$recommends"
             echo "haskell:Recommends=$recommends" >> $sfile.tmp

--- End Message ---
--- Begin Message ---
Source: haskell-devscripts
Source-Version: 0.9.11

We believe that the bug you reported is fixed in the latest version of
haskell-devscripts, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Joachim Breitner <[email protected]> (supplier of updated haskell-devscripts 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 29 Jul 2015 11:46:27 +0200
Source: haskell-devscripts
Binary: haskell-devscripts
Architecture: source all
Version: 0.9.11
Distribution: unstable
Urgency: medium
Maintainer: Debian Haskell Group 
<[email protected]>
Changed-By: Joachim Breitner <[email protected]>
Description:
 haskell-devscripts - Tools to help Debian developers build Haskell packages
Closes: 793944
Changes:
 haskell-devscripts (0.9.11) unstable; urgency=medium
 .
   [ Chris Lamb ]
   * make grep immune to locale chages (Closes: 793944)
Checksums-Sha1:
 206502f633bf9589107157898f9723fda1c962bb 1812 haskell-devscripts_0.9.11.dsc
 84ddf6c71f1701640310ae65475204120fe7066c 29136 haskell-devscripts_0.9.11.tar.xz
 c4ca1f2dab93a6f89b3ebd43d500024220ac64b8 36454 
haskell-devscripts_0.9.11_all.deb
Checksums-Sha256:
 7616c39118d7eee80a41ba4712e0bdd29e3d5a8b36c88c2f762faa69010c4e98 1812 
haskell-devscripts_0.9.11.dsc
 c57a57937a6ec8c319dba15b4ec7b015884c42c33411e1b99f5d5aea996a798c 29136 
haskell-devscripts_0.9.11.tar.xz
 39c7ced6dca5616e6b336075b83414f4439cd7fee18bf62ce0d7215d90c20465 36454 
haskell-devscripts_0.9.11_all.deb
Files:
 380f984a3f11adc01159aed7f0e3a40b 1812 haskell extra 
haskell-devscripts_0.9.11.dsc
 6630370b93cf120713bc79e48d72c2b9 29136 haskell extra 
haskell-devscripts_0.9.11.tar.xz
 597063f450984ff694db5fabfc7ed937 36454 haskell extra 
haskell-devscripts_0.9.11_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJVuKLPAAoJED2QirPw+/UfDf8P+wQQJ4IKZ8daC/GxRW3t4LOV
wv2YWLVvw/x+nwRmTybICG65fZtuApnmOLWWbbYhjsBux2kw7x0C653raP1OV/Bc
SgHqVUCkP5FLS0JWUo8ikMJ/rPkLAhm8CIyRO7crtsZqpuxTnBk3OIiu3bvTkz2H
PgjwfyTLJZaFBwhwHqNHgOsWDu6d49Dyhf73xoXAlFcP5zu218dKSb9DusYRcMzB
MffBLzUYFHDx+ay3iVMR7CC5uvJS516jlfjdnXZWbvU7g7F8GuYKtRoQm3643W9c
2Ae2sXgfMrZp0vOx/NIQhLKjXapKfMJYwyu5n8N0V9x1fD9Nl5HYucfZoH6qvkVK
/lPbXJVFACA44OGG5wjBN+Og+PTnno2oJ5jSQOKqjtZvfyAzP42EUF0ZIv7pIDXG
Ue5rnKMcyU6vCqZZmMRQsDMkBXDVhYmwl9LMJT9ZJeeByOY3eG1GM4jctPrFJ1E/
IWGUI47O85AhjueJkOQ3h/zcRM9SbeGMPybTOsNGTEo71goAufFReYFxKn70QrCM
OzPSJSy42EgzIARf6fX9qHQMQdHi4ArKRC1E3loxCA6vaD5Sz32h+PB3AuGFss01
+NKqZKBuZUfJ4zOFvBkZqgtUO/EwPaY/6cEMfRh30e6I+PMeZA8nf0CQUH5kPg54
hLDksd4pDrOfGlL1+xIT
=5qd5
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to