Your message dated Wed, 05 Aug 2015 13:50:16 +0000 with message-id <[email protected]> and subject line Bug#794437: fixed in redis 2:3.0.3-3 has caused the Debian Bug report #794437, regarding redis-server: systemd ExecStop is incorrect if port is changed to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 794437: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=794437 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: redis-server Version: 2:3.0.3-2 Severity: normal Howdy maintainer, If I change the port Redis listens on (e.g. to listen only on a UNIX socket), the ExecStop line in redis-server (which calls redis-cli shutdown) is then incorrect. When I try to stop redis-server, syslog shows: Aug 2 17:42:53 anthrax systemd[1]: Stopping Advanced key-value store... Aug 2 17:42:53 anthrax redis-cli[4099]: Could not connect to Redis at 127.0.0.1:6379: Connection refused Aug 2 17:42:53 anthrax systemd[1]: redis-server.service: Control process exited, code=exited status=1 Aug 2 17:42:53 anthrax systemd[1]: Stopped Advanced key-value store. Aug 2 17:42:53 anthrax systemd[1]: redis-server.service: Unit entered failed state. Aug 2 17:42:53 anthrax systemd[1]: redis-server.service: Failed with result 'exit-code'. Simply removing the ExecStop line fixes this (presumably systemd sends a SIGTERM or something to the process). This seems like a reasonable fix (looks like it's basically what `/etc/init.d/redis-server` does). Many thanks! Chris Here is a diff of my config file: --- /etc/redis/redis.conf.old 2015-08-02 17:41:21.752303689 -0700 +++ /etc/redis/redis.conf 2015-08-02 17:41:54.624572316 -0700 @@ -42,7 +42,7 @@ # Accept connections on the specified port, default is 6379. # If port 0 is specified Redis will not listen on a TCP socket. -port 6379 +port 0 # TCP listen() backlog. # @@ -67,8 +67,8 @@ # incoming connections. There is no default, so Redis will not listen # on a unix socket when not specified. # -# unixsocket /tmp/redis.sock -# unixsocketperm 700 +unixsocket /tmp/redis.sock +unixsocketperm 700 # Close the connection after a client is idle for N seconds (0 to disable) timeout 0 -- System Information: Debian Release: stretch/sid APT prefers testing APT policy: (900, 'testing'), (500, 'testing-updates') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 4.0.0-2-amd64 (SMP w/8 CPU cores) Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages redis-server depends on: ii adduser 3.113+nmu3 ii init-system-helpers 1.23 ii libc6 2.19-18 ii libjemalloc1 3.6.0-3 ii redis-tools 2:3.0.3-2 redis-server recommends no packages. redis-server suggests no packages. -- no debconf information
--- End Message ---
--- Begin Message ---Source: redis Source-Version: 2:3.0.3-3 We believe that the bug you reported is fixed in the latest version of redis, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Chris Lamb <[email protected]> (supplier of updated redis package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Wed, 05 Aug 2015 14:40:19 +0100 Source: redis Binary: redis-server redis-tools redis-sentinel Architecture: source amd64 Version: 2:3.0.3-3 Distribution: unstable Urgency: medium Maintainer: Chris Lamb <[email protected]> Changed-By: Chris Lamb <[email protected]> Description: redis-sentinel - Persistent key-value database with network interface (monitoring) redis-server - Persistent key-value database with network interface redis-tools - Persistent key-value database with network interface (client) Closes: 794437 Changes: redis (2:3.0.3-3) unstable; urgency=medium . * Replace ExecStop in systemd configuration with TimeoutStopSpec. Calls to `redis-cli shutdown` were not reliable if the port/UNIX socket had changed from the defaults (or is not accessible due to firewalling, permissions, etc.) . Note that we cannot simply remove ExecStop (hence TimeoutStopSpec) as we must wait for the server to fully shutdown - it may not have finished writing the dump file to disk and thus we would be risking silent data loss if it is SIGKILL'd. . Thanks to Chris Kuehl <[email protected]>. (Closes: #794437) Checksums-Sha1: 026d96be5f33b39108c032a93b0e8083a0a8bb82 1961 redis_3.0.3-3.dsc 24095b804ee14b5716ed81d83d8cbadc5fcf3025 29260 redis_3.0.3-3.debian.tar.xz feff690fcab117a0c2dea5d79294b02f5de1bcf7 14976 redis-sentinel_3.0.3-3_amd64.deb 8f2d6a1461273599f55011698c899011f9a9a070 348616 redis-server_3.0.3-3_amd64.deb cac2ba37d2ee610cd055c0be05f302c5fb1fcf50 97510 redis-tools_3.0.3-3_amd64.deb Checksums-Sha256: e05ebd47b10b087fb3ea1e5b86350425ab6c55428455a9a2d92539cdba0886c1 1961 redis_3.0.3-3.dsc 701a09d0bfd347844378f033411e0a39027b8f289a5cecd865045cfb3c664a9c 29260 redis_3.0.3-3.debian.tar.xz 0f89284593b2008d38456edfc631107b2d0222f0742ade3edb52ccd17817b947 14976 redis-sentinel_3.0.3-3_amd64.deb 9d67330c4f14b18ba7ec268143a4669b3c7d0cf16eae2a1cc3e5a906d2857836 348616 redis-server_3.0.3-3_amd64.deb 9330d00a9e8b368f7b5636f570196e043fae442e9b05d3ece4a3a957095006e1 97510 redis-tools_3.0.3-3_amd64.deb Files: 30d22c612e470ce4054a308cd49a80ca 1961 database optional redis_3.0.3-3.dsc 64005e07cb27e871f5030a077c4da4dc 29260 database optional redis_3.0.3-3.debian.tar.xz fd251b3bdc806ddcba41e40fadbaead4 14976 database optional redis-sentinel_3.0.3-3_amd64.deb 116a61f5374ea17ca4835ecc93ea5693 348616 database optional redis-server_3.0.3-3_amd64.deb cc25c1d240c180b9e8da525859c82e9a 97510 database optional redis-tools_3.0.3-3_amd64.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCAAGBQJVwhK3AAoJEB6VPifUMR5YmgAQAIHzN+xWfJaRAXGLh7e/9HgY 11m/o96YUW/gZXH61H7yTpGE+nMp10uJBf7NbC6kLJBd3kNrRcfeEqgwzr3Xiwef pT7QckhnHuptkQ9HCtG+jUvjGx1vz8rtZWU3OetBZ66UcOB/9bk4KOcTBYk3iyqw QXhPxH9Ve5Y/rt0Qr+mmJYuvI7PXU3ihZfL5JZXe2b4z6L0ulATMqgX3vJOlKaSq pxLAKAxL/xLNP30GVteD9dhB1C2t0IT/+PYddJLPGpwBXS1i3EJxiLDnuET6tk2h CN1+hb6AKQu9dgMa/JmY+btVoDB4VOPs4Nln3jDSompP1rK+U5ai9Uk87NsED92G tweOLcqQIqCzoe3gYwA7dJe/vN1hgM3NRVw/iXzEf2Z/8Ou8szz1p4KIZWo2IAiJ dbxcPGOCcLMybpQpzZG3InqBovquMCGL9NAo2BLLhCWZI9QH56qOLlXluY21Yhlg 1XBr0Lf6ALG4d4VRbF6mxN5/S+2ovXr5WsWAHc0VapNNP53YESvwDQndIuYnsp3M aLGkd6FS7JrTS9UavJF1FTw6RnIMymxvsmTA5A29zKD4OpFvI3qCptschILNclsj cTWY65iy21EeAX2spypsyundDx0zZmZIDXXG3HzkoDnae1nKN7+oOQmefIWEvQXL 8WP6eFT3MerOHQicQKaH =3CQr -----END PGP SIGNATURE-----
--- End Message ---
