Your message dated Tue, 18 Aug 2015 15:17:15 +0200
with message-id <[email protected]>
and subject line Re: Bug#781528: PersonForm has wrong error message about ldap
record when am approved
has caused the Debian Bug report #781528,
regarding PersonForm has wrong error message about ldap record when am approved
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
781528: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=781528
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: nm.debian.org
Severity: minor
Tags: patch
Hi
I am a DM.
My application process is in state "AM approved".
When I go to https://nm.debian.org/am/person/nirgal I have this message
> Jean-Michel Vourgère already has an LDAP record (finger
> [email protected]), so their name, uid and email cannot be changed
> here. The email address can be changed using the db.debian.org LDAP
> Gateway.
I do not have an account yet, so I expected another message.
restricted/templates/restricted/person.html does test
> if "edit_ldap" not in vperms.perms
but backend.models.PersonVisitorPermissions._can_edit_ldap_fields
returns False when visitor is not admin and progress==PROGRESS_AM_OK.
Attached is a proposal of an alternative message.
Cheers
--
Nirgal
diff --git a/restricted/templates/restricted/person.html b/restricted/templates/restricted/person.html
index b8e4796..b2b0ec0 100644
--- a/restricted/templates/restricted/person.html
+++ b/restricted/templates/restricted/person.html
@@ -24,10 +24,14 @@
{% if "edit_ldap" not in vperms.perms %}
<p>
-{{person.fullname}} already has an LDAP record (<tt>finger
-{{person.uid}}@db.debian.org</tt>), so their name, uid and email cannot be
-changed here. The email address can be changed using the
-<a href="https://db.debian.org/doc-mail.html";>db.debian.org LDAP Gateway</a>.
+Name, uid and email cannot be changed here:<br>
+Either {{person.fullname}} already has an LDAP record (<tt>finger
+{{person.uid}}@db.debian.org</tt>): In that case the email address can be
+changed using the
+<a href="https://db.debian.org/doc-mail.html";>db.debian.org LDAP Gateway</a>;
+<br>
+Or {{person.fullname}} application progress is past the point where you are
+allowed to change these data from here.
</p>
{% endif %}
signature.asc
Description: OpenPGP digital signature
--- End Message ---
--- Begin Message ---
On Mon, Mar 30, 2015 at 03:18:29PM +0000, Jean-Michel Nirgal Vourgère wrote:
> Attached is a proposal of an alternative message.
Thanks! I applied and pushed the patch, it'll be deployed soon.
Enrico
--
GPG key: 4096R/E7AD5568 2009-05-08 Enrico Zini <[email protected]>
signature.asc
Description: Digital signature
--- End Message ---
