Your message dated Sat, 05 Sep 2015 21:52:40 +0000
with message-id <[email protected]>
and subject line Bug#691090: fixed in isc-dhcp 4.3.3-1
has caused the Debian Bug report #691090,
regarding dhclient-script.kfreebsd: fix undefined $..._arg variables
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
691090: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=691090
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: isc-dhcp-client
Version: 4.2.4-3
Severity: important
Tags: patch

Hi,

dhclient-script.kfreebsd refers to undefined variables $metric_arg and
$alias_subnet_arg iwhich should be replaced by their 'alternate value expansion'
equivalents:
* $metric_arg       ->  ${IF_METRIC:+metric $IF_METRIC}
* $alias_subnet_arg ->  ${alias_subnet_mask:+netmask $alias_subnet_mask}

These variables are oversights/remnants from previous changes.

The attached patch should fix the issue.

Thanks for maintaining isc-dhcp in Debian
Peter


-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (500, 'stable'), (1, 
'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages isc-dhcp-client depends on:
ii  debianutils      4.3.2
ii  iproute          20120521-3
ii  isc-dhcp-common  4.2.2.dfsg.1-5+deb70u2
ii  libc6            2.13-35

isc-dhcp-client recommends no packages.

Versions of packages isc-dhcp-client suggests:
pn  avahi-autoipd  <none>
pn  resolvconf     <none>

-- Configuration Files:
/etc/dhcp/dhclient.conf changed [not included]

-- no debconf information
>From b628d26b45ac88e96e5ce019b09a37f07df0e61e Mon Sep 17 00:00:00 2001
From: Peter Marschall <[email protected]>
Date: Sun, 21 Oct 2012 13:18:21 +0200
Subject: [PATCH 2/2] dhclient-script.kfreebsd: fix undefined $metric_arg and
 $alias_subnet_arg

Replace $metric_arg and $alias_subnet_arg by their 'alternate value expansion'
equivalents:
* $metric_arg       ->  ${IF_METRIC:+metric $IF_METRIC}
* $alias_subnet_arg ->  ${alias_subnet_mask:+netmask $alias_subnet_mask}

It looks as if this regression has been introduced in
ed89ff46c4032bc80d8bf25f7990121be6bd8570 and only partially fixed in
1a169bc2929ef9ba449cca80b271084d1b29f201.

Signed-off-by: Peter Marschall <[email protected]>
---
 debian/dhclient-script.kfreebsd |   14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/debian/dhclient-script.kfreebsd b/debian/dhclient-script.kfreebsd
index abd0e78..54cc9de 100644
--- a/debian/dhclient-script.kfreebsd
+++ b/debian/dhclient-script.kfreebsd
@@ -173,9 +173,9 @@ case "$reason" in
         if [ -z "$old_ip_address" ] ||
            [ "$old_ip_address" != "$new_ip_address" ] ||
            [ "$reason" = "BOUND" ] || [ "$reason" = "REBOOT" ]; then
-	    # FIXME: metric_arg is not defined
             ifconfig $interface inet $new_ip_address ${new_subnet_mask:+netmask $new_subnet_mask} \
-                                ${new_broadcast_address:+broadcast $new_broadcast_address} $mtu_arg $metric_arg $medium
+                                ${new_broadcast_address:+broadcast $new_broadcast_address} \
+                                $mtu_arg ${IF_METRIC:+metric $IF_METRIC} $medium
             route add $new_ip_address 127.1 >/dev/null 2>&1
             for router in $new_routers; do
               # If the subnet is captive, eg the netmask is /32 but the default
@@ -250,8 +250,7 @@ case "$reason" in
         fi
 
         if [ -n "$alias_ip_address" ]; then
-	    # FIXME: alias_subnet_arg is not defined
-            ifconfig $interface inet alias $alias_ip_address $alias_subnet_arg
+            ifconfig $interface inet alias $alias_ip_address ${alias_subnet_mask:+netmask $alias_subnet_mask}
             route add $alias_ip_address 127.0.0.1
         fi
 
@@ -263,9 +262,9 @@ case "$reason" in
             route delete $alias_ip_address 127.0.0.1 > /dev/null 2>&1
         fi
 
-	# FIXME: metric_arg is not defined
         ifconfig $interface inet $new_ip_address ${new_subnet_mask:+netmask $new_subnet_mask} \
-                              ${new_broadcast_address:+broadcast $new_broadcast_address} $mtu_arg $metric_arg $medium
+                              ${new_broadcast_address:+broadcast $new_broadcast_address} \
+                              $mtu_arg ${IF_METRIC:+metric $IF_METRIC} $medium
         sleep 1
 
 
@@ -274,8 +273,7 @@ case "$reason" in
           if ping -q -c 1 $1; then
             if [ x$new_ip_address != x$alias_ip_address ] && \
                               [ x$alias_ip_address != x ]; then
-	      # FIXME: alias_subnet_arg is not defined
-              ifconfig $interface inet alias $alias_ip_address $alias_subnet_arg
+              ifconfig $interface inet alias $alias_ip_address ${alias_subnet_mask:+netmask $alias_subnet_mask}
               route add $alias_ip_address 127.0.0.1
             fi
             route add $new_ip_address 127.1 >/dev/null 2>&1
-- 
1.7.10.4


--- End Message ---
--- Begin Message ---
Source: isc-dhcp
Source-Version: 4.3.3-1

We believe that the bug you reported is fixed in the latest version of
isc-dhcp, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Michael Gilbert <[email protected]> (supplier of updated isc-dhcp package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 05 Sep 2015 19:20:42 +0000
Source: isc-dhcp
Binary: isc-dhcp-server isc-dhcp-dbg isc-dhcp-server-ldap isc-dhcp-common 
isc-dhcp-dev isc-dhcp-client isc-dhcp-client-udeb isc-dhcp-relay
Architecture: source
Version: 4.3.3-1
Distribution: unstable
Urgency: medium
Maintainer: Debian ISC DHCP maintainers <[email protected]>
Changed-By: Michael Gilbert <[email protected]>
Description:
 isc-dhcp-client - DHCP client for automatically obtaining an IP address
 isc-dhcp-client-udeb - ISC DHCP Client for debian-installer (udeb)
 isc-dhcp-common - common files used by all of the isc-dhcp packages
 isc-dhcp-dbg - ISC DHCP server for automatic IP address assignment (debuging 
sym
 isc-dhcp-dev - API for accessing and modifying the DHCP server and client state
 isc-dhcp-relay - ISC DHCP relay daemon
 isc-dhcp-server - ISC DHCP server for automatic IP address assignment
 isc-dhcp-server-ldap - DHCP server that uses LDAP as its backend
Closes: 604883 635897 688339 691090 790164 797276
Changes:
 isc-dhcp (4.3.3-1) unstable; urgency=medium
 .
   * New upstream release.
   * Add uversionmangle to debian/watch.
   * Restore Enhances field for the ldap package (closes: #790164).
   * Add a logcheck snippet for the server package (closes: #688339).
     - Thanks to Jonathan Wiltshire.
   * Add DHCPv6 support to dhclient-script.linux.udeb (closes: #635897).
     - Thanks to Colin Watson.
   * Add policycoreutils dependency to isc-dhcp-server (closes: #797276).
   * Fix undefined variables in dhclient-script.kfreebsd (closes: #691090).
     - Thanks to Peter Marschall.
   * Avoid condition where hostname could be set to '(none)' (closes: #604883).
     - Thanks to Pavel Cahyna.
Checksums-Sha1:
 a3f3631e5be4c968db7c2f5fda19dc946527324a 3224 isc-dhcp_4.3.3-1.dsc
 0d8bdb50245f744e1b361ddb693072955ea3bded 1094938 isc-dhcp_4.3.3.orig.tar.gz
 edbb1eeed2399e5c333bd5bb2fe6625f469ace7a 79444 isc-dhcp_4.3.3-1.debian.tar.xz
Checksums-Sha256:
 129caf8947632b61f3e38a400b94a4b9cbe1c49e69bf66c301eca0faa7c9cd2a 3224 
isc-dhcp_4.3.3-1.dsc
 13d2bbc4536dfb2cd8f0fb0ac33a4bc7acec7ac013eb82ff44597de191b97dcb 1094938 
isc-dhcp_4.3.3.orig.tar.gz
 c5d5f8e92cabbea9124587e172c70c79a5597789fa3d0bcd51fd14a1e2cd965d 79444 
isc-dhcp_4.3.3-1.debian.tar.xz
Files:
 5b6fdcc01e02351b197c62b081378d2a 3224 net important isc-dhcp_4.3.3-1.dsc
 b8aab8e7aff6c6ebade443732425c78d 1094938 net important 
isc-dhcp_4.3.3.orig.tar.gz
 04b40775d3b5c192cab49f8398138a62 79444 net important 
isc-dhcp_4.3.3-1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQQcBAEBCgAGBQJV60v5AAoJELjWss0C1vRzfMQgAJtH3XXI3RGt+ZZ9UWahFuiG
+6fKFfQ+kOgcNAIfcqTriOrja3twFuwqW6K6ZwigOoTfPZuayeeGGk/icx11STHm
nmB7mdBrtF1JYL8la0BUKQzhB/AxjXxi5mYWBTHHgqb5FB5R6nndIoLWlDP/0VvJ
eZ3R3gIUM1bbZEBmdCKjtf1jyjLRWO0PiVR/hV5DAP4An3TMe+/TNiIDsOP313oz
HSfUekQincR3OY4h21Kk6vTlr89KrFcQGbSxKkE2fvjtJBhQzGJZLVVOdK/Y2OMb
ipsNBjkpSu/xxA6Mxva1wsVtroccZSUhPrjLkTkXgv5AVQJfGURn8VqwIPIqj1yM
RWE4Q4s96hHA0MdtbXhH31huBSLFplNSqQwg81E3sTGJ0Ljuq9VPbkLqXiRr63y1
ceb/TSZ3Nl5113zegEaIABmudL1hvkkVTCLheC2VXJZSk4n4LkBnzP2wxaZnYGca
q6B+ppUAQEt1SXJiFJ2Npa2mU0molfVJ39lOPfgrKlZd/lAMesiWnWNKi2smpjFM
N+42IXUYkPXTVAR2yA8b1J3WX8OQdN1nT+G/uoDHv7UfUZ7RcrAl8AmZO1KEcZBX
bGzkFWcLZohFpwFaVf+UrCivNPjKy649gTWAmUoala1zy4PN9W2MN7gmBcgXlyTz
mZPqjmwwF7qVp9INlVh0I5iv0vMK4QgU24srEJ+7FU012uhRLnJiI/zJUsWf+Wih
jNvW3pU1KfY0ppmfTlEm72lbRzlTPlHQkcHc8ECbSeqdgB6vqEMD6Z1pm0TZCBeW
CpLfGvWwza+kpp+N8MGxRzmwuqOKvP7vNEVnH35J48yLuSDI5qpP026A5LAlHFql
6ojSfGSAOFUlchK43VlARX1st5AdekIyRjwhmrAP0qx7Qvw31EkDdH3BKOmXi0jK
KpSRBIKJ39MxnXCmO7ZenIoScmKN2JtLvry+iexvS8vUuczTYBz1nMdpMFEjwQqY
xZyUcWBHwzZS72xPHn3AM31PVhnYuLX8Cqt8G2HtL3sCRWQJtv0suPx1s04ZCTeY
izS/nI8AfaCsl4OxiOawuhCbccBn5saYWqIJ/FKkLcDVqrpOJ9/Twl72m9o8qGW0
ROl61tEUtrpNobeVZ3AkC9oGKIdabIkDMslSknwrXgJx1pqx6yo7mxNcufpaCxcR
nxfl6t9zVhfDpp5D9aYJUILMBUTuLXW7CTG2VuTBFL5ehf3hGWQh8rQQzr+/Qaef
hnAXLrnDrF5Il3Yab7J13Lk8KMMHh0RHoGGRtLuanLZhkZAquLHdUdBgnPhBBQ64
s5Gqt7IQ7gkvRBpjmNAnuN/XAtPvC0tLxTZLTzD7VdEIeRb4xSo3pO4gKPmH+gU=
=fsvN
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to