Your message dated Sun, 06 Sep 2015 00:19:37 +0000
with message-id <[email protected]>
and subject line Bug#792637: fixed in guile-2.0 2.0.11+1-10
has caused the Debian Bug report #792637,
regarding guile-2.0: doesn't handle DEB_BUILD_OPTIONS correctly
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
792637: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=792637
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: guile-2.0
Version: 2.0.11+1-9
Severity: important
Tags: patch
The debian/rules file in the guile-2.0 package tries to handle various
DEB_BUILD_OPTIONS flags (nostrip, debug, noopt) manually, but as far
as I can tell it doesn't work properly.
First of all, the logic seems to be wrong: Debian policy seems to
imply that packages should always be compiled with debugging
information (i.e. CFLAGS should contain -g); and that debugging
symbols should be subsequently stripped on installation, unless
"nostrip" is specified:
https://www.debian.org/doc/debian-policy/ch-source.html#s-debianrules-options
However, the rules in the guile-2.0 package only try to add -g to
CFLAGS if "debug" occurs in D_B_O, meaning that "nostrip" on its own
has no effect, as there are no debugging symbols to strip in the first
place.
In fact, even if you specify "debug", the CFLAGS get overridden in the
override_dh_auto_configure stanza. Thus AFAICT, regardless of what, if
anything, you specify in DEB_BUILD_OPTIONS, guile ends up being
compiled without -O2 or -g.
(I found it useful to export DH_VERBOSE=1 when debugging these issues,
to see which compile flags are actually used.)
I would suggest removing the explicit handling of DEB_BUILD_OPTIONS
from debian/rules, and leaving it to dh_auto_configure to supply
correct build flags. (It invokes dpkg-buildflags, which handles "noopt"
automatically. You can arrange for the -DPACKAGE_PACKAGER* flags to be
appended to CFLAGS using DEB_CFLAGS_MAINT_APPEND.)
Similarly, I suggest leaving the stripping of binaries to dh_strip,
which will respect "nostrip".
A beneficent side-effect of letting dpkg-buildflags do the work is
that the correct hardening flags are also set.
Note that debian policy doesn't mention or specify the semantics of
"debug" in DEB_BUILD_OPTIONS. It shouldn't be necessary simply to get
a build with debugging symbols, "nostrip" alone should produce that. I
don't think that the guile package needs to handle "debug" at all.
The following patch implements the suggested changes:
--- a/debian/rules
+++ b/debian/rules
@@ -70,20 +70,10 @@ endef
DEB_HOST_GNU_TYPE ?= $(shell dpkg-architecture -qDEB_HOST_GNU_TYPE)
DEB_BUILD_GNU_TYPE ?= $(shell dpkg-architecture -qDEB_BUILD_GNU_TYPE)
-deb_cflags := \
- -DPACKAGE_PACKAGER='\"Debian\"' \
-
-DPACKAGE_PACKAGER_VERSION='\"$(upstream_ver)-deb+$(deb_src_src_rev)-$(deb_src_rev)\"'
\
- -DPACKAGE_PACKAGER_BUG_REPORTS='\"http://www.debian.org/Bugs/Reporting\";'
-
-ifneq (,$(findstring debug,$(DEB_BUILD_OPTIONS)))
- CFLAGS += -g
-endif
-ifeq (,$(findstring noopt,$(DEB_BUILD_OPTIONS)))
- CFLAGS += -O2
-endif
-ifeq (,$(findstring nostrip,$(DEB_BUILD_OPTIONS)))
- INSTALL_PROGRAM += -s
-endif
+export DEB_CFLAGS_MAINT_APPEND := \
+ -DPACKAGE_PACKAGER='"Debian"' \
+
-DPACKAGE_PACKAGER_VERSION='"$(upstream_ver)-deb+$(deb_src_src_rev)-$(deb_src_rev)"'
\
+ -DPACKAGE_PACKAGER_BUG_REPORTS='"http://www.debian.org/Bugs/Reporting";'
# When this is eventually removed, remove the guile-snarf sed below.
ifeq (arm,$(DEB_HOST_ARCH_CPU))
@@ -159,7 +149,7 @@ override_dh_autoreconf:
dh_autoreconf ./autogen.sh
override_dh_auto_configure:
- CFLAGS="$(deb_cflags)" dh_auto_configure -- --disable-error-on-warning
+ dh_auto_configure -- --disable-error-on-warning
# Let libtool forget about hardcoding -rpath into the libraries
sed -i -e "s/^[[:space:]]*hardcode_into_libs=.*/hardcode_into_libs=no/"
libtool
--- End Message ---
--- Begin Message ---
Source: guile-2.0
Source-Version: 2.0.11+1-10
We believe that the bug you reported is fixed in the latest version of
guile-2.0, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Rob Browning <[email protected]> (supplier of updated guile-2.0 package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sat, 05 Sep 2015 17:55:26 -0500
Source: guile-2.0
Binary: guile-2.0 guile-2.0-dev guile-2.0-doc guile-2.0-libs
Architecture: source amd64 all
Version: 2.0.11+1-10
Distribution: unstable
Urgency: medium
Maintainer: Rob Browning <[email protected]>
Changed-By: Rob Browning <[email protected]>
Description:
guile-2.0 - GNU extension language and Scheme interpreter
guile-2.0-dev - Development files for Guile 2.0
guile-2.0-doc - Documentation for Guile 2.0
guile-2.0-libs - Core Guile libraries
Closes: 764532 792637
Changes:
guile-2.0 (2.0.11+1-10) unstable; urgency=medium
.
* Don't handle DEB_BUILD_OPTIONS manually
.
* Restore default gcc on arm. It appears that armhf has been fixed.
Thanks to Aurelien Jarno <[email protected]> for the report. In
conjunction with switching to the default Debian build flags, it
looks like armel may work now too. (Closes: 764532, 792637)
Checksums-Sha1:
922569cc65301540f7e0d1ce9d740e9b0dd476ba 2085 guile-2.0_2.0.11+1-10.dsc
fed8c0749d84cae4a9a8e3b98b9fed3bc4458630 25028
guile-2.0_2.0.11+1-10.debian.tar.xz
c68151cfe06bf6e06114e3ee32b02fb9ba08d082 716234
guile-2.0-dev_2.0.11+1-10_amd64.deb
8f7cc70b7749847233caa6f4550a52f5840418bc 861680
guile-2.0-doc_2.0.11+1-10_all.deb
8d655dc0d2544b73d3290fda7003fac4364fc7cf 2249016
guile-2.0-libs_2.0.11+1-10_amd64.deb
adcbc01c7e853ad52d6bff006a67d178c0b40515 18584 guile-2.0_2.0.11+1-10_amd64.deb
Checksums-Sha256:
8ff27aa45154dbc169c9b7ed455d72811d180ca5181fb9be4dd1771e07abad15 2085
guile-2.0_2.0.11+1-10.dsc
798b222f1b056aaca76409d8ad374bcd011888eadadee47c3aee73acd7f27376 25028
guile-2.0_2.0.11+1-10.debian.tar.xz
6c3dadca99e3481f7fc00a3a0e4b669e8ecea21336550f3ae66bba55c58890a6 716234
guile-2.0-dev_2.0.11+1-10_amd64.deb
4b5aa845c2a6f162ae9a2521c4347067cc5ecdc878f754e7895c4bf131218d18 861680
guile-2.0-doc_2.0.11+1-10_all.deb
1d525e2bb476793ed1ad69a5d86db62dd603185b373213e1c3ed703f60db36bb 2249016
guile-2.0-libs_2.0.11+1-10_amd64.deb
2f433581de7e947180c9e21decad26204c00b43f71089167381e9a31d3db16da 18584
guile-2.0_2.0.11+1-10_amd64.deb
Files:
a93dc97b44b7459796b1a35f3536f604 2085 interpreters optional
guile-2.0_2.0.11+1-10.dsc
a02214cea8a1096ba5f123780bebbb42 25028 interpreters optional
guile-2.0_2.0.11+1-10.debian.tar.xz
209b4f1db8788d44b14e0318666faced 716234 lisp optional
guile-2.0-dev_2.0.11+1-10_amd64.deb
c75f38a75536c1414c48df671c9d17f9 861680 doc optional
guile-2.0-doc_2.0.11+1-10_all.deb
f690829803d31d5c239aa1dd0aa0198e 2249016 lisp optional
guile-2.0-libs_2.0.11+1-10_amd64.deb
f7d0f799a5c29b7f9d2716527432b8a1 18584 lisp optional
guile-2.0_2.0.11+1-10_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCAAGBQJV638lAAoJEO7xFsVaWkLxgyIP+wWkhOB3893iFXSOKGYsEG2D
stD19/qx9glVuK+7u0ZpPFYnuFuMxabO6u7eWhBf3aPfHdt7FvuJWXd4j5/QcbLv
XgcWQoSqiIsO96ZAfpFUYnaFk0sZVpC1UyCj9G9s2O7xC/vn7KBsT5w/bAMFeCHe
NE5ZyAr+f977DeA4OxLLf/6pEskHX1CI40y7kuLS4QypYRMQOlBNaBuiHEVDg2N5
esaUy8gtiUrf+y7rQEkDArsFeNqNEqISusC8Qwg6J2eGAKB3Cwa5Jtd7zv/8N1KU
FWUcScoz5gK6MbstTE55gSlBXbt1kaORIEyx9P1MF276hrkRtnbq2RGCHHsbvnAm
YoYQKsj29F14CUgCu/hHYdqvI23OITyQy0r0pCatOE2V8Q54R001EumF0VdFpkMC
KGCmH9wradXD8d8uIpt5ool7n+1Mpep/wXM/sq82EpwVT9Lg+MxY2lL5fa82cBzs
BcYnlvy4GS43mLR8jyPecXYKz3dtRKiDJunXaZmfQvGnEzQ93SXfBOdsmFkxhz2m
fUn/95uqPZQ/bvYnMzJXfIkI8Gw/fhyVv+Tl+MwXRHxjEJwQq5/iqdPW7an72moA
MtDFAdvl+NoQC5lS3FJndpDcFsooPlAlmdl4oQyZq9oqZDkQk2izMNXbCB+aLSq4
Ye9UgMVxj+gykAkCRniP
=WjpU
-----END PGP SIGNATURE-----
--- End Message ---
