Your message dated Thu, 10 Sep 2015 22:20:04 +0000
with message-id <[email protected]>
and subject line Bug#797711: fixed in libkinosearch1-perl 1.01-3
has caused the Debian Bug report #797711,
regarding libkinosearch1-perl: make the build reproducible
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
797711: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=797711
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: libkinosearch1-perl
Version: 1.01-2
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: fileordering
X-Debbugs-Cc: [email protected]
While working on the "reproducible builds" effort [0], we have noticed
that the XS code generated by Build.PL depends on the order of the source
files as returned by File::Find, which is nondeterministic. The attached
patch fixes this.
Please note that this package is also affected by the Module::Build
linking order issue (#797709) so this fix alone is not sufficient
to make the build reproducible. However, I've verified that the two
together make things work for me.
[0] https://wiki.debian.org/ReproducibleBuilds
--
Niko Tyni [email protected]
>From efa36d64ab5be55a03deebf2fa91a4938de57fef Mon Sep 17 00:00:00 2001
From: Niko Tyni <[email protected]>
Date: Fri, 28 Aug 2015 22:49:22 +0300
Subject: [PATCH] Sort the list of source files when generating XS code
The order of the file list affects generated code, so nondeterminism
there renders the build unreproducible.
The $first trick is a tad inelegant, but a custom sort() function
that would put Kinosearch1.pm first would probably be more confusing.
---
Build.PL | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/Build.PL b/Build.PL
index 50a466a..31fbd4f 100644
--- a/Build.PL
+++ b/Build.PL
@@ -37,10 +37,11 @@ my %source_pm = ();
# grab all .pm filepaths, making sure that KinoSearch1.pm is first
my @pm_filepaths;
+my $first;
find(
{ wanted => sub {
if ( $File::Find::name =~ /KinoSearch1\.pm$/ ) {
- unshift @pm_filepaths, $File::Find::name;
+ $first = $File::Find::name;
}
elsif ( $File::Find::name =~ /\.pm$/ ) {
push @pm_filepaths, $File::Find::name;
@@ -51,6 +52,8 @@ find(
'lib',
);
+@pm_filepaths = ( $first, sort @pm_filepaths );
+
for my $pm_filepath (@pm_filepaths) {
open( my $module_fh, '<', $pm_filepath )
or die "couldn't open file '$pm_filepath': $!";
--
2.1.4
--- End Message ---
--- Begin Message ---
Source: libkinosearch1-perl
Source-Version: 1.01-3
We believe that the bug you reported is fixed in the latest version of
libkinosearch1-perl, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Florian Schlichting <[email protected]> (supplier of updated libkinosearch1-perl
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Thu, 10 Sep 2015 23:40:43 +0200
Source: libkinosearch1-perl
Binary: libkinosearch1-perl
Architecture: source amd64
Version: 1.01-3
Distribution: unstable
Urgency: medium
Maintainer: Debian Perl Group <[email protected]>
Changed-By: Florian Schlichting <[email protected]>
Description:
libkinosearch1-perl - Perl library providing search engine features
Closes: 797711
Changes:
libkinosearch1-perl (1.01-3) unstable; urgency=medium
.
* Team upload
.
* Add debian/upstream/metadata
* Add patch by ntyni to make build reproducible (closes: #797711)
* Add spelling.patch fixing a typo
Checksums-Sha1:
dbeac916b36805aec129882b00da6f4e79fc4429 2169 libkinosearch1-perl_1.01-3.dsc
6f722c8cd73870458c913333578194795fcee6f7 4008
libkinosearch1-perl_1.01-3.debian.tar.xz
54b7bbdf2742c40b78e937ade5e02d872a06684f 254312
libkinosearch1-perl_1.01-3_amd64.deb
Checksums-Sha256:
f91ceb071ff6fb4caf79059a927a5a6ecab8f70f7a901feb7ceb50c6734825be 2169
libkinosearch1-perl_1.01-3.dsc
3bfef398a2f816c825d879599443a4c7892e4d67844b18116c679f57d2f28e6f 4008
libkinosearch1-perl_1.01-3.debian.tar.xz
79d8b6bc4209826a4331d742d741b71407f85e61e5bbd6a0afabc224621f42ac 254312
libkinosearch1-perl_1.01-3_amd64.deb
Files:
ae80506e9abcb283345f9978b2f60bde 2169 perl optional
libkinosearch1-perl_1.01-3.dsc
27f2ea1c9a2bccd71d378f2b5dec9462 4008 perl optional
libkinosearch1-perl_1.01-3.debian.tar.xz
86a9af89ca606b4441f2d4a15f87eae1 254312 perl optional
libkinosearch1-perl_1.01-3_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCAAGBQJV8fsqAAoJEBKXO25y3Ae1XXcP/1WfSrqu4jQhhEFu2YIKJ3lP
1Cnf1yA5ROcMiDx7t1W7QeMcNi28oI1N0JVX83yidWLnu2hKircixoqqQneA4x46
Df6vmCBMinJsp7b8B9K4Qq1s0K2X2ytMpsGg8w7l1TxxyPGT9zGHWguEqAqlxjyd
HhVWbUCAUhnk+v5VilQKlRTJvekjTaqbNBvX3/uV/neT1ZzwPpRQUCAy+bp+qoHk
YojVBmtLupdsnzTEMn9eCajBRUO9dKeJGaPuQ3Sd7W4+izL4ZlakuZ24fGIA7oLV
ZxYJTHRUbKw7gsyMlcmAtF4z90S7L9V1kPYdgfR3rKG5EHrNHPtyC9WZwXR6wUQX
np591R0qbv8u8WxfOmxSugbqDAfMaanxMqkZMwcHy2lTeAGkf4xYmIfC+GAo5hwn
UuUchB24OEyRprlU3vVrLrPaKkiW8b394u8RsHqPoMuOjteXpN0KpurlS+VKAVls
EjK01V60M640sk3KY5ue+Nid+6PJ55/62DYWRSEITfvgggqouPl9yInSCOaD9M0j
OGn60drM3Wm+hMVpmlXWipFruI4SAmnQb+sXYUpC0dzrI+zRjnNv1KHuAoQHf+9R
JbRp6Shx8axiqdDva9qHl8GNIFmYC1IYUb4POkPtKOtWtKQhW7pStn290QJgK8Fq
c5cNY9egj3y0Nh4fN84X
=5s2K
-----END PGP SIGNATURE-----
--- End Message ---
