Your message dated Mon, 21 Sep 2015 12:34:01 +0000
with message-id <[email protected]>
and subject line Bug#777989: fixed in lmms 1.1.3-1
has caused the Debian Bug report #777989,
regarding lmms: ftbfs with GCC-5
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
777989: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=777989
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: src:lmms
Version: 1.0.3-5
Severity: normal
Tags: sid stretch
User: [email protected]
Usertags: ftbfs-gcc-5
Please keep this issue open in the bug tracker for the package it
was filed for. If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.
The package fails to build in a test rebuild on at least amd64 with
gcc-5/g++-5, but succeeds to build with gcc-4.9/g++-4.9. The
severity of this report may be raised before the stretch release.
The full build log can be found at:
http://people.debian.org/~doko/logs/gcc5-20150205/lmms_1.0.3-5_unstable_gcc5.log
The last lines of the build log are at the end of this report.
To build with GCC 5, either set CC=gcc-5 CXX=g++-5 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.
apt-get -t experimental install g++
Common build failures are C11 as the default C mode, new warnings
resulting in build failures with -Werror turned on, or new/dropped
symbols in Debian symbols files. For other C/C++ related build failures
see the porting guide at http://gcc.gnu.org/gcc-5/porting_to.html
[...]
[ 26%] Building CXX object CMakeFiles/lmms.dir/src/tracks/AutomationTrack.o
/usr/bin/c++ -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NO_DEBUG -DQT_XML_LIB
-D_REENTRANT -O2 -g -fno-exceptions -Wall -Werror=unused-function
-Wno-sign-compare -Wno-strict-overflow -Werror -g -O2 -fstack-protector-strong
-Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -fPIC -DPIC -isystem
/usr/include/qt4 -isystem /usr/include/qt4/QtGui -isystem
/usr/include/qt4/QtXml -isystem /usr/include/qt4/QtCore
-I/«PKGBUILDDIR»/obj-x86_64-linux-gnu
-I/«PKGBUILDDIR»/obj-x86_64-linux-gnu/include -I/«PKGBUILDDIR»
-I/«PKGBUILDDIR»/include -I/usr/include/SDL
-D'QT_TRANSLATIONS_DIR="/usr/share/qt4/translations"'
-D'LIB_DIR="../lib/x86_64-linux-gnu/"'
-D'PLUGIN_DIR="../lib/x86_64-linux-gnu/lmms/"' -o
CMakeFiles/lmms.dir/src/tracks/AutomationTrack.o -c
/«PKGBUILDDIR»/src/tracks/AutomationTrack.cpp
/usr/bin/cmake -E cmake_progress_report
/«PKGBUILDDIR»/obj-x86_64-linux-gnu/CMakeFiles
[ 26%] Building CXX object CMakeFiles/lmms.dir/src/core/song.o
/usr/bin/c++ -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NO_DEBUG -DQT_XML_LIB
-D_REENTRANT -O2 -g -fno-exceptions -Wall -Werror=unused-function
-Wno-sign-compare -Wno-strict-overflow -Werror -g -O2 -fstack-protector-strong
-Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -fPIC -DPIC -isystem
/usr/include/qt4 -isystem /usr/include/qt4/QtGui -isystem
/usr/include/qt4/QtXml -isystem /usr/include/qt4/QtCore
-I/«PKGBUILDDIR»/obj-x86_64-linux-gnu
-I/«PKGBUILDDIR»/obj-x86_64-linux-gnu/include -I/«PKGBUILDDIR»
-I/«PKGBUILDDIR»/include -I/usr/include/SDL
-D'QT_TRANSLATIONS_DIR="/usr/share/qt4/translations"'
-D'LIB_DIR="../lib/x86_64-linux-gnu/"'
-D'PLUGIN_DIR="../lib/x86_64-linux-gnu/lmms/"' -o
CMakeFiles/lmms.dir/src/core/song.o -c /«PKGBUILDDIR»/src/core/song.cpp
/usr/bin/cmake -E cmake_progress_report
/«PKGBUILDDIR»/obj-x86_64-linux-gnu/CMakeFiles
[ 26%] Building CXX object CMakeFiles/lmms.dir/src/core/DataFile.o
/usr/bin/c++ -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NO_DEBUG -DQT_XML_LIB
-D_REENTRANT -O2 -g -fno-exceptions -Wall -Werror=unused-function
-Wno-sign-compare -Wno-strict-overflow -Werror -g -O2 -fstack-protector-strong
-Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -fPIC -DPIC -isystem
/usr/include/qt4 -isystem /usr/include/qt4/QtGui -isystem
/usr/include/qt4/QtXml -isystem /usr/include/qt4/QtCore
-I/«PKGBUILDDIR»/obj-x86_64-linux-gnu
-I/«PKGBUILDDIR»/obj-x86_64-linux-gnu/include -I/«PKGBUILDDIR»
-I/«PKGBUILDDIR»/include -I/usr/include/SDL
-D'QT_TRANSLATIONS_DIR="/usr/share/qt4/translations"'
-D'LIB_DIR="../lib/x86_64-linux-gnu/"'
-D'PLUGIN_DIR="../lib/x86_64-linux-gnu/lmms/"' -o
CMakeFiles/lmms.dir/src/core/DataFile.o -c
/«PKGBUILDDIR»/src/core/DataFile.cpp
/usr/bin/cmake -E cmake_progress_report
/«PKGBUILDDIR»/obj-x86_64-linux-gnu/CMakeFiles
[ 26%] Building CXX object CMakeFiles/lmms.dir/src/core/Piano.o
/usr/bin/c++ -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NO_DEBUG -DQT_XML_LIB
-D_REENTRANT -O2 -g -fno-exceptions -Wall -Werror=unused-function
-Wno-sign-compare -Wno-strict-overflow -Werror -g -O2 -fstack-protector-strong
-Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -fPIC -DPIC -isystem
/usr/include/qt4 -isystem /usr/include/qt4/QtGui -isystem
/usr/include/qt4/QtXml -isystem /usr/include/qt4/QtCore
-I/«PKGBUILDDIR»/obj-x86_64-linux-gnu
-I/«PKGBUILDDIR»/obj-x86_64-linux-gnu/include -I/«PKGBUILDDIR»
-I/«PKGBUILDDIR»/include -I/usr/include/SDL
-D'QT_TRANSLATIONS_DIR="/usr/share/qt4/translations"'
-D'LIB_DIR="../lib/x86_64-linux-gnu/"'
-D'PLUGIN_DIR="../lib/x86_64-linux-gnu/lmms/"' -o
CMakeFiles/lmms.dir/src/core/Piano.o -c /«PKGBUILDDIR»/src/core/Piano.cpp
/usr/bin/cmake -E cmake_progress_report
/«PKGBUILDDIR»/obj-x86_64-linux-gnu/CMakeFiles
[ 26%] Building CXX object CMakeFiles/lmms.dir/src/core/Model.o
/usr/bin/c++ -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NO_DEBUG -DQT_XML_LIB
-D_REENTRANT -O2 -g -fno-exceptions -Wall -Werror=unused-function
-Wno-sign-compare -Wno-strict-overflow -Werror -g -O2 -fstack-protector-strong
-Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -fPIC -DPIC -isystem
/usr/include/qt4 -isystem /usr/include/qt4/QtGui -isystem
/usr/include/qt4/QtXml -isystem /usr/include/qt4/QtCore
-I/«PKGBUILDDIR»/obj-x86_64-linux-gnu
-I/«PKGBUILDDIR»/obj-x86_64-linux-gnu/include -I/«PKGBUILDDIR»
-I/«PKGBUILDDIR»/include -I/usr/include/SDL
-D'QT_TRANSLATIONS_DIR="/usr/share/qt4/translations"'
-D'LIB_DIR="../lib/x86_64-linux-gnu/"'
-D'PLUGIN_DIR="../lib/x86_64-linux-gnu/lmms/"' -o
CMakeFiles/lmms.dir/src/core/Model.o -c /«PKGBUILDDIR»/src/core/Model.cpp
/usr/bin/cmake -E cmake_progress_report
/«PKGBUILDDIR»/obj-x86_64-linux-gnu/CMakeFiles 55
[ 27%] Building CXX object CMakeFiles/lmms.dir/src/core/ProjectJournal.o
/usr/bin/c++ -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NO_DEBUG -DQT_XML_LIB
-D_REENTRANT -O2 -g -fno-exceptions -Wall -Werror=unused-function
-Wno-sign-compare -Wno-strict-overflow -Werror -g -O2 -fstack-protector-strong
-Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -fPIC -DPIC -isystem
/usr/include/qt4 -isystem /usr/include/qt4/QtGui -isystem
/usr/include/qt4/QtXml -isystem /usr/include/qt4/QtCore
-I/«PKGBUILDDIR»/obj-x86_64-linux-gnu
-I/«PKGBUILDDIR»/obj-x86_64-linux-gnu/include -I/«PKGBUILDDIR»
-I/«PKGBUILDDIR»/include -I/usr/include/SDL
-D'QT_TRANSLATIONS_DIR="/usr/share/qt4/translations"'
-D'LIB_DIR="../lib/x86_64-linux-gnu/"'
-D'PLUGIN_DIR="../lib/x86_64-linux-gnu/lmms/"' -o
CMakeFiles/lmms.dir/src/core/ProjectJournal.o -c
/«PKGBUILDDIR»/src/core/ProjectJournal.cpp
/usr/bin/cmake -E cmake_progress_report
/«PKGBUILDDIR»/obj-x86_64-linux-gnu/CMakeFiles
[ 27%] Building CXX object CMakeFiles/lmms.dir/src/core/bb_track_container.o
/usr/bin/c++ -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NO_DEBUG -DQT_XML_LIB
-D_REENTRANT -O2 -g -fno-exceptions -Wall -Werror=unused-function
-Wno-sign-compare -Wno-strict-overflow -Werror -g -O2 -fstack-protector-strong
-Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -fPIC -DPIC -isystem
/usr/include/qt4 -isystem /usr/include/qt4/QtGui -isystem
/usr/include/qt4/QtXml -isystem /usr/include/qt4/QtCore
-I/«PKGBUILDDIR»/obj-x86_64-linux-gnu
-I/«PKGBUILDDIR»/obj-x86_64-linux-gnu/include -I/«PKGBUILDDIR»
-I/«PKGBUILDDIR»/include -I/usr/include/SDL
-D'QT_TRANSLATIONS_DIR="/usr/share/qt4/translations"'
-D'LIB_DIR="../lib/x86_64-linux-gnu/"'
-D'PLUGIN_DIR="../lib/x86_64-linux-gnu/lmms/"' -o
CMakeFiles/lmms.dir/src/core/bb_track_container.o -c
/«PKGBUILDDIR»/src/core/bb_track_container.cpp
/usr/bin/cmake -E cmake_progress_report
/«PKGBUILDDIR»/obj-x86_64-linux-gnu/CMakeFiles
[ 27%] Building CXX object CMakeFiles/lmms.dir/src/core/NotePlayHandle.o
/usr/bin/c++ -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NO_DEBUG -DQT_XML_LIB
-D_REENTRANT -O2 -g -fno-exceptions -Wall -Werror=unused-function
-Wno-sign-compare -Wno-strict-overflow -Werror -g -O2 -fstack-protector-strong
-Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -fPIC -DPIC -isystem
/usr/include/qt4 -isystem /usr/include/qt4/QtGui -isystem
/usr/include/qt4/QtXml -isystem /usr/include/qt4/QtCore
-I/«PKGBUILDDIR»/obj-x86_64-linux-gnu
-I/«PKGBUILDDIR»/obj-x86_64-linux-gnu/include -I/«PKGBUILDDIR»
-I/«PKGBUILDDIR»/include -I/usr/include/SDL
-D'QT_TRANSLATIONS_DIR="/usr/share/qt4/translations"'
-D'LIB_DIR="../lib/x86_64-linux-gnu/"'
-D'PLUGIN_DIR="../lib/x86_64-linux-gnu/lmms/"' -o
CMakeFiles/lmms.dir/src/core/NotePlayHandle.o -c
/«PKGBUILDDIR»/src/core/NotePlayHandle.cpp
/usr/bin/cmake -E cmake_progress_report
/«PKGBUILDDIR»/obj-x86_64-linux-gnu/CMakeFiles
[ 27%] Building CXX object CMakeFiles/lmms.dir/src/core/Mixer.o
/usr/bin/c++ -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NO_DEBUG -DQT_XML_LIB
-D_REENTRANT -O2 -g -fno-exceptions -Wall -Werror=unused-function
-Wno-sign-compare -Wno-strict-overflow -Werror -g -O2 -fstack-protector-strong
-Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -fPIC -DPIC -isystem
/usr/include/qt4 -isystem /usr/include/qt4/QtGui -isystem
/usr/include/qt4/QtXml -isystem /usr/include/qt4/QtCore
-I/«PKGBUILDDIR»/obj-x86_64-linux-gnu
-I/«PKGBUILDDIR»/obj-x86_64-linux-gnu/include -I/«PKGBUILDDIR»
-I/«PKGBUILDDIR»/include -I/usr/include/SDL
-D'QT_TRANSLATIONS_DIR="/usr/share/qt4/translations"'
-D'LIB_DIR="../lib/x86_64-linux-gnu/"'
-D'PLUGIN_DIR="../lib/x86_64-linux-gnu/lmms/"' -o
CMakeFiles/lmms.dir/src/core/Mixer.o -c /«PKGBUILDDIR»/src/core/Mixer.cpp
/usr/bin/cmake -E cmake_progress_report
/«PKGBUILDDIR»/obj-x86_64-linux-gnu/CMakeFiles
[ 27%] Building CXX object CMakeFiles/lmms.dir/src/core/ladspa_2_lmms.o
/usr/bin/c++ -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NO_DEBUG -DQT_XML_LIB
-D_REENTRANT -O2 -g -fno-exceptions -Wall -Werror=unused-function
-Wno-sign-compare -Wno-strict-overflow -Werror -g -O2 -fstack-protector-strong
-Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -fPIC -DPIC -isystem
/usr/include/qt4 -isystem /usr/include/qt4/QtGui -isystem
/usr/include/qt4/QtXml -isystem /usr/include/qt4/QtCore
-I/«PKGBUILDDIR»/obj-x86_64-linux-gnu
-I/«PKGBUILDDIR»/obj-x86_64-linux-gnu/include -I/«PKGBUILDDIR»
-I/«PKGBUILDDIR»/include -I/usr/include/SDL
-D'QT_TRANSLATIONS_DIR="/usr/share/qt4/translations"'
-D'LIB_DIR="../lib/x86_64-linux-gnu/"'
-D'PLUGIN_DIR="../lib/x86_64-linux-gnu/lmms/"' -o
CMakeFiles/lmms.dir/src/core/ladspa_2_lmms.o -c
/«PKGBUILDDIR»/src/core/ladspa_2_lmms.cpp
/usr/bin/cmake -E cmake_progress_report
/«PKGBUILDDIR»/obj-x86_64-linux-gnu/CMakeFiles
[ 27%] Building CXX object CMakeFiles/lmms.dir/src/core/AutomatableModel.o
/usr/bin/c++ -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NO_DEBUG -DQT_XML_LIB
-D_REENTRANT -O2 -g -fno-exceptions -Wall -Werror=unused-function
-Wno-sign-compare -Wno-strict-overflow -Werror -g -O2 -fstack-protector-strong
-Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -fPIC -DPIC -isystem
/usr/include/qt4 -isystem /usr/include/qt4/QtGui -isystem
/usr/include/qt4/QtXml -isystem /usr/include/qt4/QtCore
-I/«PKGBUILDDIR»/obj-x86_64-linux-gnu
-I/«PKGBUILDDIR»/obj-x86_64-linux-gnu/include -I/«PKGBUILDDIR»
-I/«PKGBUILDDIR»/include -I/usr/include/SDL
-D'QT_TRANSLATIONS_DIR="/usr/share/qt4/translations"'
-D'LIB_DIR="../lib/x86_64-linux-gnu/"'
-D'PLUGIN_DIR="../lib/x86_64-linux-gnu/lmms/"' -o
CMakeFiles/lmms.dir/src/core/AutomatableModel.o -c
/«PKGBUILDDIR»/src/core/AutomatableModel.cpp
/«PKGBUILDDIR»/src/core/AutomatableModel.cpp: In member function 'void
AutomatableModel::setAutomatedValue(float)':
/«PKGBUILDDIR»/src/core/AutomatableModel.cpp:224:36: error: logical not is
only applied to the left hand side of comparison
[-Werror=logical-not-parentheses]
!(*it)->fittedValue( m_value ) !=
^
cc1plus: all warnings being treated as errors
make[3]: *** [CMakeFiles/lmms.dir/src/core/AutomatableModel.o] Error 1
CMakeFiles/lmms.dir/build.make:1344: recipe for target
'CMakeFiles/lmms.dir/src/core/AutomatableModel.o' failed
make[3]: Leaving directory '/«PKGBUILDDIR»/obj-x86_64-linux-gnu'
make[2]: *** [CMakeFiles/lmms.dir/all] Error 2
CMakeFiles/Makefile2:888: recipe for target 'CMakeFiles/lmms.dir/all' failed
make[2]: Leaving directory '/«PKGBUILDDIR»/obj-x86_64-linux-gnu'
make[1]: *** [all] Error 2
Makefile:140: recipe for target 'all' failed
make[1]: Leaving directory '/«PKGBUILDDIR»/obj-x86_64-linux-gnu'
dh_auto_build: make -j1 returned exit code 2
make: *** [build-arch] Error 2
debian/rules:15: recipe for target 'build-arch' failed
dpkg-buildpackage: error: debian/rules build-arch gave error exit status 2
--- End Message ---
--- Begin Message ---
Source: lmms
Source-Version: 1.1.3-1
We believe that the bug you reported is fixed in the latest version of
lmms, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Petter Reinholdtsen <[email protected]> (supplier of updated lmms package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Mon, 21 Sep 2015 13:54:02 +0200
Source: lmms
Binary: lmms lmms-common
Architecture: source
Version: 1.1.3-1
Distribution: unstable
Urgency: low
Maintainer: Debian Edu Packaging Team
<[email protected]>
Changed-By: Petter Reinholdtsen <[email protected]>
Description:
lmms - Linux Multimedia Studio
lmms-common - Linux Multimedia Studio - common files
Closes: 777989 788457
Changes:
lmms (1.1.3-1) unstable; urgency=low
.
* New upstream version 1.1.3 (Closes: #788457).
- Drop well-defined-loop.patch, included upstream.
* Add config for git-buildpackage to use pristine-tar all the time.
* Change homepage url to new http://lmms.io/.
* Added fluid as build-depend.
* New patch find-fluid.patch to find the fluid binary in unstable.
* New patch gcc5.patch to get the code building with gcc 5 in
unstable (Closes: #777989).
* Added man-page-adjustment.patch to fix manpage formatting of AUTHOR
block. Discovered thanks to lintian.
Checksums-Sha1:
da6160f484ce79e259eaf44933da07374be4af15 2480 lmms_1.1.3-1.dsc
5795b48f232d44abdeeacdbb24037d5def5c5973 16843533 lmms_1.1.3.orig.tar.gz
4ae61e7b3d040b3b32eb5e7c52a91219cc1386ce 9688 lmms_1.1.3-1.debian.tar.xz
Checksums-Sha256:
e3e3fc1867486d1d7dc4561a8db7e56e106b8dd3ee980b35ddca5d442c6b1935 2480
lmms_1.1.3-1.dsc
59338e7b90e02fe18db73114aefe479c0e6d1e0e366185d71ea5c1a1e0f9e6bc 16843533
lmms_1.1.3.orig.tar.gz
7a9cf33ea17b3555da7b7a21824f72aa9568d701e9399397f45bd43132ef0893 9688
lmms_1.1.3-1.debian.tar.xz
Files:
cc679133034e7797256759e91e354305 2480 sound optional lmms_1.1.3-1.dsc
88d9e66d240b711c37315e3c9da644a1 16843533 sound optional lmms_1.1.3.orig.tar.gz
932788c9c13c3db2b51e1139798988df 9688 sound optional lmms_1.1.3-1.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
Comment: Debian powered!
iQJ8BAEBCgBmBQJV//VhXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRGM0REMDlGOERBODdEMURGNTA0NkM5OUIw
NjEyRjQ5NDRFQ0RDRDVBAAoJEAYS9JROzc1aqKUP/jqHDWw2qyLj3fh6or7Jm3Pp
hqaOz9p8jQdyk5TnWvK9ZQ368V36SzCVjR9LG7HBzZTgGd/wsuZcaBLCxZyjq/uh
EqP/g8lLyeGW07ewsKYJPdTd6KebIcehiNbxureIslptMRrpmGElSipJ1yrB7/6d
9GDZk/8gvOqkFeZuAaJIeNesBRelINz9pw99yGdivQmuXMqL8FwAmJ+fQGyq7Fbf
izkj4eGpctd6RZYZmAN3FkpMmuUSZ5WZSRNzF/3aPwEE5AM6fuclEJPoWTRE2pVY
y2fDcuLflJcN1k5VqMMbkEJey5rSiZBTWesvkqLBw07i4vb66X7ZmOtLoKWFPdc2
09oRXoH4Pi7rPDSvgj9XppnucSZuvq/5zLSoP7Yl45n1w6IlSHuRjwy89NkiQ0Kf
UPRVQZQ9TAlw8m0Zx/4mMECXW6qQb4crIuaKg7LaV8KE4lPKSe3Qb/G6rrRbBxKt
BmILJfV+0b7UZ6XRnzAlevyudv4BTDKzH1bdbFeCck2upQeYNz69zIQPJYiI1pE4
mpdbvQTW/frNVeHA1PAXcqe1PmCXXz7kRRKsSxn60Dz+1Uqc8wnWJqr0Ro2kPJ4S
tOfwucMZq6Ss604ReBzJzINDkBhqiW89Dg8VONHbJjkkGfi70sZxL4GX34gwiRwz
VyXEd4XEM3lo6gPW1Ojj
=VwXa
-----END PGP SIGNATURE-----
--- End Message ---