Your message dated Tue, 29 Sep 2015 22:05:33 +0000
with message-id <[email protected]>
and subject line Bug#800454: fixed in yoshimi 1.3.6-2
has caused the Debian Bug report #800454,
regarding yoshimi: please remove unused build-dep on libjpeg9-dev
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
800454: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=800454
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: yoshimi
Version: 1.3.5.1-1
Tags: patch

Hi Maintainer

Please remove the unused build dependency on libjpeg9-dev from yoshimi.
It is not possible to synchronize yoshimi directly into Ubuntu as libjpeg9-dev does not exist there. In Debian and Ubuntu the libjpeg build dependency should be unversioned, i.e. libjpeg-dev, see [1] [2]. However, since yoshimi does not need this build dependency, it can be removed altogether.

While looking at the packaging, I noticed the following line in debian/rules:

LDFLAGS+=-Wl,--as-needed

This has no effect.  What you want is this (see [3]):

export DEB_LDFLAGS_MAINT_APPEND=-Wl,--as-needed

Lastly, the generated file src/version.txt is not removed after building, this prevents the package from being built twice in a row.

Please see the attached patch that makes all of these changes.

Regards
Graham


[1] https://wiki.debian.org/LJTTransition
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=717076#235
[3] https://wiki.debian.org/HardeningWalkthrough#debhelper_9

diff -Nru yoshimi-1.3.6/debian/clean yoshimi-1.3.6/debian/clean
--- yoshimi-1.3.6/debian/clean	1970-01-01 02:00:00.000000000 +0200
+++ yoshimi-1.3.6/debian/clean	2015-09-29 17:58:43.000000000 +0200
@@ -0,0 +1 @@
+src/version.txt
diff -Nru yoshimi-1.3.6/debian/control yoshimi-1.3.6/debian/control
--- yoshimi-1.3.6/debian/control	2015-07-01 07:56:25.000000000 +0200
+++ yoshimi-1.3.6/debian/control	2015-09-29 17:34:10.000000000 +0200
@@ -25,7 +25,6 @@
  libcairo2-dev,
  sharutils,
  lv2-dev,
- libjpeg9-dev,
  libxft-dev
 Standards-Version: 3.9.6
 Vcs-Git: git://anonscm.debian.org/pkg-multimedia/yoshimi.git
diff -Nru yoshimi-1.3.6/debian/rules yoshimi-1.3.6/debian/rules
--- yoshimi-1.3.6/debian/rules	2015-05-10 21:30:03.000000000 +0200
+++ yoshimi-1.3.6/debian/rules	2015-09-29 18:00:41.000000000 +0200
@@ -1,6 +1,6 @@
 #!/usr/bin/make -f
 
-LDFLAGS+=-Wl,--as-needed
+export DEB_LDFLAGS_MAINT_APPEND=-Wl,--as-needed
 
 ifneq (,$(findstring :$(DEB_HOST_ARCH_CPU):,:amd64:))
 CXXFLAGS+=-msse -msse2 -mfpmath=sse

--- End Message ---
--- Begin Message ---
Source: yoshimi
Source-Version: 1.3.6-2

We believe that the bug you reported is fixed in the latest version of
yoshimi, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jaromír Mikeš <[email protected]> (supplier of updated yoshimi package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Tue, 29 Sep 2015 23:29:11 +0200
Source: yoshimi
Binary: yoshimi yoshimi-data yoshimi-dbg
Architecture: source all amd64
Version: 1.3.6-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers 
<[email protected]>
Changed-By: Jaromír Mikeš <[email protected]>
Description:
 yoshimi    - software synthesizer based on ZynAddSubFX
 yoshimi-data - Presets for Yoshimi
 yoshimi-dbg - Debugging symbols for Yoshimi
Closes: 800454
Changes:
 yoshimi (1.3.6-2) unstable; urgency=medium
 .
   * Add clean file to enable build twice in row.
   * Append ldflags properly.
   * Remove libjpeg9-dev build-dep.(Closes: #800454)
Checksums-Sha1:
 98af01e9c757875a82b882b9cd9168b06c862480 2366 yoshimi_1.3.6-2.dsc
 8e68c72eb84fb8b03c1259833f66f5b38a3baaea 5948 yoshimi_1.3.6-2.debian.tar.xz
 5a372755662688903de3f252d8b47b38c314fcf5 2094782 yoshimi-data_1.3.6-2_all.deb
 aca3a75bc21626bea4ac372e1b70a66605be4a24 5071084 yoshimi-dbg_1.3.6-2_amd64.deb
 c76ca407729e2474cb39315a241af586a2d731e8 569716 yoshimi_1.3.6-2_amd64.deb
Checksums-Sha256:
 2cb4e572a4fd0d156d591b70e0275a63b33cef75b001246ffef4fc22c5d1f6f5 2366 
yoshimi_1.3.6-2.dsc
 7abcc198429897349ce6caf1dc8bf862ea120793122fb554030439f96d1a921d 5948 
yoshimi_1.3.6-2.debian.tar.xz
 4dc7f5bd92dc95fbf0100481609845641ffde3b6acf2bd475ba45d4738b4b918 2094782 
yoshimi-data_1.3.6-2_all.deb
 a6a55b15b4a1817695ce06561d83eadb8615ca68f5c5c473b02deb25453b1ccd 5071084 
yoshimi-dbg_1.3.6-2_amd64.deb
 3b8f00408e77153088874069966a2d5dcf0558e27f78c55e74c25f42494a2d54 569716 
yoshimi_1.3.6-2_amd64.deb
Files:
 0e8f4e2add4261f07d5af42066ec4a20 2366 sound optional yoshimi_1.3.6-2.dsc
 a636a0a67d9bbabea683153ce7bca562 5948 sound optional 
yoshimi_1.3.6-2.debian.tar.xz
 1c5737358c69a04815fc9ee267f62001 2094782 sound optional 
yoshimi-data_1.3.6-2_all.deb
 66933a0751e2b704c6fdf8fe38e3f688 5071084 debug extra 
yoshimi-dbg_1.3.6-2_amd64.deb
 bc30c8deae6beae0ed9ef65cc9ed2078 569716 sound optional 
yoshimi_1.3.6-2_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJWCwfCAAoJEFsBlFXiuE+lQDMP/3JSHULcJD1TUljSdA7kLY2Z
CM9NLQTjDxfj0sMP5gRjWLhIug2RtIGjXG2298T3ILW7cGZTWy3PmQ2tC/pP9eui
HoPw9/p/P6aV+HVSc6ytIpScTVhcXW2INEn2Nbva9Lio0PKxV7aUWYPXEinb1fSw
NP1wGyHpfdLXiPAsQ+rqrZ2HHCd0Z3ZBQzj4Wmg8ndloiH4fRdyIPhRVMP3bME3d
lKTlHz3itS6Uij4oBPFwGkuxTrvRq9ZWARZUHgg5ilcge0QCW28nuxPegW0t2YSG
+2JNySItrItqZddzekNKcEYd/rvi7/v3p8+jY6QQZj+8zUbIKp+0rlNprT+xykzd
f385OBgGhcLKrdkeA3SNEpdYQ2ewWCIH2ciEni7ABYWKf8IFdAoZlWHQHBMK6ILu
da1XQZoSoo4o8+GivO5sjrrBsCumNG7CzMUt1shRVGwl/ulIMS0DjY1V+ZIGldW9
WgI9r5R0azluVU2kyBhuf5LfZpuTCzWS/OLVIhWYQgVpQH5z0G3fMXpD8D3T/JLc
ZhANcLoj546zbYDtaq/iZsakMt9pooTuPWuT5GJdZgh1APVS/6E1Tq1qHGzbKzny
z3G70P5Q6INRjmAU1XM03g687YcGp3AX5ysNfRDakorJhcYH+COjC0pFqdcnyWwr
UOPaYUowuiEI8Z2xREDC
=+W2L
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to