Your message dated Sun, 01 Nov 2015 19:08:03 +0000 with message-id <1446404883.2945602.426023321.3ced5...@webmail.messagingengine.com> and subject line Re: Processed: Re: haskell-devscripts: please support UTF-8 encoded debian/control files in dh_haskell_depends has caused the Debian Bug report #793944, regarding haskell-devscripts: please support UTF-8 encoded debian/control files in dh_haskell_depends to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 793944: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=793944 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Source: haskell-devscripts Version: 0.9.10 Severity: wishlist Tags: patch User: [email protected] Usertags: toolchain X-Debbugs-Cc: [email protected] Hi, While working on the "reproducible builds" effort [1], we have noticed that haskell-devscripts produces different packages depending on the build locale. This is due to grep(1) identifying a file as "binary" and thus returns "binary file matches" instead of the actual lines that match and therefore the substvar files are not populated correctly. This can be seen in the wild in "haskell-yi-language" where the unicode ellipsis character in the package long description causes the resulting package to have — or not have — a Recommends field based on whether it was built in a UTF-8 locale or not. The attached patch uses the -a switch to bypass grep's automagic. [1]: https://wiki.debian.org/ReproducibleBuilds Regards, -- ,''`. : :' : Chris Lamb `. `'` [email protected] / chris-lamb.co.uk `-diff --git a/dh_haskell_depends b/dh_haskell_depends index 97af37b..3ecebec 100644 --- a/dh_haskell_depends +++ b/dh_haskell_depends @@ -88,10 +88,10 @@ for pkg in `dh_listpackages $args`; do echo "haskell:Recommends=" >> $sfile.tmp doc=`echo $pkg | sed -e 's/-dev$/-doc/'` prof=`echo $pkg | sed -e 's/-dev$/-prof/'` - grep -v '^#' debian/control | grep $doc > /dev/null \ + grep -av '^#' debian/control | grep $doc > /dev/null \ && suggests="$doc" \ || suggests="" - if grep -v '^#' debian/control | grep $prof > /dev/null + if grep -av '^#' debian/control | grep $prof > /dev/null then [ "$suggests" = "" ] \ && suggests="$prof" \ @@ -143,7 +143,7 @@ for pkg in `dh_listpackages $args`; do | sort -u \ | sed -e :a -e '$!N; s/\n/, /; ta'` dev=`echo $pkg | sed -e 's/^[^-]\+-\(.\+\)-doc/lib${hc}-\1-dev/'` - grep -v '^#' debian/control | grep $dev > /dev/null \ + grep -av '^#' debian/control | grep $dev > /dev/null \ && recommends="$recommends, $dev" \ || recommends="$recommends" echo "haskell:Recommends=$recommends" >> $sfile.tmp
--- End Message ---
--- Begin Message ---Hi all, > > So yes, the issue with disappearing Recommends (which should be > > solved by this bug) is still there. Actually, this turned out to be an entirely separate issue in Haddock, namely #738372. It only looks like it because it has similar effects (package dependendies) and trigger (locale). I am therefore re-closing this bug. I have also: * Tidied the metadata and added a summary to #738372 for the next person * Filed #803687: Should refuse to create an empty documentation packages * Filed #803684: Don't print a warning if there are no -doc package Recommends * Filed #803685: Please print status messages when generating haddock documentation Regards, -- ,''`. : :' : Chris Lamb `. `'` [email protected] / chris-lamb.co.uk `-
--- End Message ---
